[PATCH 08/10] notmuch-config: header for index() prototype (Solaris support)

2012-11-04 Thread Tomi Ollila
On Sun, Nov 04 2012, Jani Nikula wrote: > On Sun, 04 Nov 2012, Blake Jones wrote: >> Linux, FreeBSD, and Solaris all expect to find the prototype for >> "index()" in . On some operating systems, including >> is sufficient to get the prototype, but that's not the case >> on Solaris. This patch

[PATCH 00/10] Solaris support

2012-11-04 Thread Jani Nikula
On Sun, 04 Nov 2012, Blake Jones wrote: > Hi all, > > This patch series fixes several issues which are needed to allow notmuch > to build on Solaris 11. I've been "testing" it for a month or so by > using Karel Zak's fork of mutt along with a copy of notmuch-0.13.2 that > I got to compile.

[PATCH 05/10] install: check for non-SysV version (Solaris support)

2012-11-04 Thread Jani Nikula
On Sun, 04 Nov 2012, Blake Jones wrote: > Solaris ships a program called "install" in /usr/sbin, which performs a > task that's fairly similar to the GNU and BSD "install" programs but > which uses very different command line arguments. In particular, if it > is invoked without "-c", "-f", or

Automatic suppression of non-duplicate messages

2012-11-04 Thread Austin Clements
Quoth Jani Nikula on Nov 05 at 12:34 am: > On Sat, 03 Nov 2012, David Bremner wrote: > > Eirik Byrkjeflot Anonsen writes: > > > >> That's not what I see. If I search for a term that only appears in > >> one of the "copies", none of the copies are included in the search > >> result. > > > > The

[PATCH 08/10] notmuch-config: header for index() prototype (Solaris support)

2012-11-04 Thread Jani Nikula
On Sun, 04 Nov 2012, Blake Jones wrote: > Linux, FreeBSD, and Solaris all expect to find the prototype for > "index()" in . On some operating systems, including > is sufficient to get the prototype, but that's not the case > on Solaris. This patch just modifies notmuch-config.c to include >

[PATCH 10/10] timegm: add portable implementation (Solaris support)

2012-11-04 Thread Jani Nikula
On Sun, 04 Nov 2012, Blake Jones wrote: > Hi Jani, > >> I'd prefer to use timegm() where available, and the suggested >> alternative [1] elsewhere. >> >> [1] http://www.kernel.org/doc/man-pages/online/pages/man3/timegm.3.html > > I considered this alternative, but decided against it because it's

[PATCH 05/10] install: check for non-SysV version (Solaris support)

2012-11-04 Thread Blake Jones
> > +INSTALL="install" > > +printf "Checking for working \"install\" program... " > > +mkdir _tmp_ > > This doesn't feel like a hot idea. Out of curiosity, why not? An "install" that behaves as expected is one of the first things that an autoconf-generated "configure" looks for. Now,

[PATCH 08/10] notmuch-config: header for index() prototype (Solaris support)

2012-11-04 Thread Blake Jones
>> On Sun, 04 Nov 2012, Blake Jones wrote: >>> Linux, FreeBSD, and Solaris all expect to find the prototype for >>> "index()" in . On some operating systems, including >>> is sufficient to get the prototype, but that's not the case >>> on Solaris. This patch just modifies notmuch-config.c to

[PATCH 10/10] timegm: add portable implementation (Solaris support)

2012-11-04 Thread Blake Jones
> That is a valid point. Yet it doesn't change the fact that I'd prefer > to use timegm() where available. Internally, glibc uses the same code > to implement both timegm() and mktime(), and I'd hate it if the > results were subtly different depending on whether the time zone was > specified in

[PATCH 10/10] timegm: add portable implementation (Solaris support)

2012-11-04 Thread Jani Nikula
m_min -= get_field (state, TM_TZ); > - t = timegm (); > + t = local_timegm (); > } else { > /* tm is in local time. */ > t = mktime (); > -- > 1.7.9.2 > > ___ > notmuch mailing list > notmuch at notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch -- next part -- An HTML attachment was scrubbed... URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20121104/511b837a/attachment-0001.html>

Automatic suppression of non-duplicate messages

2012-11-04 Thread Eirik Byrkjeflot Anonsen
David Bremner writes: > Eirik Byrkjeflot Anonsen writes: > >> That's not what I see. If I search for a term that only appears in >> one of the "copies", none of the copies are included in the search >> result. > > The offending code is at line 1813 of lib/database.cc; the message is > only

[PATCH 10/10] timegm: add portable implementation (Solaris support)

2012-11-04 Thread Blake Jones
Hi Jani, > I'd prefer to use timegm() where available, and the suggested > alternative [1] elsewhere. > > [1] http://www.kernel.org/doc/man-pages/online/pages/man3/timegm.3.html I considered this alternative, but decided against it because it's completely MT-unsafe. I don't know whether

[PATCH v2] contrib: notmuch-pick: add tests

2012-11-04 Thread Tomi Ollila
On Thu, Nov 01 2012, Mark Walters wrote: > The test should be run using the wrapper run-tests.sh. This links > the tests into the normal notmuch TEST_DIRECTORY and runs them from > there. After the test is complete then the links are removed. > --- 2 things: The PICK_DIR variable needs export

[PATCH 09/10] debugger.c: correct return type from getppid() (Solaris support)

2012-11-04 Thread Blake Jones
Cast the return value of getppid() to int from pid_t in debugger.c, since it is being passed to sprintf(%d), which wants an int argument. On Solaris, pid_t is a long for 32-bit programs. --- debugger.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/debugger.c b/debugger.c

[PATCH 04/10] configure: check for -Wl,-rpath (Solaris support)

2012-11-04 Thread Blake Jones
Add a check to configure to see whether -Wl,-rpath can be used without --enable-new-dtags. Solaris needs the former and doesn't know about the latter. --- configure |4 1 file changed, 4 insertions(+) diff --git a/configure b/configure index 28d4110..5c5139f 100755 --- a/configure +++

[PATCH 08/10] notmuch-config: header for index() prototype (Solaris support)

2012-11-04 Thread Blake Jones
Linux, FreeBSD, and Solaris all expect to find the prototype for index() in strings.h. On some operating systems, including string.h is sufficient to get the prototype, but that's not the case on Solaris. This patch just modifies notmuch-config.c to include strings.h to get the prototype. ---

[PATCH 03/10] gethostbyname: check for libnsl (Solaris support)

2012-11-04 Thread Blake Jones
Add a check to configure to see whether -lnsl is needed for programs that are using gethostbyname(). This change also adds the file compat/check_ghbn.c, which configure uses to perform its check. --- compat/check_ghbn.c |8 configure | 17 - 2 files

[PATCH 10/10] timegm: add portable implementation (Solaris support)

2012-11-04 Thread Blake Jones
The timegm(3) function is a non-standard extension to libc which is available in GNU libc and on some BSDs. Although SunOS had this function in its libc, Solaris (unfortunately) removed it. This patch implements a very simple version of timegm() which is good enough for parse-time-string.c.

[PATCH 01/10] getpwuid: check for standards compliance (Solaris support)

2012-11-04 Thread Blake Jones
Add checks to configure to see whether _POSIX_PTHREAD_SEMANTICS needs to be defined to get the right number of arguments in the prototypes for getpwuid_r(). Solaris' default implementation conforms to POSIX.1c Draft 6, rather than the final POSIX.1c spec. The standards-compliant version can be

[PATCH 07/10] gen-version-script: parse Solaris nm output (Solaris support)

2012-11-04 Thread Blake Jones
The output of nm on Solaris is substantially different from that on Linux, and the current version of gen-version-script is tied to the Linux nm output. This patch separates the parts of nm processing which are dependent on the output format into a couple shell functions, and makes another shell

[PATCH 02/10] asctime: check for standards compliance (Solaris support)

2012-11-04 Thread Blake Jones
Add checks to configure to see whether _POSIX_PTHREAD_SEMANTICS needs to be defined to get the right number of arguments in the prototypes for asctime_r(). Solaris' default implementation conforms to POSIX.1c Draft 6, rather than the final POSIX.1c spec. The standards-compliant version can be

[PATCH 06/10] strsep: check for availability (Solaris support)

2012-11-04 Thread Blake Jones
Solaris does not ship a version of the strsep() function. This change adds a check to configure to see whether notmuch needs to provide its own implementation, and if so, it uses the new version in compat/strsep.c (which was copied from Mutt, and apparently before that from glibc). ---

[PATCH 05/10] install: check for non-SysV version (Solaris support)

2012-11-04 Thread Blake Jones
Solaris ships a program called install in /usr/sbin, which performs a task that's fairly similar to the GNU and BSD install programs but which uses very different command line arguments. In particular, if it is invoked without -c, -f, or -n, it will search the target directory for a file with the

[PATCH 00/10] Solaris support

2012-11-04 Thread Blake Jones
Hi all, This patch series fixes several issues which are needed to allow notmuch to build on Solaris 11. I've been testing it for a month or so by using Karel Zak's fork of mutt along with a copy of notmuch-0.13.2 that I got to compile. After a friend asked for a copy of my setup, I decided to

Re: Automatic suppression of non-duplicate messages

2012-11-04 Thread Eirik Byrkjeflot Anonsen
David Bremner da...@tethera.net writes: Eirik Byrkjeflot Anonsen ei...@eirikba.org writes: That's not what I see. If I search for a term that only appears in one of the copies, none of the copies are included in the search result. The offending code is at line 1813 of lib/database.cc; the

Re: [PATCH 10/10] timegm: add portable implementation (Solaris support)

2012-11-04 Thread Jani Nikula
On Nov 4, 2012 11:30 AM, Blake Jones bla...@foo.net wrote: The timegm(3) function is a non-standard extension to libc which is available in GNU libc and on some BSDs. Although SunOS had this function in its libc, Solaris (unfortunately) removed it. This patch implements a very simple

Re: [PATCH 10/10] timegm: add portable implementation (Solaris support)

2012-11-04 Thread Jani Nikula
On Sun, 04 Nov 2012, Blake Jones bla...@foo.net wrote: Hi Jani, I'd prefer to use timegm() where available, and the suggested alternative [1] elsewhere. [1] http://www.kernel.org/doc/man-pages/online/pages/man3/timegm.3.html I considered this alternative, but decided against it because

Re: [PATCH 08/10] notmuch-config: header for index() prototype (Solaris support)

2012-11-04 Thread Jani Nikula
On Sun, 04 Nov 2012, Blake Jones bla...@foo.net wrote: Linux, FreeBSD, and Solaris all expect to find the prototype for index() in strings.h. On some operating systems, including string.h is sufficient to get the prototype, but that's not the case on Solaris. This patch just modifies

Re: [PATCH 10/10] timegm: add portable implementation (Solaris support)

2012-11-04 Thread Blake Jones
Hi Jani, I'd prefer to use timegm() where available, and the suggested alternative [1] elsewhere. [1] http://www.kernel.org/doc/man-pages/online/pages/man3/timegm.3.html I considered this alternative, but decided against it because it's completely MT-unsafe. I don't know whether libnotmuch

Re: [PATCH 05/10] install: check for non-SysV version (Solaris support)

2012-11-04 Thread Jani Nikula
On Sun, 04 Nov 2012, Blake Jones bla...@foo.net wrote: Solaris ships a program called install in /usr/sbin, which performs a task that's fairly similar to the GNU and BSD install programs but which uses very different command line arguments. In particular, if it is invoked without -c, -f, or

Re: [PATCH 00/10] Solaris support

2012-11-04 Thread Jani Nikula
On Sun, 04 Nov 2012, Blake Jones bla...@foo.net wrote: Hi all, This patch series fixes several issues which are needed to allow notmuch to build on Solaris 11. I've been testing it for a month or so by using Karel Zak's fork of mutt along with a copy of notmuch-0.13.2 that I got to compile.

Re: [PATCH 08/10] notmuch-config: header for index() prototype (Solaris support)

2012-11-04 Thread Tomi Ollila
On Sun, Nov 04 2012, Jani Nikula wrote: On Sun, 04 Nov 2012, Blake Jones bla...@foo.net wrote: Linux, FreeBSD, and Solaris all expect to find the prototype for index() in strings.h. On some operating systems, including string.h is sufficient to get the prototype, but that's not the case on

Re: Automatic suppression of non-duplicate messages

2012-11-04 Thread Jani Nikula
On Sat, 03 Nov 2012, David Bremner da...@tethera.net wrote: Eirik Byrkjeflot Anonsen ei...@eirikba.org writes: That's not what I see. If I search for a term that only appears in one of the copies, none of the copies are included in the search result. The offending code is at line 1813 of

Re: Automatic suppression of non-duplicate messages

2012-11-04 Thread Austin Clements
Quoth Jani Nikula on Nov 05 at 12:34 am: On Sat, 03 Nov 2012, David Bremner da...@tethera.net wrote: Eirik Byrkjeflot Anonsen ei...@eirikba.org writes: That's not what I see. If I search for a term that only appears in one of the copies, none of the copies are included in the search

Re: [PATCH 10/10] timegm: add portable implementation (Solaris support)

2012-11-04 Thread Blake Jones
That is a valid point. Yet it doesn't change the fact that I'd prefer to use timegm() where available. Internally, glibc uses the same code to implement both timegm() and mktime(), and I'd hate it if the results were subtly different depending on whether the time zone was specified in the

Re: [PATCH 08/10] notmuch-config: header for index() prototype (Solaris support)

2012-11-04 Thread Blake Jones
On Sun, 04 Nov 2012, Blake Jones bla...@foo.net wrote: Linux, FreeBSD, and Solaris all expect to find the prototype for index() in strings.h. On some operating systems, including string.h is sufficient to get the prototype, but that's not the case on Solaris. This patch just modifies

notmuch search and tags

2012-11-04 Thread Aneesh Kumar K.V
We have the mails appearing as below now. Earlier the tags towards the end used be enclosed in ( ) [21/21] Today 10:57Blake Jones, Jani Nikula, Tomi Ollila[PATCH 05/10] install: check for non-SysV version (Solaris support) notmuch unread [5/5] Today 09:58Eirik Byrkjeflot