[PATCH v3] contrib: notmuch-pick: add tests

2012-11-07 Thread Tomi Ollila
On Wed, Nov 07 2012, Mark Walters wrote: > The test should be run using the wrapper run-tests.sh. This links > the tests into the normal notmuch TEST_DIRECTORY and runs them from > there. After the test is complete then the links are removed. > --- > > Version 2 is at id:1351797910-19305-1-git-s

Re: [PATCH v2 07/10] gen-version-script: parse Solaris "nm" output (Solaris support)

2012-11-07 Thread Blake Jones
>> @@ -11,10 +12,44 @@ fi >> HEADER=$1 >> shift >> >> +if [ `uname -s` == SunOS ] ; then >> +# >> +# Using Solaris "nm", a defined symbol looks like this: >> +# > > The POSIX / Bourne -comformant equality comparison is '='. Sigh, of course it is. Fixed. > e.g. > > $ ./heirloom

[PATCH v2 07/10] gen-version-script: parse Solaris "nm" output (Solaris support)

2012-11-07 Thread Blake Jones
>> @@ -11,10 +12,44 @@ fi >> HEADER=$1 >> shift >> >> +if [ `uname -s` == SunOS ] ; then >> +# >> +# Using Solaris "nm", a defined symbol looks like this: >> +# > > The POSIX / Bourne -comformant equality comparison is '='. Sigh, of course it is. Fixed. > e.g. > > $ ./heirloom

Re: [PATCH v2 05/10] install: check for non-SysV version (Solaris support)

2012-11-07 Thread Blake Jones
> > diff --git a/vim/Makefile b/vim/Makefile > > index f17bebf..7ceba7a 100644 > > --- a/vim/Makefile > > +++ b/vim/Makefile > > @@ -5,8 +5,6 @@ files = plugin/notmuch.vim \ > > prefix = $(HOME)/.vim > > destdir = $(prefix)/plugin > > > > -INSTALL = install -D -m644 > > - > > all: help > > >

[PATCH v2 05/10] install: check for non-SysV version (Solaris support)

2012-11-07 Thread Blake Jones
> > diff --git a/vim/Makefile b/vim/Makefile > > index f17bebf..7ceba7a 100644 > > --- a/vim/Makefile > > +++ b/vim/Makefile > > @@ -5,8 +5,6 @@ files = plugin/notmuch.vim \ > > prefix = $(HOME)/.vim > > destdir = $(prefix)/plugin > > > > -INSTALL = install -D -m644 > > - > > all: help > > >

[PATCH] fix notmuch_database_open call in addrlookup

2012-11-07 Thread James Vasile
J Just to close the loop: I contacted Sebastian and he applied my patch. I tested the instructions on the wiki and confirmed they are currently correct against his tree. He notes that he doesn't currently have time to monitor the list closely. Thanks, -J -- next part

[PATCH v3] contrib: notmuch-pick: add tests

2012-11-07 Thread Mark Walters
The test should be run using the wrapper run-tests.sh. This links the tests into the normal notmuch TEST_DIRECTORY and runs them from there. After the test is complete then the links are removed. --- Version 2 is at id:1351797910-19305-1-git-send-email-markwalters1009 at gmail.com. This version

[PATCH 1/1] notmuch-show.el: extended icalendar unfolding with single CR removal

2012-11-07 Thread Tomi Ollila
On Wed, Nov 07 2012, Tomi Ollila wrote: > On Thu, Oct 04 2012, Tomi Ollila wrote: > >> In case text/calendar content contained "folded" data (i.e. line >> continues to next line which begins with whitespace... >> >> or >> >> The text/calendar content is inside separate (application/octet-stream)

[PATCH 1/1] notmuch-show.el: extended icalendar unfolding with single CR removal

2012-11-07 Thread Tomi Ollila
On Thu, Oct 04 2012, Tomi Ollila wrote: > In case text/calendar content contained "folded" data (i.e. line > continues to next line which begins with whitespace... > > or > > The text/calendar content is inside separate (application/octet-stream) > content and the text/calendar entry there contain

[PATCH 1/1] notmuch-show.el: extended icalendar unfolding with single CR removal

2012-11-07 Thread Tomi Ollila
In case text/calendar content contained "folded" data (i.e. line continues to next line which begins with whitespace... or The text/calendar content is inside separate (application/octet-stream) content and the text/calendar entry there contains carriage returns... ... The parsing of text/calend

Re: [PATCH] fix notmuch_database_open call in addrlookup

2012-11-07 Thread James Vasile
James Vasile writes: > Ethan Glasser-Camp writes: > >> James Vasile writes: >> >>> What's the best way to submit changes to addrlookup? Right now, it is >>> out of date vs the latest libnotmuch. The addrlookup repo is vala code >>> but the wiki [1] points to a generated c file [2]. >>> >>> [1]

[PATCH 0/3] Sync devel/schemata with code

2012-11-07 Thread Tomi Ollila
On Wed, Nov 07 2012, Austin Clements wrote: > There were some recent changes to the JSON format without accompanying > schema documentation changes [1, 2]. Though, curiously, [1] was > documented in the schema long before it was implemented owing to a > historical twist (we *used* to have Bcc in

[PATCH] emacs: display tags in notmuch-show's header-line with links to search

2012-11-07 Thread Mark Walters
Hi He is using header-line to mean the very top line of the buffer (which does not scroll) not just the first line of the message. Best wishes Mark Jameson Graef Rollins writes: > On Tue, Nov 06 2012, Damien Cassou wrote: >> In notmuch-show, the header-line was previously only showing the

[PATCH] Add NEWS information about Bcc header in JSON output

2012-11-07 Thread Tomi Ollila
On Wed, Nov 07 2012, David Bremner wrote: > Michal Nazarewicz writes: > >> This commit adds a note to the NEWS file about Bcc header now being >> available in the JSON output (and thus in Emacs) which has been >> implemented by commit ffb629cc5d2c2d1505eb5aefcf04fb4d0af6c0c8. > > Hmm. I was about

[PATCH] Add NEWS information about Bcc header in JSON output

2012-11-07 Thread Michal Nazarewicz
+--ooO--(_)--Ooo-- -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20121107/1513b9e2/attachment.pgp>

Re: [PATCH v3] contrib: notmuch-pick: add tests

2012-11-07 Thread Tomi Ollila
On Wed, Nov 07 2012, Mark Walters wrote: > The test should be run using the wrapper run-tests.sh. This links > the tests into the normal notmuch TEST_DIRECTORY and runs them from > there. After the test is complete then the links are removed. > --- > > Version 2 is at > id:1351797910-19305-1-gi

[PATCH v3] contrib: notmuch-pick: add tests

2012-11-07 Thread Mark Walters
The test should be run using the wrapper run-tests.sh. This links the tests into the normal notmuch TEST_DIRECTORY and runs them from there. After the test is complete then the links are removed. --- Version 2 is at id:1351797910-19305-1-git-send-email-markwalters1...@gmail.com. This versions fi

[PATCH 3/3] devel: Document schemata in STYLE

2012-11-07 Thread Austin Clements
--- devel/STYLE |6 ++ 1 file changed, 6 insertions(+) diff --git a/devel/STYLE b/devel/STYLE index 094f71d..0792ba1 100644 --- a/devel/STYLE +++ b/devel/STYLE @@ -73,6 +73,12 @@ Naming struct has a tag, it should be the same as the typedef name, minus the trailing _t. +CLI convent

[PATCH 2/3] show: More aggressively document the presence of devel/schemata

2012-11-07 Thread Austin Clements
Previously, the only mention of devel/schemata was a comment at the top of format_part_json, but the JSON output code is spread across several functions that are distributed across notmuch-show.c. Add references from the other three key JSON output functions. --- notmuch-show.c |9 +

[PATCH 1/3] devel: Add Reply-to to the schemata

2012-11-07 Thread Austin Clements
The code got out of sync with the documentation in 7d3c06dc. --- devel/schemata |1 + 1 file changed, 1 insertion(+) diff --git a/devel/schemata b/devel/schemata index 9cb25f5..e44da71 100644 --- a/devel/schemata +++ b/devel/schemata @@ -79,6 +79,7 @@ headers = { To?:string,

[PATCH 0/3] Sync devel/schemata with code

2012-11-07 Thread Austin Clements
There were some recent changes to the JSON format without accompanying schema documentation changes [1, 2]. Though, curiously, [1] was documented in the schema long before it was implemented owing to a historical twist (we *used* to have Bcc in the JSON output and then it got lost [my fault, most

[PATCH] don't show x-foo tags in search view

2012-11-07 Thread Austin Clements
The code looks good to me (two minor comments below), but, as David pointed out, this needs a commit message. Quoth James Vasile on Oct 30 at 10:57 am: > Austin, > > Thanks for the helpful comments. I redid the patch to take a list of > regexps. That way users can banish different kinds of tags

Re: [PATCH] emacs: display tags in notmuch-show's header-line with links to search

2012-11-07 Thread Jameson Graef Rollins
On Wed, Nov 07 2012, Mark Walters wrote: > He is using header-line to mean the very top line of the buffer (which > does not scroll) not just the first line of the message. Ah! ok. Gosh, I hardly ever look at that line. Makes me think I want it brighter or something. Anyway, I understand now.

[PATCH] emacs: display tags in notmuch-show's header-line with links to search

2012-11-07 Thread Jameson Graef Rollins
nd now. Tags there sounds reasonable. Thanks Mark. jamie. -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 835 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20121107

[PATCH] fix notmuch_database_open call in addrlookup

2012-11-07 Thread James Vasile
eak, so a patch to the vala source is unlikely to make it to the front of my queue this year. I'll ping Sebastian Spaeth directly and via github. -J -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 489 bytes

[PATCH] don't show x-foo tags in search view

2012-11-07 Thread James Vasile
text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 489 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20121107/d7408da8/attachment.pgp>

[PATCH] don't show x-foo tags in search view

2012-11-07 Thread David Bremner
James Vasile writes: > Austin, > > Thanks for the helpful comments. I redid the patch to take a list of > regexps. That way users can banish different kinds of tags or simply > list the tags themselves. I've responded to your comments in text below > the patch. > I think the patch is probably

Re: [PATCH] emacs: display tags in notmuch-show's header-line with links to search

2012-11-07 Thread Mark Walters
Hi He is using header-line to mean the very top line of the buffer (which does not scroll) not just the first line of the message. Best wishes Mark Jameson Graef Rollins writes: > On Tue, Nov 06 2012, Damien Cassou wrote: >> In notmuch-show, the header-line was previously only showing the

Re: [PATCH] emacs: display tags in notmuch-show's header-line with links to search

2012-11-07 Thread Jameson Graef Rollins
On Tue, Nov 06 2012, Damien Cassou wrote: > In notmuch-show, the header-line was previously only showing the > subject of the current thread. With this commit, the header-line now > additionally shows all the tags associated to the thread. Each tag is > a link to open a new notmuch-search buffer f

[PATCH] emacs: display tags in notmuch-show's header-line with links to search

2012-11-07 Thread Jameson Graef Rollins
lable URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20121107/25e4d8d4/attachment.pgp>

[PATCH 1/1] emacs/notmuch-show.el: handle bodypart insert error

2012-11-07 Thread David Bremner
Tomi Ollila writes: > When inserting of email bodypart failes, insert a failure message > to the buffer (and continue) instead of halting the insertion of > the rest of that email thread in question. Pushed, d

[PATCH v2 1/2] show: include Reply-To header in json output

2012-11-07 Thread David Bremner
Peter Wang writes: > Output the Reply-To header field if present in a message. > I want to be able to see what the sender intended in my mail client, > before hitting the reply key. Only json output is changed, > like the recently added Bcc field. Pushed, d

[PATCH] Add NEWS information about Bcc header in JSON output

2012-11-07 Thread David Bremner
Michal Nazarewicz writes: > This commit adds a note to the NEWS file about Bcc header now being > available in the JSON output (and thus in Emacs) which has been > implemented by commit ffb629cc5d2c2d1505eb5aefcf04fb4d0af6c0c8. Hmm. I was about to push this when I realized the next patches which

Re: [PATCH 1/1] notmuch-show.el: extended icalendar unfolding with single CR removal

2012-11-07 Thread Tomi Ollila
On Wed, Nov 07 2012, Tomi Ollila wrote: > On Thu, Oct 04 2012, Tomi Ollila wrote: > >> In case text/calendar content contained "folded" data (i.e. line >> continues to next line which begins with whitespace... >> >> or >> >> The text/calendar content is inside separate (application/octet-stream)

[PATCH 1/1] uncrustify.cfg: added 3 new types for uncrustify to know

2012-11-07 Thread David Bremner
Tomi Ollila writes: > Added FILE, notmuch_show_params_t and sprinter_t to be > types when uncrustifying sources. This affect spacing > when uncrustify is deciding for type declaration instead > of binary multiplication operation. pushed. d

Re: [PATCH 1/1] notmuch-show.el: extended icalendar unfolding with single CR removal

2012-11-07 Thread Tomi Ollila
On Thu, Oct 04 2012, Tomi Ollila wrote: > In case text/calendar content contained "folded" data (i.e. line > continues to next line which begins with whitespace... > > or > > The text/calendar content is inside separate (application/octet-stream) > content and the text/calendar entry there contain

[PATCH 1/1] notmuch-show.el: extended icalendar unfolding with single CR removal

2012-11-07 Thread Tomi Ollila
In case text/calendar content contained "folded" data (i.e. line continues to next line which begins with whitespace... or The text/calendar content is inside separate (application/octet-stream) content and the text/calendar entry there contains carriage returns... ... The parsing of text/calend

Re: [PATCH 0/3] Sync devel/schemata with code

2012-11-07 Thread Tomi Ollila
On Wed, Nov 07 2012, Austin Clements wrote: > There were some recent changes to the JSON format without accompanying > schema documentation changes [1, 2]. Though, curiously, [1] was > documented in the schema long before it was implemented owing to a > historical twist (we *used* to have Bcc in

[PATCH 3/3] devel: Document schemata in STYLE

2012-11-07 Thread Austin Clements
--- devel/STYLE |6 ++ 1 file changed, 6 insertions(+) diff --git a/devel/STYLE b/devel/STYLE index 094f71d..0792ba1 100644 --- a/devel/STYLE +++ b/devel/STYLE @@ -73,6 +73,12 @@ Naming struct has a tag, it should be the same as the typedef name, minus the trailing _t. +CLI conven

[PATCH 2/3] show: More aggressively document the presence of devel/schemata

2012-11-07 Thread Austin Clements
Previously, the only mention of devel/schemata was a comment at the top of format_part_json, but the JSON output code is spread across several functions that are distributed across notmuch-show.c. Add references from the other three key JSON output functions. --- notmuch-show.c |9 +

[PATCH 1/3] devel: Add Reply-to to the schemata

2012-11-07 Thread Austin Clements
The code got out of sync with the documentation in 7d3c06dc. --- devel/schemata |1 + 1 file changed, 1 insertion(+) diff --git a/devel/schemata b/devel/schemata index 9cb25f5..e44da71 100644 --- a/devel/schemata +++ b/devel/schemata @@ -79,6 +79,7 @@ headers = { To?:string,

[PATCH 0/3] Sync devel/schemata with code

2012-11-07 Thread Austin Clements
There were some recent changes to the JSON format without accompanying schema documentation changes [1, 2]. Though, curiously, [1] was documented in the schema long before it was implemented owing to a historical twist (we *used* to have Bcc in the JSON output and then it got lost [my fault, most

Re: [PATCH] don't show x-foo tags in search view

2012-11-07 Thread Austin Clements
The code looks good to me (two minor comments below), but, as David pointed out, this needs a commit message. Quoth James Vasile on Oct 30 at 10:57 am: > Austin, > > Thanks for the helpful comments. I redid the patch to take a list of > regexps. That way users can banish different kinds of tags

Re: [PATCH] fix notmuch_database_open call in addrlookup

2012-11-07 Thread James Vasile
Ethan Glasser-Camp writes: > James Vasile writes: > >> What's the best way to submit changes to addrlookup? Right now, it is >> out of date vs the latest libnotmuch. The addrlookup repo is vala code >> but the wiki [1] points to a generated c file [2]. >> >> [1] http://github.com/spaetz/vala-n

Re: [PATCH] don't show x-foo tags in search view

2012-11-07 Thread James Vasile
David Bremner writes: > James Vasile writes: > >> Austin, >> >> Thanks for the helpful comments. I redid the patch to take a list of >> regexps. That way users can banish different kinds of tags or simply >> list the tags themselves. I've responded to your comments in text below >> the patch.

Re: [PATCH] Add NEWS information about Bcc header in JSON output

2012-11-07 Thread Michal Nazarewicz
On Wed, Nov 07 2012, Tomi Ollila wrote: > Also, I don't know whether markdown allows the text in backticks (``) > be split into 2 lines -- at the end it's me who is going to do final > corrections there ;) (luckily that probably changes when more text > is added to the sentences. OK, so can I forg

Re: [PATCH] Add NEWS information about Bcc header in JSON output

2012-11-07 Thread Tomi Ollila
On Wed, Nov 07 2012, David Bremner wrote: > Michal Nazarewicz writes: > >> This commit adds a note to the NEWS file about Bcc header now being >> available in the JSON output (and thus in Emacs) which has been >> implemented by commit ffb629cc5d2c2d1505eb5aefcf04fb4d0af6c0c8. > > Hmm. I was about

Re: [PATCH] don't show x-foo tags in search view

2012-11-07 Thread David Bremner
James Vasile writes: > Austin, > > Thanks for the helpful comments. I redid the patch to take a list of > regexps. That way users can banish different kinds of tags or simply > list the tags themselves. I've responded to your comments in text below > the patch. > I think the patch is probably

Re: [PATCH 1/1] emacs/notmuch-show.el: handle bodypart insert error

2012-11-07 Thread David Bremner
Tomi Ollila writes: > When inserting of email bodypart failes, insert a failure message > to the buffer (and continue) instead of halting the insertion of > the rest of that email thread in question. Pushed, d ___ notmuch mailing list notmuch@notmuchm

Re: [PATCH v2 1/2] show: include Reply-To header in json output

2012-11-07 Thread David Bremner
Peter Wang writes: > Output the Reply-To header field if present in a message. > I want to be able to see what the sender intended in my mail client, > before hitting the reply key. Only json output is changed, > like the recently added Bcc field. Pushed, d ___

Re: [PATCH] Add NEWS information about Bcc header in JSON output

2012-11-07 Thread David Bremner
Michal Nazarewicz writes: > This commit adds a note to the NEWS file about Bcc header now being > available in the JSON output (and thus in Emacs) which has been > implemented by commit ffb629cc5d2c2d1505eb5aefcf04fb4d0af6c0c8. Hmm. I was about to push this when I realized the next patches which

Re: [PATCH 1/1] uncrustify.cfg: added 3 new types for uncrustify to know

2012-11-07 Thread David Bremner
Tomi Ollila writes: > Added FILE, notmuch_show_params_t and sprinter_t to be > types when uncrustifying sources. This affect spacing > when uncrustify is deciding for type declaration instead > of binary multiplication operation. pushed. d ___ notmuch