v4 of Performance tests

On Sun, Nov 25 2012, david at tethera.net wrote: > This version adds an optional makefile target to download the corpus. > > Tomi reviewed it on IRC and didn't complain. +1 Tomi

[Patch v2 11/17] test: add test for notmuch tag --batch option

Hi On Sat, 24 Nov 2012, david at tethera.net wrote: > From: Jani Nikula > > Basic test of functionality, along with all combinations of options. > --- > test/tagging | 46 ++ > 1 file changed, 46 insertions(+) > > diff --git a/test/tagging

[Patch v2 12/17] man: document notmuch tag --batch, --input options

On Sat, 24 Nov 2012, david at tethera.net wrote: > From: Jani Nikula > > --- > man/man1/notmuch-tag.1 | 52 > +++- > 1 file changed, 51 insertions(+), 1 deletion(-) > > diff --git a/man/man1/notmuch-tag.1 b/man/man1/notmuch-tag.1 > index

[Patch v4 2/2] test: initial performance testing infrastructure

Quoth David Bremner on Nov 25 at 8:05 pm: > Austin Clements writes: > >> +add_email_corpus takes arguments "--small" and "--medium" for when you > >> +want smaller corpuses to check. > > > > "corpora"? > > reworded to say > > , > | add_email_corpus takes arguments "--small" and "--medium"

[Patch v2 09/17] tag-util.[ch]: New files for common tagging routines

This looks good. A couple of typos and a small queries (and I agree with Tomi but I think you have already included that). On Sat, 24 Nov 2012, david at tethera.net wrote: > From: David Bremner > > These are meant to be shared between notmuch-tag and notmuch-restore. > > The bulk of the

[PATCH 3/3] lib: Reject multi-message mboxes and deprecate single-message mbox

On Sun, Nov 25 2012, Austin Clements wrote: > Quoth Tomi Ollila on Nov 25 at 3:26 pm: >> On Sun, Nov 25 2012, Austin Clements wrote: >> >> > Previously, we would treat multi-message mboxes as one giant email, >> > which, besides the obvious incorrect indexing, often led to >> > out-of-memory

[Patch v4 2/2] test: initial performance testing infrastructure

Austin Clements writes: >> +subdirs := compat completion emacs lib man parse-time-string >> +subdirs := $(subdirs) performance-test util test > += ? > Sure. >> +CORPUS_NAME := notmuch-email-corpus-$(PERFTEST_VERSION).tar.xz > > Would it make sense to split out the different size corpora so a

Notmuch scripts (again), now with more usenet

Ethan Glasser-Camp writes: > > If Bremner is willing to put this package in contrib, I think he should > do so. I guess that's fine, but I'd be more likely to get around to it if presented with a patch against git master d

[Patch v4 2/2] test: initial performance testing infrastructure

Quoth david at tethera.net on Nov 25 at 11:02 am: > From: David Bremner > > This is not near as fancy as as the unit tests, on the theory that > the code should typically be crashing when performance tuning. > Nonetheless, there is plenty of room for improvement. Several more of > the pieces of

[PATCH v2 18/20] test: add tests for insert

On Sun, 25 Nov 2012, Peter Wang wrote: > Add tests for new 'insert' command. > --- > test/insert | 93 > +++ > test/notmuch-test | 1 + > 2 files changed, 94 insertions(+) > create mode 100755 test/insert > > diff --git a/test/insert

[PATCH 0/6] API for iterating over all messages in a thread

Quoth Mark Walters on Nov 25 at 2:31 pm: > > Hi > > This series looks good to me (I have not reviewed the two bindings > patches). Patch 2 looks like it makes things much easier to follow than > the current code (if I understood the current pointer stuff it > constructs the top-level list by

[PATCH v2 19/20] man: document 'insert' command

On Sun, 25 Nov 2012, Peter Wang wrote: > Add initial documentation for notmuch insert command. > --- > man/Makefile.local| 1 + > man/man1/notmuch-insert.1 | 60 > +++ > 2 files changed, 61 insertions(+) > create mode 100644

[PATCH v2 15/20] insert: fsync new directory after rename

On Sun, 25 Nov 2012, Peter Wang wrote: > After moving the file from the 'tmp' to the 'new' directory, > fsync on the 'new' directory for durability. > --- > notmuch-insert.c | 39 --- > 1 file changed, 32 insertions(+), 7 deletions(-) > > diff --git

[PATCH v2 01/20] tag: factor out tag operation parsing

On Sun, 25 Nov 2012, Peter Wang wrote: > Factor out parsing of +tag, -tag operations from argv > into a separate function. > --- > notmuch-tag.c | 66 > +-- > 1 file changed, 41 insertions(+), 25 deletions(-) > > diff --git

[PATCH v2 00/20] insert command

This is series is looking good. I have a few minor issues but no more. There are two parts I don't really know enough about to be certain about: the fsyncing and the sigtrap bit. For fsync: I have some recollection that you have to fsync all subpaths to the root to guarantee that it makes it

BUG: notmuch stop on death symlink even..

Quoth calmar c. on Nov 24 at 8:07 pm: > hi all, > > notmuch stops/exits on death symlink even when they are on the > ignore-list at the same time. > > on: notmuch new ... arount 360maybe in notmuch-new.c The series in id:1353821145-29182-1-git-send-email-amdragon at mit.edu should fix this

[PATCH 3/3] lib: Reject multi-message mboxes and deprecate single-message mbox

On Sun, Nov 25 2012, Austin Clements wrote: > Previously, we would treat multi-message mboxes as one giant email, > which, besides the obvious incorrect indexing, often led to > out-of-memory errors for archival mboxes. Now we explicitly reject > multi-message mboxes. For historical reasons,

[PATCH v2 00/20] insert command

Peter Wang writes: > - shared tag operation parser with notmuch-tag. Sharing tag operations with notmuch-tag is definitely a good idea, but it will also conflict with the changes of the series at id:1353792017-31459-1-git-send-email-david at tethera.net Although I might be biased, my

[PATCH 0/6] API for iterating over all messages in a thread

Hi This series looks good to me (I have not reviewed the two bindings patches). Patch 2 looks like it makes things much easier to follow than the current code (if I understood the current pointer stuff it constructs the top-level list by doing pointer stuff to remove all messages which are

[PATCH 3/3] lib: Reject multi-message mboxes and deprecate single-message mbox

Quoth Tomi Ollila on Nov 25 at 3:26 pm: > On Sun, Nov 25 2012, Austin Clements wrote: > > > Previously, we would treat multi-message mboxes as one giant email, > > which, besides the obvious incorrect indexing, often led to > > out-of-memory errors for archival mboxes. Now we explicitly reject

[PATCH 0/2] Ignore ignored broken symlinks

On Sun, Nov 25 2012, Austin Clements wrote: > calmar on IRC reported a bug today where notmuch will abort when it > encounters a broken symlink, even if that symlink is in the > user-specified ignore list. These two patches test for this bug and > fix it. +1 Tomi

[PATCH v2 20/20] man: reference notmuch-insert.1

Add references to notmuch-insert.1 from other man pages. --- man/man1/notmuch-config.1 | 4 ++-- man/man1/notmuch-count.1| 4 ++-- man/man1/notmuch-dump.1 | 4 ++-- man/man1/notmuch-new.1 | 4 ++-- man/man1/notmuch-reply.1| 3 ++- man/man1/notmuch-restore.1

[PATCH v2 19/20] man: document 'insert' command

Add initial documentation for notmuch insert command. --- man/Makefile.local| 1 + man/man1/notmuch-insert.1 | 60 +++ 2 files changed, 61 insertions(+) create mode 100644 man/man1/notmuch-insert.1 diff --git a/man/Makefile.local

[PATCH v2 18/20] test: add tests for insert

Add tests for new 'insert' command. --- test/insert | 93 +++ test/notmuch-test | 1 + 2 files changed, 94 insertions(+) create mode 100755 test/insert diff --git a/test/insert b/test/insert new file mode 100755 index 000..d821a41

[PATCH v2 17/20] insert: add copyright line from notmuch-deliver

The 'insert' implementation was based partly on notmuch-deliver. --- notmuch-insert.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/notmuch-insert.c b/notmuch-insert.c index 28653ee..5c65582 100644 --- a/notmuch-insert.c +++ b/notmuch-insert.c @@ -2,6 +2,9 @@ * * Copyright ? 2012

[PATCH v2 16/20] insert: trap SIGINT and clean up

The only potentially long-running part of the 'insert' command should be copying stdin to the 'tmp' file. If SIGINT is received during the copying process, abort and clean up the file in 'tmp'. At all other points, just ignore the signal and continue. --- notmuch-insert.c | 27

[PATCH v2 15/20] insert: fsync new directory after rename

After moving the file from the 'tmp' to the 'new' directory, fsync on the 'new' directory for durability. --- notmuch-insert.c | 39 --- 1 file changed, 32 insertions(+), 7 deletions(-) diff --git a/notmuch-insert.c b/notmuch-insert.c index f09c579..831b322

[PATCH v2 14/20] insert: fsync after writing tmp file

Flush the tmp file to disk after writing for durability. --- notmuch-insert.c | 4 1 file changed, 4 insertions(+) diff --git a/notmuch-insert.c b/notmuch-insert.c index b7aef95..f09c579 100644 --- a/notmuch-insert.c +++ b/notmuch-insert.c @@ -329,6 +329,10 @@ insert_message (void *ctx,

[PATCH v2 13/20] insert: add --create-folder option

Support an option to create a new folder in the maildir. --- notmuch-insert.c | 92 1 file changed, 92 insertions(+) diff --git a/notmuch-insert.c b/notmuch-insert.c index 81a528c..b7aef95 100644 --- a/notmuch-insert.c +++

[PATCH v2 12/20] insert: apply command-line tag operations

Apply the +tag and -tag operations specified on the command-line. --- notmuch-insert.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/notmuch-insert.c b/notmuch-insert.c index e4631a2..81a528c 100644 --- a/notmuch-insert.c +++ b/notmuch-insert.c @@ -174,7

[PATCH v2 11/20] insert: parse command-line tag operations

Reuse the parser in notmuch-tag.c to parse +tag and -tag operations on the 'insert' command-line. --- notmuch-insert.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/notmuch-insert.c b/notmuch-insert.c index 362da66..e4631a2 100644 --- a/notmuch-insert.c +++

[PATCH v2 10/20] insert: apply default tags to new message

Apply the new.tags to messages added by 'insert'. This mirrors the behaviour if the message were delivered by a separate tool followed by 'notmuch new'. --- notmuch-insert.c | 25 - 1 file changed, 20 insertions(+), 5 deletions(-) diff --git a/notmuch-insert.c

[PATCH v2 09/20] insert: prevent writes outside Maildir hierarchy

Don't accept a --folder name that contains a ".." component, in order to prevent writing outside of the Maildir hierarchy. --- notmuch-insert.c | 21 + 1 file changed, 21 insertions(+) diff --git a/notmuch-insert.c b/notmuch-insert.c index a50eacc..022f7cd 100644 ---

[PATCH v2 08/20] insert: support --folder option

Allow the new message to be inserted into a folder within the Maildir hierarchy instead of the top-level folder. --- notmuch-insert.c | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/notmuch-insert.c b/notmuch-insert.c index 020dc29..a50eacc 100644 ---

[PATCH v2 07/20] insert: add new message to database

Add the new message to the notmuch database, renaming the file to encode notmuch tags as maildir flags. --- notmuch-insert.c | 49 - 1 file changed, 48 insertions(+), 1 deletion(-) diff --git a/notmuch-insert.c b/notmuch-insert.c index

[PATCH v2 06/20] insert: move file from Maildir tmp to new

Atomically move the new message file from the Maildir 'tmp' directory to 'new'. --- notmuch-insert.c | 21 + 1 file changed, 21 insertions(+) diff --git a/notmuch-insert.c b/notmuch-insert.c index 88e8533..63a04dc 100644 --- a/notmuch-insert.c +++ b/notmuch-insert.c @@ -94,6

[PATCH v2 05/20] insert: copy stdin to Maildir tmp file

Read the new message from standard input into the Maildir tmp file. --- notmuch-insert.c | 51 +++ 1 file changed, 47 insertions(+), 4 deletions(-) diff --git a/notmuch-insert.c b/notmuch-insert.c index 371fb47..88e8533 100644 ---

[PATCH v2 04/20] insert: open Maildir tmp file

Open a unique file in the Maildir tmp directory. The new message is not yet copied into the file. --- notmuch-insert.c | 105 ++- 1 file changed, 104 insertions(+), 1 deletion(-) diff --git a/notmuch-insert.c b/notmuch-insert.c index

[PATCH v2 03/20] cli: add stub for insert command

The notmuch insert command should read a message from standard input and deliver it to a Maildir folder, and then incorporate the message into the notmuch database. Essentially it moves the functionality of notmuch-deliver into notmuch. Though it could be used as an alternative to notmuch new,

[PATCH v2 02/20] tag: make tag operation parser public

Make the tag operation parser accessible outside notmuch-tag.c so it can be reused by the upcoming insert command. --- notmuch-client.h | 9 + notmuch-tag.c| 17 ++--- 2 files changed, 15 insertions(+), 11 deletions(-) diff --git a/notmuch-client.h b/notmuch-client.h

[PATCH v2 01/20] tag: factor out tag operation parsing

Factor out parsing of +tag, -tag operations from argv into a separate function. --- notmuch-tag.c | 66 +-- 1 file changed, 41 insertions(+), 25 deletions(-) diff --git a/notmuch-tag.c b/notmuch-tag.c index 88d559b..35a76db 100644 ---

[PATCH v2 00/20] insert command

This series mainly addresses the issues raised by Mark: - check talloc failures - deadlock in maildir_open_tmp - stricter file modes (0600 and 0700) - shared tag operation parser with notmuch-tag.c - simplified mkdir_parents - trap SIGINT - fsync after writing and rename - added a couple of tests

[PATCH 0/2] Ignore ignored broken symlinks

On Sun, 25 Nov 2012, Tomi Ollila wrote: > On Sun, Nov 25 2012, Austin Clements wrote: > >> calmar on IRC reported a bug today where notmuch will abort when it >> encounters a broken symlink, even if that symlink is in the >> user-specified ignore list. These two patches test for this bug and >>

[PATCH 1/3] test: Test notmuch new for single-message mbox

This series looks fine to me. +1 Mark On Sun, 25 Nov 2012, Austin Clements wrote: > We support this for historical reasons. > --- > test/new | 13 + > 1 file changed, 13 insertions(+) > > diff --git a/test/new b/test/new > index 587aa11..43d56e4 100755 > --- a/test/new > +++

[PATCH v3 1/2] notmuch-show.el: import calendar data with public function after CR removal

Tomi Ollila writes: > notmuch-get-bodypart-content provides raw data to its caller so > that it can be stored verbatim whenever needed. icalendar functions > expect Emacs to do EOL conversion for the data given to these. Therefore > it the CRLF -> LF conversion is now done explicitly. pushed

[Patch v4 1/2] test: factor out part of test-lib.sh into test-lib-common.sh

From: David Bremner The idea is to use some of the simpler parts of the test suite infrastructure to help run performance tests. --- test/test-lib-common.sh | 147 +++ test/test-lib.sh| 129

v4 of Performance tests

This version adds an optional makefile target to download the corpus. Tomi reviewed it on IRC and didn't complain.

[Patch v2 09/17] tag-util.[ch]: New files for common tagging routines

On Sat, Nov 24 2012, david at tethera.net wrote: > From: David Bremner > > These are meant to be shared between notmuch-tag and notmuch-restore. > > The bulk of the routines implement a "tag operation list" abstract > data type act as a structured representation of a set of tag > operations

[Patch v2 14/17] test: update dump-restore roundtripping test for batch-tag format

On Sat, Nov 24 2012, david at tethera.net wrote: > From: David Bremner > > Now we can actually round trip these crazy tags and and message ids. > hex-xcode is no longer needed as it's built in. > --- > test/dump-restore | 13 +++-- > 1 file changed, 7 insertions(+), 6 deletions(-) > >

[PATCH 3/3] lib: Reject multi-message mboxes and deprecate single-message mbox

Previously, we would treat multi-message mboxes as one giant email, which, besides the obvious incorrect indexing, often led to out-of-memory errors for archival mboxes. Now we explicitly reject multi-message mboxes. For historical reasons, we retain support for single-message mboxes, but

[PATCH 2/3] test: Test for ignoring multi-message mbox

This test is currently broken. Note that its brokenness cascades and causes the next test to fail as well (because notmuch incorrectly indexes the mbox file). --- test/new | 18 ++ 1 file changed, 18 insertions(+) diff --git a/test/new b/test/new index 43d56e4..29f9aff 100755

[PATCH 1/3] test: Test notmuch new for single-message mbox

We support this for historical reasons. --- test/new | 13 + 1 file changed, 13 insertions(+) diff --git a/test/new b/test/new index 587aa11..43d56e4 100755 --- a/test/new +++ b/test/new @@ -163,6 +163,19 @@ rm -rf "${MAIL_DIR}"/two output=$(NOTMUCH_NEW) test_expect_equal

[PATCH v2 1/7] cli: allow query to come from stdin

On Sat, Nov 24 2012, markwalters1009 wrote: > From: Mark Walters > > After this series there will be times when a caller will want to pass > a very large query string to notmuch (eg a list of 10,000 message-ids) > and this can exceed the size of ARG_MAX. Hence allow notmuch to take > the query

[PATCH v2 6/7] cli: allow search mode to include msg-ids with JSON output

On Sat, Nov 24 2012, markwalters1009 wrote: > From: Mark Walters > > This adds a --queries=true option which modifies the summary output of > notmuch search by including two extra query strings with each result: > one query string specifies all matching messages and one query string > all

[PATCH 2/2] new: Skip ignored broken symlinks

We now test for user ignore patterns before attempting to determine if a directory entry is itself a directory. As a result, we no longer abort for broken symlinks if the user has explicitly ignored them. This fixes the test added in the previous patch. It also slightly changes the debug output

[PATCH 1/2] test: Add a test for skipping ignored broken symlinks

Currently marked as broken because we abort on broken symlinks, even if they are in the ignore list. --- test/new |7 +++ 1 file changed, 7 insertions(+) diff --git a/test/new b/test/new index 587aa11..59892a7 100755 --- a/test/new +++ b/test/new @@ -203,4 +203,11 @@ test_expect_equal

[PATCH 0/2] Ignore ignored broken symlinks

calmar on IRC reported a bug today where notmuch will abort when it encounters a broken symlink, even if that symlink is in the user-specified ignore list. These two patches test for this bug and fix it.

Re: [PATCH 0/2] Ignore ignored broken symlinks

On Sun, Nov 25 2012, Austin Clements amdra...@mit.edu wrote: calmar on IRC reported a bug today where notmuch will abort when it encounters a broken symlink, even if that symlink is in the user-specified ignore list. These two patches test for this bug and fix it. +1 Tomi

BUG: notmuch stop on death symlink even..

hi all, notmuch stops/exits on death symlink even when they are on the ignore-list at the same time. on: notmuch new ... arount 360maybe in notmuch-new.c cheers marco -- (o_ It rocks: LINUX + Command-Line-Interface //\ GPG: 0x59D90F4D V_/_

Re: [PATCH 1/3] test: Test notmuch new for single-message mbox

This series looks fine to me. +1 Mark On Sun, 25 Nov 2012, Austin Clements amdra...@mit.edu wrote: We support this for historical reasons. --- test/new | 13 + 1 file changed, 13 insertions(+) diff --git a/test/new b/test/new index 587aa11..43d56e4 100755 --- a/test/new

Re: [PATCH 0/2] Ignore ignored broken symlinks

On Sun, 25 Nov 2012, Tomi Ollila tomi.oll...@iki.fi wrote: On Sun, Nov 25 2012, Austin Clements amdra...@mit.edu wrote: calmar on IRC reported a bug today where notmuch will abort when it encounters a broken symlink, even if that symlink is in the user-specified ignore list. These two

Many color per line in notuch emacs mode

Hi, I can set color per line using notmuch-search-line-faces. But I would like to specify color per line field, i.e a color for date, another for authors for exemple. To do this, I would like to use a 3-tuple list for notmuch-search-line-faces: :type '(alist :key-type (string) :field (string)

Re: [PATCH 3/3] lib: Reject multi-message mboxes and deprecate single-message mbox

On Sun, Nov 25 2012, Austin Clements amdra...@mit.edu wrote: Previously, we would treat multi-message mboxes as one giant email, which, besides the obvious incorrect indexing, often led to out-of-memory errors for archival mboxes. Now we explicitly reject multi-message mboxes. For

Re: [PATCH 0/6] API for iterating over all messages in a thread

Hi This series looks good to me (I have not reviewed the two bindings patches). Patch 2 looks like it makes things much easier to follow than the current code (if I understood the current pointer stuff it constructs the top-level list by doing pointer stuff to remove all messages which are

v4 of Performance tests

This version adds an optional makefile target to download the corpus. Tomi reviewed it on IRC and didn't complain. ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

[Patch v4 1/2] test: factor out part of test-lib.sh into test-lib-common.sh

From: David Bremner brem...@debian.org The idea is to use some of the simpler parts of the test suite infrastructure to help run performance tests. --- test/test-lib-common.sh | 147 +++ test/test-lib.sh| 129

[Patch v4 2/2] test: initial performance testing infrastructure

From: David Bremner brem...@debian.org This is not near as fancy as as the unit tests, on the theory that the code should typically be crashing when performance tuning. Nonetheless, there is plenty of room for improvement. Several more of the pieces of the test infrastructure (e.g. the option

Re: [PATCH v3 1/2] notmuch-show.el: import calendar data with public function after CR removal

Tomi Ollila tomi.oll...@iki.fi writes: notmuch-get-bodypart-content provides raw data to its caller so that it can be stored verbatim whenever needed. icalendar functions expect Emacs to do EOL conversion for the data given to these. Therefore it the CRLF - LF conversion is now done

Re: [PATCH v2 00/20] insert command

This is series is looking good. I have a few minor issues but no more. There are two parts I don't really know enough about to be certain about: the fsyncing and the sigtrap bit. For fsync: I have some recollection that you have to fsync all subpaths to the root to guarantee that it makes it

Re: [PATCH v2 01/20] tag: factor out tag operation parsing

On Sun, 25 Nov 2012, Peter Wang noval...@gmail.com wrote: Factor out parsing of +tag, -tag operations from argv into a separate function. --- notmuch-tag.c | 66 +-- 1 file changed, 41 insertions(+), 25 deletions(-) diff --git

Re: [PATCH v2 15/20] insert: fsync new directory after rename

On Sun, 25 Nov 2012, Peter Wang noval...@gmail.com wrote: After moving the file from the 'tmp' to the 'new' directory, fsync on the 'new' directory for durability. --- notmuch-insert.c | 39 --- 1 file changed, 32 insertions(+), 7 deletions(-) diff --git

Re: [PATCH v2 18/20] test: add tests for insert

On Sun, 25 Nov 2012, Peter Wang noval...@gmail.com wrote: Add tests for new 'insert' command. --- test/insert | 93 +++ test/notmuch-test | 1 + 2 files changed, 94 insertions(+) create mode 100755 test/insert diff --git

Re: [PATCH 3/3] lib: Reject multi-message mboxes and deprecate single-message mbox

Quoth Tomi Ollila on Nov 25 at 3:26 pm: On Sun, Nov 25 2012, Austin Clements amdra...@mit.edu wrote: Previously, we would treat multi-message mboxes as one giant email, which, besides the obvious incorrect indexing, often led to out-of-memory errors for archival mboxes. Now we

Re: [PATCH v2 00/20] insert command

Peter Wang noval...@gmail.com writes: - shared tag operation parser with notmuch-tag. Sharing tag operations with notmuch-tag is definitely a good idea, but it will also conflict with the changes of the series at id:1353792017-31459-1-git-send-email-da...@tethera.net Although I might be

Re: [PATCH 3/3] lib: Reject multi-message mboxes and deprecate single-message mbox

On Sun, Nov 25 2012, Austin Clements amdra...@mit.edu wrote: Quoth Tomi Ollila on Nov 25 at 3:26 pm: On Sun, Nov 25 2012, Austin Clements amdra...@mit.edu wrote: Previously, we would treat multi-message mboxes as one giant email, which, besides the obvious incorrect indexing, often led

Re: [PATCH 0/6] API for iterating over all messages in a thread

Quoth Mark Walters on Nov 25 at 2:31 pm: Hi This series looks good to me (I have not reviewed the two bindings patches). Patch 2 looks like it makes things much easier to follow than the current code (if I understood the current pointer stuff it constructs the top-level list by doing

Re: [Patch v4 2/2] test: initial performance testing infrastructure

Quoth da...@tethera.net on Nov 25 at 11:02 am: From: David Bremner brem...@debian.org This is not near as fancy as as the unit tests, on the theory that the code should typically be crashing when performance tuning. Nonetheless, there is plenty of room for improvement. Several more of the

Re: [Patch v2 09/17] tag-util.[ch]: New files for common tagging routines

This looks good. A couple of typos and a small queries (and I agree with Tomi but I think you have already included that). On Sat, 24 Nov 2012, da...@tethera.net wrote: From: David Bremner brem...@debian.org These are meant to be shared between notmuch-tag and notmuch-restore. The bulk of

Re: [Patch v2 12/17] man: document notmuch tag --batch, --input options

On Sat, 24 Nov 2012, da...@tethera.net wrote: From: Jani Nikula j...@nikula.org --- man/man1/notmuch-tag.1 | 52 +++- 1 file changed, 51 insertions(+), 1 deletion(-) diff --git a/man/man1/notmuch-tag.1 b/man/man1/notmuch-tag.1 index

Re: [Patch v2 11/17] test: add test for notmuch tag --batch option

Hi On Sat, 24 Nov 2012, da...@tethera.net wrote: From: Jani Nikula j...@nikula.org Basic test of functionality, along with all combinations of options. --- test/tagging | 46 ++ 1 file changed, 46 insertions(+) diff --git a/test/tagging

Re: Notmuch scripts (again), now with more usenet

Ethan Glasser-Camp ethan.glasser.c...@gmail.com writes: If Bremner is willing to put this package in contrib, I think he should do so. I guess that's fine, but I'd be more likely to get around to it if presented with a patch against git master d

Re: [Patch v4 2/2] test: initial performance testing infrastructure

Quoth David Bremner on Nov 25 at 8:05 pm: Austin Clements amdra...@mit.edu writes: +add_email_corpus takes arguments --small and --medium for when you +want smaller corpuses to check. corpora? reworded to say , | add_email_corpus takes arguments --small and --medium for when