Michael Forney writes:
> On Thu, 18 Oct 2012 00:52:20 +0300, Adrien Bustany
> wrote:
>> The code of the patches in unchanged, but the formatting issues are now
>> hopefully fixed.
>
> I would like to bump this patch set. I also need these features from
> libnotmuch. Currently there is no way to
On Tue, 25 Dec 2012, Tomi Ollila wrote:
> On Sat, Dec 22 2012, Mark Walters wrote:
>
>> view-mode-enter changed between emacs 23 and emacs 24: the current
>> code makes the error buffer disappear in emacs 24 on quitting it (ie
>> pressing q) but this just kills the buffer without closing the spl
Michael Forney writes:
> On Thu, 18 Oct 2012 00:52:20 +0300, Adrien Bustany wrote:
>> The code of the patches in unchanged, but the formatting issues are now
>> hopefully fixed.
>
> I would like to bump this patch set. I also need these features from
> libnotmuch. Currently there is no way to re
From: David Bremner
As with the valgrind logs, we print a (very) brief summary and leave
the log for inspection.
---
performance-test/perf-test-lib.sh |5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/performance-test/perf-test-lib.sh
b/performance-test/perf-test-lib.sh
From: David Bremner
This gives line numbers for better debugging.
---
notmuch-restore.c |9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/notmuch-restore.c b/notmuch-restore.c
index c93f1ac..6111977 100644
--- a/notmuch-restore.c
+++ b/notmuch-restore.c
@@ -88,10 +8
From: David Bremner
These are intended to be simple wrappers to provide slightly better
debugging information than what talloc currently provides natively.
---
notmuch-client.h|2 +-
util/Makefile.local |2 +-
util/talloc-extra.c | 14 ++
util/talloc-extra.h | 18
From: David Bremner
The argument handling in notmuch.c seems due for an overhaul, but
until then use an environment variable to specify a location to write
the talloc leak report to. This is only enabled for the (interesting)
case where some notmuch subcommand is invoked.
---
notmuch.c | 24 +
Obsoletes
id:1355714648-23144-1-git-send-email-david at tethera.netZ
[Patch v2 1/4] CLI: add talloc leak report, controlled by an
- comments and formatting
[Patch v2 2/4] util: add talloc-extra.[ch]
- rename, fix dangerous memcpy
[Patch v2 3/4] notmuch-restore: use debug version of
From: David Bremner
This patch corrects several undesirable behaviours:
1) Empty files were not detected, leading to buffer read overrun.
2) An initial blank line cause restore to silently abort
3) Initial comment line caused format detection to fail
---
notmuch-restore.c | 17 -
From: David Bremner
Three of these are marked broken; the third is a regression test,
since it passes by virtue of batch-tag being the default input format.
---
test/dump-restore | 42 ++
1 file changed, 42 insertions(+)
diff --git a/test/dump-restore b
On Tue, 25 Dec 2012, Tomi Ollila wrote:
> On Sat, Dec 22 2012, Mark Walters wrote:
>
>> view-mode-enter changed between emacs 23 and emacs 24: the current
>> code makes the error buffer disappear in emacs 24 on quitting it (ie
>> pressing q) but this just kills the buffer without closing the spl
From: David Bremner
The argument handling in notmuch.c seems due for an overhaul, but
until then use an environment variable to specify a location to write
the talloc leak report to. This is only enabled for the (interesting)
case where some notmuch subcommand is invoked.
---
notmuch.c | 24 +
From: David Bremner
As with the valgrind logs, we print a (very) brief summary and leave
the log for inspection.
---
performance-test/perf-test-lib.sh |5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/performance-test/perf-test-lib.sh
b/performance-test/perf-test-lib.sh
From: David Bremner
This gives line numbers for better debugging.
---
notmuch-restore.c |9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/notmuch-restore.c b/notmuch-restore.c
index c93f1ac..6111977 100644
--- a/notmuch-restore.c
+++ b/notmuch-restore.c
@@ -88,10 +8
From: David Bremner
These are intended to be simple wrappers to provide slightly better
debugging information than what talloc currently provides natively.
---
notmuch-client.h|2 +-
util/Makefile.local |2 +-
util/talloc-extra.c | 14 ++
util/talloc-extra.h | 18
Obsoletes
id:1355714648-23144-1-git-send-email-da...@tethera.netz
[Patch v2 1/4] CLI: add talloc leak report, controlled by an
- comments and formatting
[Patch v2 2/4] util: add talloc-extra.[ch]
- rename, fix dangerous memcpy
[Patch v2 3/4] notmuch-restore: use debug version of tal
From: David Bremner
In anticipation of doing some updates to this code, it simplifies life
if the code is "uncrustify clean" to start with
---
notmuch.c | 23 +++
1 file changed, 11 insertions(+), 12 deletions(-)
diff --git a/notmuch.c b/notmuch.c
index 9516dfb..ee2892e 10
From: David Bremner
This patch corrects several undesirable behaviours:
1) Empty files were not detected, leading to buffer read overrun.
2) An initial blank line cause restore to silently abort
3) Initial comment line caused format detection to fail
---
notmuch-restore.c | 17 -
From: David Bremner
Three of these are marked broken; the third is a regression test,
since it passes by virtue of batch-tag being the default input format.
---
test/dump-restore | 42 ++
1 file changed, 42 insertions(+)
diff --git a/test/dump-restore b
Mark Walters writes:
>> I can imagine that people would want/like the "open in other window"
>> effect of the current code, even if the reason is a bug.
>
> That's definitely possible. I generally expect a mouse click to select
> the window I click and this feels counter intuitive. I think that
Austin Clements writes:
> This obsoletes
>
> id:1356415076-5692-1-git-send-email-amdragon at mit.edu
>
> In addition to incorporating all of David's suggestions, this reworks
> the boolean term parsing so it only handles the subset of quoting
> syntax used by make_boolean_term (which also happe
Austin Clements writes:
> + char *out = talloc_strdup (ctx, pos + 1);
> + int closed = 0;
> + /* Find the closing quote and un-double doubled internal
> + * quotes. */
> + for (pos = *term_out = out; *pos; ) {
Since you strdup anyway, wouldn't it be easier to understand if p
Austin Clements writes:
> +/* Construct a boolean term query with the specified prefix (e.g.,
> + * "id") and search term, quoting term as necessary.
> + *
> + * Output is into buf; it may be talloc_realloced.
> + * Return: 0 on success, non-zero on memory allocation failure.
> + */
> +int make_b
david at tethera.net writes:
> From: David Bremner
>
> This is essentially cosmetic, since success=0 is promised by
> the comments in tag-utils.h.
Pushed this one patch.
Both of the two I pushed from this series are really nothing to do with
batch tagging, and were just cluttering things up.
d
david at tethera.net writes:
> From: David Bremner
>
> Consistently use [...]; one less space. Use singular
> ---
pushed this one patch.
d
Mark Walters writes:
> I am unclear about how this is going to deal with queries containing
> newlines. For dump/restore I think this is not a problem (as Austin and
> others have said), but for batch tagging I think it could be; for
> example the query could be for a tag containing a newline.
Y
On Tue, 25 Dec 2012, david at tethera.net wrote:
> This is an alternative version of
>
> id:1356313183-9266-1-git-send-email-david at tethera.net
>
> batch tagging patches rebased on top of
>
> id:1356415076-5692-1-git-send-email-amdragon at mit.edu
>
> This mainly consisted of removin
From: David Bremner
In anticipation of doing some updates to this code, it simplifies life
if the code is "uncrustify clean" to start with
---
notmuch.c | 23 +++
1 file changed, 11 insertions(+), 12 deletions(-)
diff --git a/notmuch.c b/notmuch.c
index 9516dfb..ee2892e 10
Mark Walters writes:
>> I can imagine that people would want/like the "open in other window"
>> effect of the current code, even if the reason is a bug.
>
> That's definitely possible. I generally expect a mouse click to select
> the window I click and this feels counter intuitive. I think that
Austin Clements writes:
> This obsoletes
>
> id:1356415076-5692-1-git-send-email-amdra...@mit.edu
>
> In addition to incorporating all of David's suggestions, this reworks
> the boolean term parsing so it only handles the subset of quoting
> syntax used by make_boolean_term (which also happens
Austin Clements writes:
> + char *out = talloc_strdup (ctx, pos + 1);
> + int closed = 0;
> + /* Find the closing quote and un-double doubled internal
> + * quotes. */
> + for (pos = *term_out = out; *pos; ) {
Since you strdup anyway, wouldn't it be easier to understand if p
Austin Clements writes:
> +/* Construct a boolean term query with the specified prefix (e.g.,
> + * "id") and search term, quoting term as necessary.
> + *
> + * Output is into buf; it may be talloc_realloced.
> + * Return: 0 on success, non-zero on memory allocation failure.
> + */
> +int make_b
da...@tethera.net writes:
> From: David Bremner
>
> This is essentially cosmetic, since success=0 is promised by
> the comments in tag-utils.h.
Pushed this one patch.
Both of the two I pushed from this series are really nothing to do with
batch tagging, and were just cluttering things up.
d
__
da...@tethera.net writes:
> From: David Bremner
>
> Consistently use [...]; one less space. Use singular
> ---
pushed this one patch.
d
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch
Mark Walters writes:
> I am unclear about how this is going to deal with queries containing
> newlines. For dump/restore I think this is not a problem (as Austin and
> others have said), but for batch tagging I think it could be; for
> example the query could be for a tag containing a newline.
Y
On Tue, 25 Dec 2012, da...@tethera.net wrote:
> This is an alternative version of
>
> id:1356313183-9266-1-git-send-email-da...@tethera.net
>
> batch tagging patches rebased on top of
>
> id:1356415076-5692-1-git-send-email-amdra...@mit.edu
>
> This mainly consisted of removing
>
>
36 matches
Mail list logo
