Reply all - issue

2013-01-28 Thread Robert Mast
Thanks for your reply. I never tried gmail-conversation threading, but from your first reference I understand it breaks threads on subject unconditionally. Breaking on subject unconditionally would be even easier to implement, as comparing the contents of previous messages takes performance and a

It's good to be "back"!

2013-01-28 Thread Carl Worth
Elsewhere, in a non-hijacked thread, Carl Worth wrote: > Is there any existing thread-breaking? There wasn't the last time I > looked at the code closely, (but admittedly, that was a while ago). Hi folks, I've been away from any active involvement in the notmuch community for far too long. It tu

RE: Reply all - issue

2013-01-28 Thread Carl Worth
Robert Mast writes: > Your point on patch-breaking related to gmail and my proposal isn't > completely clear to me, but I've probably addressed it well with my new > approach. The issue here is that many developers tend to develop a patch series (perhaps with dozens of patches) as a single concep

RE: Reply all - issue

2013-01-28 Thread Robert Mast
Thanks for your reply. I never tried gmail-conversation threading, but from your first reference I understand it breaks threads on subject unconditionally. Breaking on subject unconditionally would be even easier to implement, as comparing the contents of previous messages takes performance and a

[PATCH 5/5] Drop harmful reply buffer preparation

2013-01-28 Thread Kirill A. Shutemov
From: "Kirill A. Shutemov" Inserting empty lines at the end of reply buffer and switching to insert mode are not what user want on reply. It's only annoying if you try to comment on patch. If a user really wants this kind of preparation it should be implemented as an user-specific hook. Signed-

[PATCH 4/5] Introduce g:notmuch_rb_folders_count_threads

2013-01-28 Thread Kirill A. Shutemov
From: "Kirill A. Shutemov" If the option set, folders list shows count of threads, not messages Signed-off-by: Kirill A. Shutemov --- notmuch-ruby.vim | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/notmuch-ruby.vim b/notmuch-ruby.vim index 81da9b3..cda5df4 1006

[PATCH 3/5] /usr/sbin/sendmail as a default g:notmuch_rb_sendmail

2013-01-28 Thread Kirill A. Shutemov
From: "Kirill A. Shutemov" It's confusing that we don't have a default sendmail program. Let's use /usr/sbin/sendmail as reasonable default. Signed-off-by: Kirill A. Shutemov --- notmuch-ruby.vim |5 + 1 file changed, 5 insertions(+) diff --git a/notmuch-ruby.vim b/notmuch-ruby.vim in

[PATCH 2/5] rename g:notmuch_sendmail -> g:notmuch_rb_sendmail

2013-01-28 Thread Kirill A. Shutemov
From: "Kirill A. Shutemov" All configuration variable use prefix notmuch_rb_ except notmuch_sendmail. Let's fix it. Signed-off-by: Kirill A. Shutemov --- notmuch-ruby.vim |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/notmuch-ruby.vim b/notmuch-ruby.vim index d8a9878..6

[PATCH 1/5] open_reply: fallback to use addr.local if addr.name is nil

2013-01-28 Thread Kirill A. Shutemov
From: "Kirill A. Shutemov" If address doesn't contain name we end up with " wrote:" as a reply header. It doesn't look nice. Let's use addr.local + "@" if name is not defined. If addr.local is not defined too, let's just use "somebody". Signed-off-by: Kirill A. Shutemov --- notmuch-ruby.vim |

[PATCH 0/5] Random patches for notmuch-vim-ruby

2013-01-28 Thread Kirill A. Shutemov
From: "Kirill A. Shutemov" Kirill A. Shutemov (5): open_reply: fallback to use addr.local if addr.name is nil rename g:notmuch_sendmail -> g:notmuch_rb_sendmail /usr/sbin/sendmail as a default g:notmuch_rb_sendmail Introduce g:notmuch_rb_folders_count_threads Drop harmful reply buffer p

Reply all - issue

2013-01-28 Thread Jani Nikula
On Sun, 27 Jan 2013, Robert Mast wrote: > Last week I studied many Windows-Mail User Agents with the conversation > threading feature. > > None of them (SUP, mutt-kz(notmuch), Outlook 2010, Thunderbird with > conversation thread plug in, Postbox, Evolution) could cope with the > following case: A

[PATCH 0/5] Random patches for notmuch-vim-ruby

2013-01-28 Thread David Bremner
"Kirill A. Shutemov" writes: > From: "Kirill A. Shutemov" > > Kirill A. Shutemov (5): > open_reply: fallback to use addr.local if addr.name is nil > rename g:notmuch_sendmail -> g:notmuch_rb_sendmail > /usr/sbin/sendmail as a default g:notmuch_rb_sendmail > Introduce g:notmuch_rb_folders

Re: [PATCH 0/5] Random patches for notmuch-vim-ruby

2013-01-28 Thread David Bremner
"Kirill A. Shutemov" writes: > From: "Kirill A. Shutemov" > > Kirill A. Shutemov (5): > open_reply: fallback to use addr.local if addr.name is nil > rename g:notmuch_sendmail -> g:notmuch_rb_sendmail > /usr/sbin/sendmail as a default g:notmuch_rb_sendmail > Introduce g:notmuch_rb_folders

[PATCH 0/5] Random patches for notmuch-vim-ruby

2013-01-28 Thread Kirill A. Shutemov
From: "Kirill A. Shutemov" Kirill A. Shutemov (5): open_reply: fallback to use addr.local if addr.name is nil rename g:notmuch_sendmail -> g:notmuch_rb_sendmail /usr/sbin/sendmail as a default g:notmuch_rb_sendmail Introduce g:notmuch_rb_folders_count_threads Drop harmful reply buffer p

[PATCH 2/5] rename g:notmuch_sendmail -> g:notmuch_rb_sendmail

2013-01-28 Thread Kirill A. Shutemov
From: "Kirill A. Shutemov" All configuration variable use prefix notmuch_rb_ except notmuch_sendmail. Let's fix it. Signed-off-by: Kirill A. Shutemov --- notmuch-ruby.vim |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/notmuch-ruby.vim b/notmuch-ruby.vim index d8a9878..6

[PATCH 3/5] /usr/sbin/sendmail as a default g:notmuch_rb_sendmail

2013-01-28 Thread Kirill A. Shutemov
From: "Kirill A. Shutemov" It's confusing that we don't have a default sendmail program. Let's use /usr/sbin/sendmail as reasonable default. Signed-off-by: Kirill A. Shutemov --- notmuch-ruby.vim |5 + 1 file changed, 5 insertions(+) diff --git a/notmuch-ruby.vim b/notmuch-ruby.vim in

[PATCH 4/5] Introduce g:notmuch_rb_folders_count_threads

2013-01-28 Thread Kirill A. Shutemov
From: "Kirill A. Shutemov" If the option set, folders list shows count of threads, not messages Signed-off-by: Kirill A. Shutemov --- notmuch-ruby.vim | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/notmuch-ruby.vim b/notmuch-ruby.vim index 81da9b3..cda5df4 1006

[PATCH 1/5] open_reply: fallback to use addr.local if addr.name is nil

2013-01-28 Thread Kirill A. Shutemov
From: "Kirill A. Shutemov" If address doesn't contain name we end up with " wrote:" as a reply header. It doesn't look nice. Let's use addr.local + "@" if name is not defined. If addr.local is not defined too, let's just use "somebody". Signed-off-by: Kirill A. Shutemov --- notmuch-ruby.vim |

[PATCH 5/5] Drop harmful reply buffer preparation

2013-01-28 Thread Kirill A. Shutemov
From: "Kirill A. Shutemov" Inserting empty lines at the end of reply buffer and switching to insert mode are not what user want on reply. It's only annoying if you try to comment on patch. If a user really wants this kind of preparation it should be implemented as an user-specific hook. Signed-

Re: Reply all - issue

2013-01-28 Thread Jani Nikula
On Sun, 27 Jan 2013, Robert Mast wrote: > Last week I studied many Windows-Mail User Agents with the conversation > threading feature. > > None of them (SUP, mutt-kz(notmuch), Outlook 2010, Thunderbird with > conversation thread plug in, Postbox, Evolution) could cope with the > following case: A