Hi Alexey,
Thanks for working on this. I think the boolean prefix version makes
more sense, and it seems to work OK. I have a few comments below
"Alexey I. Froloff" writes:
> +begin_list_id = strrchr (list_id_header, '<');
> +if (!begin_list_id) {
> + fprintf (stderr, "Warning:
Vladimir Marek writes:
>> It's okay to use the result of .c_str() as long as the string object
>> stays in scope, and none of the non-const member functions are
>> called. Here, I think the problem is that TermIterator's overloaded
>> operator*() returns a string object within the if block's
Felipe Contreras writes:
>
> I don't take it personally, I just don't see why a part of the project
> has to be treated differently because you (the debian packager), don't
> want to setup a separate git repo where to have this 'live' packaging
> (or even a separate branch).
>
My hypothetical
On Sun, Apr 28, 2013 at 8:22 PM, David Bremner wrote:
> Felipe Contreras writes:
>>
>> I understand that you are not going to work on the Debian packages for
>> some time, but what prevents this patch from being merged to notmuch
>> 'master'? Is there any problems with the patch? Shall I just
Felipe Contreras felipe.contre...@gmail.com writes:
I don't take it personally, I just don't see why a part of the project
has to be treated differently because you (the debian packager), don't
want to setup a separate git repo where to have this 'live' packaging
(or even a separate branch).
On Mon, Apr 29, 2013 at 5:38 AM, David Bremner brem...@debian.org wrote:
Felipe Contreras felipe.contre...@gmail.com writes:
I don't take it personally, I just don't see why a part of the project
has to be treated differently because you (the debian packager), don't
want to setup a separate
Felipe Contreras felipe.contre...@gmail.com writes:
My hypothetical laziness is not the reason. It was at the strong
insistence of Carl that things are organized this way.
I still don't see why we need to do that. The notmuch project
shouldn't be bound to the debian project.
I'm not sure
Vladimir Marek vladimir.ma...@oracle.com writes:
It's okay to use the result of .c_str() as long as the string object
stays in scope, and none of the non-const member functions are
called. Here, I think the problem is that TermIterator's overloaded
operator*() returns a string object within
Hi Alexey,
Thanks for working on this. I think the boolean prefix version makes
more sense, and it seems to work OK. I have a few comments below
Alexey I. Froloff ra...@raorn.name writes:
+begin_list_id = strrchr (list_id_header, '');
+if (!begin_list_id) {
+ fprintf (stderr,