Notmuch Emacs UI aborts on SourceForge.net newsletter

2013-05-03 Thread David Bremner
Amadeusz ?o?nowski writes: > Attached message, when opened, causes Emacs crash: > > *** glibc detected *** emacs: free(): invalid next size (fast): > 0x0324f5e0 *** As promised, I duplicated this without notmuch, so I reported upstream as http://debbugs.gnu.org/cgi/bugreport.cgi?bug=14

[PATCH] lib: Add a new prefix "list" to the search-terms syntax

2013-05-03 Thread David Bremner
"Alexey I. Froloff" writes: > >> > +void *local = talloc_new (message); >> we should handle ENOMEM here, I think. > There are 16 talloc_new() calls and ENOMEM is not handled > anywhere. This makes me a bit sad but I agree it's not your fault ;). > >> > +/* _notmuch_message_add_term

[PATCH] go: use a different goconfig package

2013-05-03 Thread David Bremner
Justus Winter <4winter at informatik.uni-hamburg.de> writes: > The notmuch-addrlookup utility uses a third party library to read the > notmuch configuration file. The previously used implementation at > "github.com/kless/goconfig" vanished, so this patch switches to the > implementation at "github

[PATCH] lib/message.cc: stale pointer bug (v3)

2013-05-03 Thread David Bremner
Vladimir.Marek at oracle.com writes: > From: Vladimir Marek > > Xapian::TermIterator::operator* returns std::string which is destroyed > as soon as (*i).c_str() finishes. The remembered pointer 'term' then > references invalid memory. Pushed, d

Re: Notmuch Emacs UI aborts on SourceForge.net newsletter

2013-05-03 Thread David Bremner
Amadeusz Żołnowski writes: > Attached message, when opened, causes Emacs crash: > > *** glibc detected *** emacs: free(): invalid next size (fast): > 0x0324f5e0 *** As promised, I duplicated this without notmuch, so I reported upstream as http://debbugs.gnu.org/cgi/bugreport.cgi?bug=14

Re: [PATCH] lib: Add a new prefix "list" to the search-terms syntax

2013-05-03 Thread David Bremner
"Alexey I. Froloff" writes: > >> > +void *local = talloc_new (message); >> we should handle ENOMEM here, I think. > There are 16 talloc_new() calls and ENOMEM is not handled > anywhere. This makes me a bit sad but I agree it's not your fault ;). > >> > +/* _notmuch_message_add_term

[WIP] emacs: show: lazily insert html parts

2013-05-03 Thread Mark Walters
The current code renders all html parts by default and then hides them. This is quite slow so this is an attempt to make it only render them when the user chooses to show them. In my testing this code seems to work but has some rough edges. However, it may be useful to people in its current form

Re: [PATCH] lib/message.cc: stale pointer bug (v3)

2013-05-03 Thread David Bremner
vladimir.ma...@oracle.com writes: > From: Vladimir Marek > > Xapian::TermIterator::operator* returns std::string which is destroyed > as soon as (*i).c_str() finishes. The remembered pointer 'term' then > references invalid memory. Pushed, d ___ notmu

Re: [PATCH] go: use a different goconfig package

2013-05-03 Thread David Bremner
Justus Winter <4win...@informatik.uni-hamburg.de> writes: > The notmuch-addrlookup utility uses a third party library to read the > notmuch configuration file. The previously used implementation at > "github.com/kless/goconfig" vanished, so this patch switches to the > implementation at "github.co

[PATCH 2/2] emacs: hello: allow deleting individual searches in the history

2013-05-03 Thread Servilio Afre Puentes
This commit adds an extra button at the end of the search entries that allows deleting that individual search from the history. A short confirmation (?y? or ?n?) is made before taking action. --- emacs/notmuch-hello.el | 26 -- 1 file changed, 24 insertions(+), 2 deletions

[PATCH 1/2] emacs: hello: ask confirmation for clearing recent searches

2013-05-03 Thread Servilio Afre Puentes
The button to clear the recent searches in notmuch-hello is easy to press accidentally while moving around the, clearing potentially useful searches with no way of recovering them. --- emacs/notmuch-hello.el | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/emacs/notmuch-he

[PATCH 0/2] Enhancements to notmuch-hello search history

2013-05-03 Thread Servilio Afre Puentes
Hi, Two patches that enhance the notmuch-hello search history UI. Though minor I find them very helpful. Servilio Afre Puentes (2): emacs: hello: ask confirmation for clearing recent searches emacs: hello: allow deleting individual searches in the history emacs/notmuch-hello.el | 31 +++

[PATCH 2/2] emacs: hello: allow deleting individual searches in the history

2013-05-03 Thread Servilio Afre Puentes
This commit adds an extra button at the end of the search entries that allows deleting that individual search from the history. A short confirmation («y» or «n») is made before taking action. --- emacs/notmuch-hello.el | 26 -- 1 file changed, 24 insertions(+), 2 deletions

[PATCH 1/2] emacs: hello: ask confirmation for clearing recent searches

2013-05-03 Thread Servilio Afre Puentes
The button to clear the recent searches in notmuch-hello is easy to press accidentally while moving around the, clearing potentially useful searches with no way of recovering them. --- emacs/notmuch-hello.el | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/emacs/notmuch-he

[PATCH 0/2] Enhancements to notmuch-hello search history

2013-05-03 Thread Servilio Afre Puentes
Hi, Two patches that enhance the notmuch-hello search history UI. Though minor I find them very helpful. Servilio Afre Puentes (2): emacs: hello: ask confirmation for clearing recent searches emacs: hello: allow deleting individual searches in the history emacs/notmuch-hello.el | 31 +++