[PATCH 1/2] test: add basic test for notmuch setup

2013-05-05 Thread Tomi Ollila
On Sun, May 05 2013, Jani Nikula wrote: > And annotate with test_subtest_known_broken. Hooray. > --- LGTM (both patches). Tests pass (both make test and hand-tested setup without having file ~/.notmuch-config). Tomi > test/notmuch-test |1 + > test/setup| 28

[CLI] bug in notmuch setup

2013-05-05 Thread Patrick Totzke
Best, /p -- next part -- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 198 bytes Desc: signature URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20130505/6e1cc452/attachment.pgp>

[PATCH 2/2] cli: config: fix config file save when the file does not exist

2013-05-05 Thread Jani Nikula
The use of realpath(3) in commit 58ed67992d0ec1fa505026105218fa449f7980b0 Author: Jani Nikula Date: Sun Apr 7 20:15:03 2013 +0300 cli: config: do not overwrite symlinks when saving config file broke config file save when the file does not exist, which results in 'notmuch setup' always fail

[PATCH 1/2] test: add basic test for notmuch setup

2013-05-05 Thread Jani Nikula
And annotate with test_subtest_known_broken. Hooray. --- test/notmuch-test |1 + test/setup| 28 2 files changed, 29 insertions(+) create mode 100755 test/setup diff --git a/test/notmuch-test b/test/notmuch-test index ca9c3dc..27a144e 100755 --- a/test/

Re: [CLI] bug in notmuch setup

2013-05-05 Thread Jani Nikula
On Mon, 06 May 2013, Patrick Totzke wrote: > As mentioned on IRC earlier, current master seems to have an issue > with `notmuch setup`, which fails to write ~/.notmuch-config if not > already present. Hi Patrick, thanks for the report. This is fixed by id:9971e27c7c3fe569765bbca0f21de128ad1e4fac.

[PATCH 0/2] Enhancements to notmuch-hello search history

2013-05-05 Thread Jani Nikula
On Sun, 05 May 2013, Tomi Ollila wrote: > I agree with Jani that y-or-n-p would suffice for clearing all > recent searches (but yes-or-no-p is not so bad as I originally thought > as C-g can be used to stop processing (typoing 'no' is too easy ;/). > > If we could use "undo" feature to restore la

[CLI] bug in notmuch setup

2013-05-05 Thread Patrick Totzke
Hi all, As mentioned on IRC earlier, current master seems to have an issue with `notmuch setup`, which fails to write ~/.notmuch-config if not already present. Here are excerpts from the discussion from #notmuch: --%<--- 19:

[PATCH 5/6] python: Add bindings for notmuch_thread_get_messages

2013-05-05 Thread David Bremner
Austin Clements writes: > --- > bindings/python/notmuch/thread.py | 27 ++- > 1 file changed, 22 insertions(+), 5 deletions(-) Pushed, finally. d

[PATCH] emacs: add kernel.org mail archive redirector

2013-05-05 Thread David Bremner
Jani Nikula writes: > See http://lkml.kernel.org/ > --- > emacs/notmuch-show.el |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) Pushed. d

[PATCH REBASE] emacs: add show view bindings to move to previous/next thread

2013-05-05 Thread Tomi Ollila
On Sun, May 05 2013, Mark Walters wrote: > Hi > > This seems like a useful addition to me. I have a couple of comments and > a little bikeshedding below. > > On Thu, 02 May 2013, Jani Nikula wrote: >> We have most of the plumbing in place, add the bindings M-n and M-p. >> --- >> emacs/notmuch-s

[PATCH 0/2] Enhancements to notmuch-hello search history

2013-05-05 Thread Tomi Ollila
On Sat, May 04 2013, Servilio Afre Puentes wrote: > Jani Nikula writes: > >> On Fri, 03 May 2013, Servilio Afre Puentes wrote: >>> Two patches that enhance the notmuch-hello search history UI. Though >>> minor I find them very helpful. >> >> Both seem to work as advertised; I did not look at th

Re: [PATCH 1/2] test: add basic test for notmuch setup

2013-05-05 Thread Tomi Ollila
On Sun, May 05 2013, Jani Nikula wrote: > And annotate with test_subtest_known_broken. Hooray. > --- LGTM (both patches). Tests pass (both make test and hand-tested setup without having file ~/.notmuch-config). Tomi > test/notmuch-test |1 + > test/setup| 28

[PATCH 2/2] cli: config: fix config file save when the file does not exist

2013-05-05 Thread Jani Nikula
The use of realpath(3) in commit 58ed67992d0ec1fa505026105218fa449f7980b0 Author: Jani Nikula Date: Sun Apr 7 20:15:03 2013 +0300 cli: config: do not overwrite symlinks when saving config file broke config file save when the file does not exist, which results in 'notmuch setup' always fail

[PATCH 1/2] test: add basic test for notmuch setup

2013-05-05 Thread Jani Nikula
And annotate with test_subtest_known_broken. Hooray. --- test/notmuch-test |1 + test/setup| 28 2 files changed, 29 insertions(+) create mode 100755 test/setup diff --git a/test/notmuch-test b/test/notmuch-test index ca9c3dc..27a144e 100755 --- a/test/

Re: [PATCH 5/6] python: Add bindings for notmuch_thread_get_messages

2013-05-05 Thread David Bremner
Austin Clements writes: > --- > bindings/python/notmuch/thread.py | 27 ++- > 1 file changed, 22 insertions(+), 5 deletions(-) Pushed, finally. d ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailma

Re: [PATCH] emacs: add kernel.org mail archive redirector

2013-05-05 Thread David Bremner
Jani Nikula writes: > See http://lkml.kernel.org/ > --- > emacs/notmuch-show.el |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) Pushed. d ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 0/2] Enhancements to notmuch-hello search history

2013-05-05 Thread Jani Nikula
On Sun, 05 May 2013, Tomi Ollila wrote: > I agree with Jani that y-or-n-p would suffice for clearing all > recent searches (but yes-or-no-p is not so bad as I originally thought > as C-g can be used to stop processing (typoing 'no' is too easy ;/). > > If we could use "undo" feature to restore la

Re: [PATCH REBASE] emacs: add show view bindings to move to previous/next thread

2013-05-05 Thread Tomi Ollila
On Sun, May 05 2013, Mark Walters wrote: > Hi > > This seems like a useful addition to me. I have a couple of comments and > a little bikeshedding below. > > On Thu, 02 May 2013, Jani Nikula wrote: >> We have most of the plumbing in place, add the bindings M-n and M-p. >> --- >> emacs/notmuch-s

Re: [PATCH 0/2] Enhancements to notmuch-hello search history

2013-05-05 Thread Tomi Ollila
On Sat, May 04 2013, Servilio Afre Puentes wrote: > Jani Nikula writes: > >> On Fri, 03 May 2013, Servilio Afre Puentes wrote: >>> Two patches that enhance the notmuch-hello search history UI. Though >>> minor I find them very helpful. >> >> Both seem to work as advertised; I did not look at th

[PATCH 2/2] emacs: hello: allow deleting individual searches in the history

2013-05-05 Thread Mark Walters
These patches both look good to me (and the lisp all looks fine) modulo a trivial style comment and a little bikeshedding. For the bikeshedding I would prefer that the first patch was a y-or-n-p (as Jani suggested) and that the second didn't query at all (the dataloss potential from deleting a si

[PATCH REBASE] emacs: add show view bindings to move to previous/next thread

2013-05-05 Thread Mark Walters
Hi This seems like a useful addition to me. I have a couple of comments and a little bikeshedding below. On Thu, 02 May 2013, Jani Nikula wrote: > We have most of the plumbing in place, add the bindings M-n and M-p. > --- > emacs/notmuch-show.el | 24 > 1 file change