[PATCH] Fix shared library loading in Python bindings.

2013-05-25 Thread Julian Berman
Specifically, fixes loading on OS X, where libnotmuch will be a dylib.: --- bindings/python/notmuch/globals.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/bindings/python/notmuch/globals.py b/bindings/python/notmuch/globals.py index c7632c3..5e08e73 100644 --- a/bindings

[PATCH 2/2] contrib: pick: fix refresh result

2013-05-25 Thread Mark Walters
The function notmuch-pick-refresh-result (used to update tag changes) was not quite correct: sometimes it got the choice between the subject and " ..." wrong. This was always true but the new code often calls this (when opening a message in the message pane to remove the unread tag) while the async

[PATCH 1/2] contrib: pick: remove hack notmuch-pick-show-match-message-with-wait

2013-05-25 Thread Mark Walters
This function was a horrible hack (sleeping while waiting for the correct message). The new target code can just open the message in the message window when it arrives. --- contrib/notmuch-pick/notmuch-pick.el | 37 +++--- 1 files changed, 12 insertions(+), 25 deletio

[PATCH 0/2] Contrib: Pick: Remove horrible hack

2013-05-25 Thread Mark Walters
Pick used to have one horrible hack: if the user asked it to open the first matching message it had to check whether that had arrived (as the search is asynchronous) and if not wait and try again. Now the opening of the first matching message is called via the pick process filter this hack can be r

[PATCH] contrib: pick: if no target specified go to first matching message

2013-05-25 Thread Mark Walters
--- Now that all the plumbing (id:1357814477-1348-1-git-send-email-markwalters1...@gmail.com) is in place this is easy. Best wishes Mark contrib/notmuch-pick/notmuch-pick.el |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/contrib/notmuch-pick/notmuch-pick.el b/co

Re: [PATCH] emacs: Don't override mm-show-part in notmuch-show-view-part

2013-05-25 Thread Austin Clements
Quoth Mark Walters on May 21 at 8:13 pm: > > On Tue, 21 May 2013, Mark Walters wrote: > > Hi > > > >> Previously, notmuch-show-view-part overrode the function binding of > >> mm-show-part to redirect it to notmuch-show-save-part to get notmuch's > >> default file name handling in case mm-display

[PATCH v2] emacs: Don't override mm-show-part in notmuch-show-view-part

2013-05-25 Thread Austin Clements
Previously, notmuch-show-view-part overrode the function binding of mm-show-part to redirect it to notmuch-show-save-part to get notmuch's default file name handling in case mm-display-part decided to fall back to saving the part. In addition to being messy, this depended on the now-deprecated dyn

[PATCH 3/3] build: pass CPPFLAGS to C and C++ compilers

2013-05-25 Thread da...@tethera.net
From: David Bremner This is used in particular by hardening flags. --- Makefile.local |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Makefile.local b/Makefile.local index c274f07..644623f 100644 --- a/Makefile.local +++ b/Makefile.local @@ -39,8 +39,8 @@ GPG_FILE=

[PATCH 2/3] configure: grab CPPFLAGS from the environment.

2013-05-25 Thread da...@tethera.net
From: David Bremner This is needed in particular for hardening flags. --- configure |5 + 1 file changed, 5 insertions(+) diff --git a/configure b/configure index 460fcfc..3ba1ec3 100755 --- a/configure +++ b/configure @@ -43,6 +43,7 @@ fi CC=${CC:-gcc} CXX=${CXX:-g++} CFLAGS=${CFLAG

[PATCH 1/3] debian: compile with V=1

2013-05-25 Thread da...@tethera.net
From: David Bremner The idea is to allow hardening verification tools (in particular blhc) to scan the logs. Actually fixing the problem will require modifying the notmuch configure script to propagate CPPFLAGS. --- debian/rules |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --gi

handle CPPFLAGS in configure and make

2013-05-25 Thread da...@tethera.net
I wanted to enable hardening flags in the debian build (I guess other distros will want to do the same); I realized this is made more difficult by the fact that we don't handle CPPFLAGS in our build system. Well, if it makes us feel any better, CMake had (has?) the same bug.

[PATCH] emacs: add show view bindings to move to previous/next thread

2013-05-25 Thread Mark Walters
From: Jani Nikula We have most of the plumbing in place, add the bindings M-n and M-p. --- emacs/notmuch-show.el | 30 +- 1 files changed, 25 insertions(+), 5 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index d56154e..2b33007 100644 ---

[PATCH 1/2] emacs: add show view bindings to move to previous/next thread

2013-05-25 Thread Jani Nikula
On Sat, 25 May 2013, Mark Walters wrote: > Did you want this to not exit back to the search results if you do M-p > on the first result? I attach a version below that does exit back (so > M-p and M-n behave the same. Oh, that was just pure fail from my part. Sorry about that, Mark, and thanks so

[PATCH 2/3] configure: grab CPPFLAGS from the environment.

2013-05-25 Thread david
From: David Bremner This is needed in particular for hardening flags. --- configure |5 + 1 file changed, 5 insertions(+) diff --git a/configure b/configure index 460fcfc..3ba1ec3 100755 --- a/configure +++ b/configure @@ -43,6 +43,7 @@ fi CC=${CC:-gcc} CXX=${CXX:-g++} CFLAGS=${CFLAG

[PATCH 3/3] build: pass CPPFLAGS to C and C++ compilers

2013-05-25 Thread david
From: David Bremner This is used in particular by hardening flags. --- Makefile.local |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Makefile.local b/Makefile.local index c274f07..644623f 100644 --- a/Makefile.local +++ b/Makefile.local @@ -39,8 +39,8 @@ GPG_FILE=

[PATCH 1/3] debian: compile with V=1

2013-05-25 Thread david
From: David Bremner The idea is to allow hardening verification tools (in particular blhc) to scan the logs. Actually fixing the problem will require modifying the notmuch configure script to propagate CPPFLAGS. --- debian/rules |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --gi

handle CPPFLAGS in configure and make

2013-05-25 Thread david
I wanted to enable hardening flags in the debian build (I guess other distros will want to do the same); I realized this is made more difficult by the fact that we don't handle CPPFLAGS in our build system. Well, if it makes us feel any better, CMake had (has?) the same bug. __

[PATCH 2/2] TODO: keybindings for next/previous thread done

2013-05-25 Thread Jani Nikula
--- devel/TODO |2 -- 1 file changed, 2 deletions(-) diff --git a/devel/TODO b/devel/TODO index f63385d..844555e 100644 --- a/devel/TODO +++ b/devel/TODO @@ -34,8 +34,6 @@ current message/thread and make searches not return deleted messages by default, (unless the user asks explicitly for d

[PATCH 1/2] emacs: add show view bindings to move to previous/next thread

2013-05-25 Thread Jani Nikula
We have most of the plumbing in place, add the bindings M-n and M-p. --- v2: reduce duplication by adding PREVIOUS argument to notmuch-show-next-thread instead of adding a separate function for moving to previous thread (Mark) --- emacs/notmuch-show.el | 28

[PATCH 1/2] emacs: add show view bindings to move to previous/next thread

2013-05-25 Thread Mark Walters
Hi > We have most of the plumbing in place, add the bindings M-n and M-p. > > --- > > v2: reduce duplication by adding PREVIOUS argument to > notmuch-show-next-thread instead of adding a separate function for > moving to previous thread (Mark) > --- > emacs/notmuch-show.el | 28 +++

[PATCH v2] build: fix out-of-tree builds

2013-05-25 Thread Jani Nikula
Support for out-of-tree builds was added in commit 3e4a9d60a9419621b08c647a306843d76c47c2cb Author: Carl Worth Date: Wed Mar 9 15:02:42 2011 -0800 build: Add support for non-source-directory builds. and broken in commit 7beeb8c88a014ecbc53d8241f10683b3c4c16228 Author: David Bremner Date:

[PATCH] emacs: add show view bindings to move to previous/next thread

2013-05-25 Thread Mark Walters
From: Jani Nikula We have most of the plumbing in place, add the bindings M-n and M-p. --- emacs/notmuch-show.el | 30 +- 1 files changed, 25 insertions(+), 5 deletions(-) diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el index d56154e..2b33007 100644 ---

[PATCH] cli: remove unused argument descriptions

2013-05-25 Thread Jani Nikula
Clean up leftovers from help system rework. These are no longer needed. They are easy to resurrect and update if a need later arises. --- notmuch.c | 13 - 1 file changed, 13 deletions(-) diff --git a/notmuch.c b/notmuch.c index f51a84f..267ce3d 100644 --- a/notmuch.c +++ b/notmuch.

[PATCH 2/4] test: added --stderr=FILE tests

2013-05-25 Thread Jani Nikula
On Fri, 24 May 2013, Jani Nikula wrote: > On Thu, 23 May 2013, Tomi Ollila wrote: >> --stderr=FILE tests were added to test/help-test as it is the one >> doing most global option testing. Also, it was simplest to test >> this new option using `notmuch help` command. >> --- >> >> In the future thi

Re: [PATCH 1/2] emacs: add show view bindings to move to previous/next thread

2013-05-25 Thread Jani Nikula
On Sat, 25 May 2013, Mark Walters wrote: > Did you want this to not exit back to the search results if you do M-p > on the first result? I attach a version below that does exit back (so > M-p and M-n behave the same. Oh, that was just pure fail from my part. Sorry about that, Mark, and thanks so

[PATCH 0/8] packaging: fedora: general updates

2013-05-25 Thread Tomi Ollila
On Sun, Apr 28 2013, Felipe Contreras wrote: > Hi, > > It doesn't seem the spec file is properly maintained, it should be much better > now, closer to Fedora's one, and with support for Ruby bindings. > > Felipe Contreras (8): > packaging: fedora: update > packaging: fedora: remove irrelevant

[PATCH 1/4] cli: add global option --stderr=FILE

2013-05-25 Thread Mark Walters
This series looks good to me and it does simplify the emacs async error handling very usefully. +1 Best wishes Mark On Thu, 23 May 2013, Tomi Ollila wrote: > With this option all writes to stderr are redirected to the spesified > FILE (or to stdout on case FILE is '-'). This is immediately us

[PATCH 4/5] emacs: Streaming S-expression parser

2013-05-25 Thread Mark Walters
Hi On Wed, 22 May 2013, Austin Clements wrote: > On Tue, 21 May 2013, Mark Walters wrote: >> Hi >> >> This patch looks good to me. Some minor comments below. > > Some minor replies below. > > In building some other code on top of this, I found an interesting (but > easy to fix) interface bug.

[PATCH 0/8] packaging: fedora: general updates

2013-05-25 Thread David Bremner
Felipe Contreras writes: > On Sun, Apr 28, 2013 at 4:52 AM, Felipe Contreras > wrote: > >> It doesn't seem the spec file is properly maintained, it should be much >> better >> now, closer to Fedora's one, and with support for Ruby bindings. > > What about these? > Hi Felipe At this point we w

Re: [PATCH 1/2] emacs: add show view bindings to move to previous/next thread

2013-05-25 Thread Mark Walters
Hi > We have most of the plumbing in place, add the bindings M-n and M-p. > > --- > > v2: reduce duplication by adding PREVIOUS argument to > notmuch-show-next-thread instead of adding a separate function for > moving to previous thread (Mark) > --- > emacs/notmuch-show.el | 28 +++

Re: [PATCH 0/8] packaging: fedora: general updates

2013-05-25 Thread David Bremner
Felipe Contreras writes: > On Sun, Apr 28, 2013 at 4:52 AM, Felipe Contreras > wrote: > >> It doesn't seem the spec file is properly maintained, it should be much >> better >> now, closer to Fedora's one, and with support for Ruby bindings. > > What about these? > Hi Felipe At this point we w

[PATCH 2/2] TODO: keybindings for next/previous thread done

2013-05-25 Thread Jani Nikula
--- devel/TODO |2 -- 1 file changed, 2 deletions(-) diff --git a/devel/TODO b/devel/TODO index f63385d..844555e 100644 --- a/devel/TODO +++ b/devel/TODO @@ -34,8 +34,6 @@ current message/thread and make searches not return deleted messages by default, (unless the user asks explicitly for d

[PATCH 1/2] emacs: add show view bindings to move to previous/next thread

2013-05-25 Thread Jani Nikula
We have most of the plumbing in place, add the bindings M-n and M-p. --- v2: reduce duplication by adding PREVIOUS argument to notmuch-show-next-thread instead of adding a separate function for moving to previous thread (Mark) --- emacs/notmuch-show.el | 28

[PATCH v2] build: fix out-of-tree builds

2013-05-25 Thread Jani Nikula
Support for out-of-tree builds was added in commit 3e4a9d60a9419621b08c647a306843d76c47c2cb Author: Carl Worth Date: Wed Mar 9 15:02:42 2011 -0800 build: Add support for non-source-directory builds. and broken in commit 7beeb8c88a014ecbc53d8241f10683b3c4c16228 Author: David Bremner Date:

[PATCH] cli: remove unused argument descriptions

2013-05-25 Thread Jani Nikula
Clean up leftovers from help system rework. These are no longer needed. They are easy to resurrect and update if a need later arises. --- notmuch.c | 13 - 1 file changed, 13 deletions(-) diff --git a/notmuch.c b/notmuch.c index f51a84f..267ce3d 100644 --- a/notmuch.c +++ b/notmuch.

Re: [PATCH 2/4] test: added --stderr=FILE tests

2013-05-25 Thread Jani Nikula
On Fri, 24 May 2013, Jani Nikula wrote: > On Thu, 23 May 2013, Tomi Ollila wrote: >> --stderr=FILE tests were added to test/help-test as it is the one >> doing most global option testing. Also, it was simplest to test >> this new option using `notmuch help` command. >> --- >> >> In the future thi

Re: [PATCH 1/4] cli: add global option --stderr=FILE

2013-05-25 Thread Mark Walters
This series looks good to me and it does simplify the emacs async error handling very usefully. +1 Best wishes Mark On Thu, 23 May 2013, Tomi Ollila wrote: > With this option all writes to stderr are redirected to the spesified > FILE (or to stdout on case FILE is '-'). This is immediately us

Re: [PATCH 4/5] emacs: Streaming S-expression parser

2013-05-25 Thread Mark Walters
Hi On Wed, 22 May 2013, Austin Clements wrote: > On Tue, 21 May 2013, Mark Walters wrote: >> Hi >> >> This patch looks good to me. Some minor comments below. > > Some minor replies below. > > In building some other code on top of this, I found an interesting (but > easy to fix) interface bug.

Re: [PATCH 0/8] packaging: fedora: general updates

2013-05-25 Thread Tomi Ollila
On Sun, Apr 28 2013, Felipe Contreras wrote: > Hi, > > It doesn't seem the spec file is properly maintained, it should be much better > now, closer to Fedora's one, and with support for Ruby bindings. > > Felipe Contreras (8): > packaging: fedora: update > packaging: fedora: remove irrelevant