[PATCH v2] new: Don't scan unchanged directories with no sub-directories

2013-10-28 Thread Vladimir Marek
> > This can substantially reduce the cost of notmuch new in some > > situations, such as when the file system cache is cold or when the > > Maildir is on NFS. > > --- > > pushed as commit 516efb7807 Muchas gracias! -- Vlad

[PATCH 4/4] database: Handle error while deleting uncompacted database

2013-10-28 Thread Ben Gamari
We never checked to ensure that the rmtree() of the old database succeeded. Signed-off-by: Ben Gamari --- lib/database.cc | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/lib/database.cc b/lib/database.cc index 34753ab..bfc5dac 100644 --- a/lib/database.cc +++ b

[PATCH 3/4] compact: Provide user with more error feedback

2013-10-28 Thread Ben Gamari
Provide instructions on what to do when we couldn't move the compacted database into place. Signed-off-by: Ben Gamari --- lib/database.cc | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/lib/database.cc b/lib/database.cc index 57c2292..34753ab 100644 --- a

[PATCH 2/4] compact: Give user more feedback on failure renaming

2013-10-28 Thread Ben Gamari
Provide the user with instructions after we fail to move the old un-compacted database out of the way. Signed-off-by: Ben Gamari --- lib/database.cc | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/lib/database.cc b/lib/database.cc index 06f1c0a..57c2292 100644 --- a/l

[PATCH 1/4] test: Add compact test

2013-10-28 Thread Ben Gamari
Signed-off-by: Ben Gamari --- test/compact | 35 +++ test/notmuch-test | 1 + 2 files changed, 36 insertions(+) create mode 100755 test/compact diff --git a/test/compact b/test/compact new file mode 100755 index 000..54e85ab --- /dev/null +++ b/test/com

[PATCH 3/3] compact: Provide user with more error feedback

2013-10-28 Thread Ben Gamari
apologies. New set coming. Cheers, - Ben -- next part ------ A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 489 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20131028/6c698f89/attachment.pgp>

[PATCH] lib: fix build on !HAVE_XAPIAN_COMPACT

2013-10-28 Thread Tomi Ollila
On Mon, Oct 28 2013, Jani Nikula wrote: > Minimal change to build notmuch against xapian that doesn't have > compaction support. > --- LGTM. Tomi > lib/database.cc |4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/lib/database.cc b/lib/database.cc > index 06f1c

[PATCH v2] new: Don't scan unchanged directories with no sub-directories

2013-10-28 Thread David Bremner
Austin Clements writes: > This can substantially reduce the cost of notmuch new in some > situations, such as when the file system cache is cold or when the > Maildir is on NFS. > --- pushed as commit 516efb7807 d

[PATCH 1/4] test: Add compact test

2013-10-28 Thread Ben Gamari
Signed-off-by: Ben Gamari --- test/compact | 35 +++ test/notmuch-test | 1 + 2 files changed, 36 insertions(+) create mode 100755 test/compact diff --git a/test/compact b/test/compact new file mode 100755 index 000..54e85ab --- /dev/null +++ b/test/com

[PATCH 2/4] compact: Give user more feedback on failure renaming

2013-10-28 Thread Ben Gamari
Provide the user with instructions after we fail to move the old un-compacted database out of the way. Signed-off-by: Ben Gamari --- lib/database.cc | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/lib/database.cc b/lib/database.cc index 06f1c0a..57c2292 100644 --- a/l

[PATCH 4/4] database: Handle error while deleting uncompacted database

2013-10-28 Thread Ben Gamari
We never checked to ensure that the rmtree() of the old database succeeded. Signed-off-by: Ben Gamari --- lib/database.cc | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/lib/database.cc b/lib/database.cc index 34753ab..bfc5dac 100644 --- a/lib/database.cc +++ b

[PATCH 3/4] compact: Provide user with more error feedback

2013-10-28 Thread Ben Gamari
Provide instructions on what to do when we couldn't move the compacted database into place. Signed-off-by: Ben Gamari --- lib/database.cc | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/lib/database.cc b/lib/database.cc index 57c2292..34753ab 100644 --- a

Re: [PATCH 3/3] compact: Provide user with more error feedback

2013-10-28 Thread Ben Gamari
Tomi Ollila writes: > On Sun, Oct 27 2013, Ben Gamari wrote: > >> Provide instructions on what to do when we couldn't move the compacted >> database into place. >> >> Signed-off-by: Ben Gamari >> --- >> lib/database.cc | 18 +- >> 1 file changed, 17 insertions(+), 1 deletion(-)

[PATCH] lib: fix build on !HAVE_XAPIAN_COMPACT

2013-10-28 Thread Jani Nikula
Minimal change to build notmuch against xapian that doesn't have compaction support. --- lib/database.cc |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/lib/database.cc b/lib/database.cc index 06f1c0a..20e5ec2 100644 --- a/lib/database.cc +++ b/lib/database.cc @@ -944,7

Re: Re: [PATCH v2] new: Don't scan unchanged directories with no sub-directories

2013-10-28 Thread Vladimir Marek
> > This can substantially reduce the cost of notmuch new in some > > situations, such as when the file system cache is cold or when the > > Maildir is on NFS. > > --- > > pushed as commit 516efb7807 Muchas gracias! -- Vlad ___ notmuch mailing

Re: [PATCH v2] new: Don't scan unchanged directories with no sub-directories

2013-10-28 Thread David Bremner
Austin Clements writes: > This can substantially reduce the cost of notmuch new in some > situations, such as when the file system cache is cold or when the > Maildir is on NFS. > --- pushed as commit 516efb7807 d ___ notmuch mailing list notmuch@notm

Re: [PATCH] lib: fix build on !HAVE_XAPIAN_COMPACT

2013-10-28 Thread Tomi Ollila
On Mon, Oct 28 2013, Jani Nikula wrote: > Minimal change to build notmuch against xapian that doesn't have > compaction support. > --- LGTM. Tomi > lib/database.cc |4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/lib/database.cc b/lib/database.cc > index 06f1c

[PATCH] emacs: Add a space after completed tag operations

2013-10-28 Thread David Bremner
Austin Clements writes: > Previously, when a user fully completed a tag operation, they had to > press space to begin entering another tag operation. This is > different from, say, shell file name completion, which typically > inserts a space after an unambiguous completion under the assumption

[PATCH] lib: fix build on !HAVE_XAPIAN_COMPACT

2013-10-28 Thread Jani Nikula
Minimal change to build notmuch against xapian that doesn't have compaction support. --- lib/database.cc |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/lib/database.cc b/lib/database.cc index 06f1c0a..20e5ec2 100644 --- a/lib/database.cc +++ b/lib/database.cc @@ -944,7

Re: [PATCH] emacs: Add a space after completed tag operations

2013-10-28 Thread David Bremner
Austin Clements writes: > Previously, when a user fully completed a tag operation, they had to > press space to begin entering another tag operation. This is > different from, say, shell file name completion, which typically > inserts a space after an unambiguous completion under the assumption