Build broken on OS X 10.9

On Sat, Nov 02 2013, Rainer M Krug wrote: > Tomi Ollila writes: > >> On Fri, Nov 01 2013, Michael Phillips >> wrote: >> >>> On Fri, Nov 1, 2013 at 1:44 AM, Tomi Ollila wrote: Hmm, it seems the rule doing that says @mkdir -p .deps/$(@D) ... does `mkdir -p xyzdir/.` fail in OS X

Build broken on OS X 10.9

Tomi Ollila writes: > On Sat, Nov 02 2013, Rainer M Krug wrote: > >> Tomi Ollila writes: >> >>> On Fri, Nov 01 2013, Michael Phillips >>> wrote: >>> On Fri, Nov 1, 2013 at 1:44 AM, Tomi Ollila wrote: > Hmm, it seems the rule doing that says @mkdir -p .deps/$(@D) ... > >

Getting the right root mail of the thread

On Sat, 02 Nov 2013, Felipe Contreras wrote: > On Sat, Nov 2, 2013 at 7:50 AM, Jani Nikula wrote: >> On Sat, 02 Nov 2013, Felipe Contreras wrote: > >>> I think there should be a way to get the root mail of a thread, >>> irrespective of the search order. >> >> Largely agreed. It's just that

Build broken on OS X 10.9

Tomi Ollila writes: > On Fri, Nov 01 2013, Michael Phillips > wrote: > >> On Fri, Nov 1, 2013 at 1:44 AM, Tomi Ollila wrote: >>> Hmm, it seems the rule doing that says @mkdir -p .deps/$(@D) ... >>> >>> does `mkdir -p xyzdir/.` fail in OS X 10.9 (Mavericks) ? >> >> $ mkdir -p xyzdir/. >> >>

Getting the right root mail of the thread

On Sat, 02 Nov 2013, Felipe Contreras wrote: > I often wondered why when browsing threads, I often see a message that doesn't > describe at all the thread, for example: > > notmuch search ... > thread:826a 18 mins. ago [45/45] Felipe Contreras; [PATCH/TEST > 44/44] > > I can

[PATCH 0/3] General fixes

On Sat, Nov 02 2013, Felipe Contreras wrote: > David Bremner wrote: >> Felipe Contreras writes: >> >> > David Bremner wrote: >> >> Felipe Contreras writes: >> >> >> >> > Felipe Contreras (3): >> >> > query: bind queries to database objects >> >> > ruby: allow build with RUNPATH >> >> >

[PATCH] test: fix compact backup / restore test

On Sat, Nov 02 2013, David Bremner wrote: > It was looking in completely the wrong place for the backup and the > (test) xapian database. Unfortunately test_begin_subtest hides the > relevant errors. > --- LGTM. It took me a while noticing that also ${TEST_TMPDIR} was changed to ${MAIL_DIR}

Build broken on OS X 10.9

Rainer M Krug writes: > Tomi Ollila writes: > > Hi Tomi > > thanks for the immediate reply, but I am effectively clueless how I can > apply this patch under homebrew. > > Any tips appreciated, > > Rainer I guess you should talk to the person that packages notmuch for homebrew? d

[PATCH 3/6] lib: use the backup path provided by the user, don't add anything to it

Ah, right, I was juggling the patch order back and forth a bit, and I missed this (as I drop the path completely in a later patch). Jani. -- next part -- An HTML attachment was scrubbed... URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20131102/c79f6f95/attachment.html>

[PATCH] test: fix compact backup / restore test

Tomi Ollila writes: > On Sat, Nov 02 2013, David Bremner wrote: > >> It was looking in completely the wrong place for the backup and the >> (test) xapian database. Unfortunately test_begin_subtest hides the >> relevant errors. >> --- > > LGTM. It took me a while noticing that also

[PATCH 1/3] database: Add notmuch_database_compact_close

e that /xapian.old isn't the right place for it. I would think that .old would be a much better place. I'm not such a fan of dumping internal notmuch stuff into the main mail directory. Keeping all notmuch stuff in seems more reasonable and polite. jamie. -- next part

[PATCH 0/3] General fixes

Felipe Contreras writes: > David Bremner wrote: >> Felipe Contreras writes: >> >> > Felipe Contreras (3): >> > query: bind queries to database objects >> > ruby: allow build with RUNPATH >> > ruby: bind database close()/destroy() properly >> >> I agree with the discussion on IRC that

[PATCH 4/4] database: Handle error while deleting uncompacted database

Ben Gamari writes: > We never checked to ensure that the rmtree() of the old database > succeeded. > Is there some reason these patches (and the existing compact code in the lib) is using fprintf and not the status callback function? Most places we don't (yet) have logging callbacks, but here

[PATCH] lib: update documentation of callback functions for database_compact and database_upgrade.

Jani Nikula writes: > The point was, we can do this *now* without soname bumps, because we > haven't released this yet. OK, I think we are agreeing violently. This is a bit ephemeral for a commit message, but not worth re-doing the patch just for that. d

[PATCH 3/6] lib: use the backup path provided by the user, don't add anything to it

Jani Nikula writes: > Adding another level is just useless cruft. > --- > lib/database.cc | 14 -- > notmuch-compact.c |4 ++-- > 2 files changed, 6 insertions(+), 12 deletions(-) The first two patches are fine, modulo my comments about documentation. I think the backup

Getting the right root mail of the thread

On Sat, Nov 2, 2013 at 7:50 AM, Jani Nikula wrote: > On Sat, 02 Nov 2013, Felipe Contreras wrote: >> I think there should be a way to get the root mail of a thread, >> irrespective of the search order. > > Largely agreed. It's just that nobody's gotten around to doing this > yet. At the cli

[PATCH 21/21] vim: add help file

Signed-off-by: Felipe Contreras --- debian/notmuch-vim.dirs| 1 + debian/notmuch-vim.install | 1 + vim/Makefile | 1 + vim/notmuch.txt| 153 + vim/notmuch.yaml | 1 + 5 files changed, 157 insertions(+)

[PATCH 20/21] vim: check compose is done on delete

Not on unload, which happens when we switch buffers. Signed-off-by: Felipe Contreras --- vim/notmuch.vim | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index 9109470..d7b310c 100644 --- a/vim/notmuch.vim +++ b/vim/notmuch.vim @@ -67,7

[PATCH 19/21] vim: remove unnecessary buffer queue

Vim handles the buffers just fine: when one is deleted, we go to the previous one. Signed-off-by: Felipe Contreras --- vim/notmuch.vim | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index fc9eaa2..9109470 100644 ---

[PATCH 18/21] vim: add wrapper for old variable names

Signed-off-by: Felipe Contreras --- vim/notmuch.vim | 44 ++-- 1 file changed, 38 insertions(+), 6 deletions(-) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index 71d4b32..fc9eaa2 100644 --- a/vim/notmuch.vim +++ b/vim/notmuch.vim @@ -391,23 +391,51 @@

[PATCH 17/21] vim: move default sets to set_defaults()

Signed-off-by: Felipe Contreras --- vim/notmuch.vim | 40 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index 2fe9346..71d4b32 100644 --- a/vim/notmuch.vim +++ b/vim/notmuch.vim @@ -60,26 +60,6 @@ let

[PATCH 16/21] vim: rename public notmuch_rb variables

Signed-off-by: Felipe Contreras --- vim/notmuch.vim | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index 4e4dfb0..2fe9346 100644 --- a/vim/notmuch.vim +++ b/vim/notmuch.vim @@ -60,24 +60,24 @@ let

[PATCH 15/21] vim: rename internal notmuch_rb variables

Now we are the official one. Signed-off-by: Felipe Contreras --- vim/notmuch.vim | 59 ++--- 1 file changed, 27 insertions(+), 32 deletions(-) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index 42c5f18..4e4dfb0 100644 --- a/vim/notmuch.vim

[PATCH 14/21] vim: add option to compose new messages

Signed-off-by: Felipe Contreras --- vim/notmuch.vim | 33 + 1 file changed, 33 insertions(+) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index 8383fd6..42c5f18 100644 --- a/vim/notmuch.vim +++ b/vim/notmuch.vim @@ -12,6 +12,7 @@ let g:notmuch_rb_folders_maps =

[PATCH 13/21] vim: refactor open_reply()

In preparation for composing new messages. Signed-off-by: Felipe Contreras --- vim/notmuch.vim | 92 ++--- 1 file changed, 49 insertions(+), 43 deletions(-) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index 9a45300..8383fd6 100644 ---

[PATCH 12/21] vim: trivial cleanup

Using $email_address is more straight forward. Signed-off-by: Felipe Contreras --- vim/notmuch.vim | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index cf829a6..9a45300 100644 --- a/vim/notmuch.vim +++ b/vim/notmuch.vim @@ -566,7 +566,7 @@

[PATCH 11/21] vim: don't execute search if it's cancelled

Signed-off-by: Felipe Contreras --- vim/notmuch.vim | 3 +++ 1 file changed, 3 insertions(+) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index 64038eb..cf829a6 100644 --- a/vim/notmuch.vim +++ b/vim/notmuch.vim @@ -208,6 +208,9 @@ endfunction function! s:search_search_prompt() let

[PATCH 10/21] vim: generate custom message-id

Using Mail as a reference. Signed-off-by: Felipe Contreras --- vim/notmuch.vim | 10 ++ 1 file changed, 10 insertions(+) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index 4bd5f13..64038eb 100644 --- a/vim/notmuch.vim +++ b/vim/notmuch.vim @@ -421,6 +421,7 @@ ruby << EOF

[PATCH 09/21] vim: split $email_address

Signed-off-by: Felipe Contreras --- vim/notmuch.vim | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index aa1b7ef..4bd5f13 100644 --- a/vim/notmuch.vim +++ b/vim/notmuch.vim @@ -427,7 +427,7 @@ ruby << EOF end

[PATCH 08/21] vim: allow calling with arguments

For example: :NotMuch date:today Signed-off-by: Felipe Contreras --- vim/notmuch.vim | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index 9cfa795..aa1b7ef 100644 --- a/vim/notmuch.vim +++ b/vim/notmuch.vim @@

[PATCH 07/21] vim: add option to save the patches of a patch series

Signed-off-by: Felipe Contreras --- vim/notmuch.vim | 15 +++ 1 file changed, 15 insertions(+) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index a1c5e28..9cfa795 100644 --- a/vim/notmuch.vim +++ b/vim/notmuch.vim @@ -34,6 +34,7 @@ let g:notmuch_rb_show_maps = { \ 'o':

[PATCH 06/21] vim: use much clearer sort constant

Signed-off-by: Felipe Contreras --- vim/notmuch.vim | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index 11ea4fd..a1c5e28 100644 --- a/vim/notmuch.vim +++ b/vim/notmuch.vim @@ -302,7 +302,7 @@ ruby << EOF $messages.clear

[PATCH 05/21] vim: show first message of the thread

Signed-off-by: Felipe Contreras --- vim/notmuch.vim | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index 72bf73b..11ea4fd 100644 --- a/vim/notmuch.vim +++ b/vim/notmuch.vim @@ -557,6 +557,7 @@ ruby << EOF def

[PATCH 04/21] vim: refactor database handling

To minimize memory usage we need to destroy the queries and the databases, so we should keep track of them. Each buffer gets a database connection that is destroyed when the buffer is destroyed, and all the queries along with it. Ideally notmuch should destroy the queries when the database is

[PATCH 03/21] vim: use notmuch fields

They are better encoded than Ruby's Mail. Signed-off-by: Felipe Contreras --- vim/notmuch.vim | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index 438fadf..11a7c26 100644 --- a/vim/notmuch.vim +++ b/vim/notmuch.vim @@ -309,9 +309,9 @@

[PATCH 02/21] vim: don't automatically refresh after tagging

This operation might take a while, and even if it only takes fractions of a second, that's not what the user might want. Signed-off-by: Felipe Contreras --- vim/notmuch.vim | 1 - 1 file changed, 1 deletion(-) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index 0ccaaf1..438fadf 100644 ---

[PATCH 01/21] vim: run mutt in default term

From: Charlie Allom Signed-off-by: Felipe Contreras --- vim/notmuch.vim | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index bdf2720..0ccaaf1 100644 --- a/vim/notmuch.vim +++ b/vim/notmuch.vim @@ -52,7 +52,7

[PATCH 00/21] vim: general updates

Hi, I've been cooking this in my personal notmuch-vim-ruby repository, and I think they are ready for notmuch. A few highlights: * There's now support to compose new messages, previously there was only support to reply. * Database handling has been revamped to get rid of memory leaks * A

[PATCH 0/3] General fixes

David Bremner wrote: > Felipe Contreras writes: > > > David Bremner wrote: > >> Felipe Contreras writes: > >> > >> > Felipe Contreras (3): > >> > query: bind queries to database objects > >> > ruby: allow build with RUNPATH > >> > ruby: bind database close()/destroy() properly > >> > >>

Getting the right root mail of the thread

Hi, I often wondered why when browsing threads, I often see a message that doesn't describe at all the thread, for example: notmuch search ... thread:826a 18 mins. ago [45/45] Felipe Contreras; [PATCH/TEST 44/44] I can reverse the order of the search: notmuch search

[PATCH 0/3] General fixes

David Bremner wrote: > Felipe Contreras writes: > > > Felipe Contreras (3): > > query: bind queries to database objects > > ruby: allow build with RUNPATH > > ruby: bind database close()/destroy() properly > > I agree with the discussion on IRC that the change in the first patch > makes

[PATCH] lib: update documentation of callback functions for database_compact and database_upgrade.

ny callback invoked. > */ > notmuch_status_t > notmuch_database_upgrade (notmuch_database_t *database, > -- > 1.8.4.rc3 > > ___ > notmuch mailing list > notmuch at notmuchmail.org > http://notmuchmail.org/mailman/listinfo/

Re: [PATCH 3/6] lib: use the backup path provided by the user, don't add anything to it

Jani Nikula j...@nikula.org writes: Adding another level is just useless cruft. --- lib/database.cc | 14 -- notmuch-compact.c |4 ++-- 2 files changed, 6 insertions(+), 12 deletions(-) The first two patches are fine, modulo my comments about documentation. I think the

Re: [PATCH] lib: update documentation of callback functions for database_compact and database_upgrade.

Jani Nikula j...@nikula.org writes: The point was, we can do this *now* without soname bumps, because we haven't released this yet. OK, I think we are agreeing violently. This is a bit ephemeral for a commit message, but not worth re-doing the patch just for that. d

Re: [PATCH 3/6] lib: use the backup path provided by the user, don't add anything to it

On Nov 2, 2013 2:14 PM, David Bremner da...@tethera.net wrote: Jani Nikula j...@nikula.org writes: Adding another level is just useless cruft. --- lib/database.cc | 14 -- notmuch-compact.c |4 ++-- 2 files changed, 6 insertions(+), 12 deletions(-) The first two

Re: [PATCH 4/4] database: Handle error while deleting uncompacted database

Ben Gamari bgamari.f...@gmail.com writes: We never checked to ensure that the rmtree() of the old database succeeded. Is there some reason these patches (and the existing compact code in the lib) is using fprintf and not the status callback function? Most places we don't (yet) have logging

Re: [PATCH 0/3] General fixes

David Bremner wrote: Felipe Contreras felipe.contre...@gmail.com writes: Felipe Contreras (3): query: bind queries to database objects ruby: allow build with RUNPATH ruby: bind database close()/destroy() properly I agree with the discussion on IRC that the change in the first

Re: [PATCH 0/3] General fixes

Felipe Contreras felipe.contre...@gmail.com writes: David Bremner wrote: Felipe Contreras felipe.contre...@gmail.com writes: Felipe Contreras (3): query: bind queries to database objects ruby: allow build with RUNPATH ruby: bind database close()/destroy() properly I agree

Getting the right root mail of the thread

Hi, I often wondered why when browsing threads, I often see a message that doesn't describe at all the thread, for example: notmuch search ... thread:826a 18 mins. ago [45/45] Felipe Contreras; [PATCH/TEST 44/44] I can reverse the order of the search: notmuch search

Re: [PATCH] test: fix compact backup / restore test

On Sat, Nov 02 2013, David Bremner da...@tethera.net wrote: It was looking in completely the wrong place for the backup and the (test) xapian database. Unfortunately test_begin_subtest hides the relevant errors. --- LGTM. It took me a while noticing that also ${TEST_TMPDIR} was changed to

Re: [PATCH 0/3] General fixes

David Bremner wrote: Felipe Contreras felipe.contre...@gmail.com writes: David Bremner wrote: Felipe Contreras felipe.contre...@gmail.com writes: Felipe Contreras (3): query: bind queries to database objects ruby: allow build with RUNPATH ruby: bind database

Re: [PATCH 0/3] General fixes

On Sat, Nov 02 2013, Felipe Contreras felipe.contre...@gmail.com wrote: David Bremner wrote: Felipe Contreras felipe.contre...@gmail.com writes: David Bremner wrote: Felipe Contreras felipe.contre...@gmail.com writes: Felipe Contreras (3): query: bind queries to database

Re: Getting the right root mail of the thread

On Sat, 02 Nov 2013, Felipe Contreras felipe.contre...@gmail.com wrote: I often wondered why when browsing threads, I often see a message that doesn't describe at all the thread, for example: notmuch search ... thread:826a 18 mins. ago [45/45] Felipe Contreras; [PATCH/TEST

[PATCH 01/21] vim: run mutt in default term

From: Charlie Allom char...@evilforbeginners.com Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- vim/notmuch.vim | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index bdf2720..0ccaaf1 100644 --- a/vim/notmuch.vim +++

[PATCH 00/21] vim: general updates

Hi, I've been cooking this in my personal notmuch-vim-ruby repository, and I think they are ready for notmuch. A few highlights: * There's now support to compose new messages, previously there was only support to reply. * Database handling has been revamped to get rid of memory leaks * A

[PATCH 03/21] vim: use notmuch fields

They are better encoded than Ruby's Mail. Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- vim/notmuch.vim | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index 438fadf..11a7c26 100644 --- a/vim/notmuch.vim +++

[PATCH 02/21] vim: don't automatically refresh after tagging

This operation might take a while, and even if it only takes fractions of a second, that's not what the user might want. Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- vim/notmuch.vim | 1 - 1 file changed, 1 deletion(-) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index

[PATCH 05/21] vim: show first message of the thread

Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- vim/notmuch.vim | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index 72bf73b..11ea4fd 100644 --- a/vim/notmuch.vim +++ b/vim/notmuch.vim @@ -557,6 +557,7 @@ ruby EOF

[PATCH 04/21] vim: refactor database handling

To minimize memory usage we need to destroy the queries and the databases, so we should keep track of them. Each buffer gets a database connection that is destroyed when the buffer is destroyed, and all the queries along with it. Ideally notmuch should destroy the queries when the database is

[PATCH 07/21] vim: add option to save the patches of a patch series

Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- vim/notmuch.vim | 15 +++ 1 file changed, 15 insertions(+) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index a1c5e28..9cfa795 100644 --- a/vim/notmuch.vim +++ b/vim/notmuch.vim @@ -34,6 +34,7 @@ let

[PATCH 06/21] vim: use much clearer sort constant

Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- vim/notmuch.vim | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index 11ea4fd..a1c5e28 100644 --- a/vim/notmuch.vim +++ b/vim/notmuch.vim @@ -302,7 +302,7 @@ ruby EOF

[PATCH 08/21] vim: allow calling with arguments

For example: :NotMuch date:today Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- vim/notmuch.vim | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index 9cfa795..aa1b7ef 100644 --- a/vim/notmuch.vim +++

[PATCH 10/21] vim: generate custom message-id

Using Mail as a reference. Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- vim/notmuch.vim | 10 ++ 1 file changed, 10 insertions(+) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index 4bd5f13..64038eb 100644 --- a/vim/notmuch.vim +++ b/vim/notmuch.vim @@ -421,6 +421,7

[PATCH 09/21] vim: split $email_address

Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- vim/notmuch.vim | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index aa1b7ef..4bd5f13 100644 --- a/vim/notmuch.vim +++ b/vim/notmuch.vim @@ -427,7 +427,7 @@ ruby EOF

[PATCH 14/21] vim: add option to compose new messages

Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- vim/notmuch.vim | 33 + 1 file changed, 33 insertions(+) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index 8383fd6..42c5f18 100644 --- a/vim/notmuch.vim +++ b/vim/notmuch.vim @@ -12,6 +12,7 @@ let

[PATCH 11/21] vim: don't execute search if it's cancelled

Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- vim/notmuch.vim | 3 +++ 1 file changed, 3 insertions(+) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index 64038eb..cf829a6 100644 --- a/vim/notmuch.vim +++ b/vim/notmuch.vim @@ -208,6 +208,9 @@ endfunction function!

[PATCH 17/21] vim: move default sets to set_defaults()

Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- vim/notmuch.vim | 40 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index 2fe9346..71d4b32 100644 --- a/vim/notmuch.vim +++ b/vim/notmuch.vim

[PATCH 16/21] vim: rename public notmuch_rb variables

Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- vim/notmuch.vim | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index 4e4dfb0..2fe9346 100644 --- a/vim/notmuch.vim +++ b/vim/notmuch.vim @@

[PATCH 18/21] vim: add wrapper for old variable names

Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- vim/notmuch.vim | 44 ++-- 1 file changed, 38 insertions(+), 6 deletions(-) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index 71d4b32..fc9eaa2 100644 --- a/vim/notmuch.vim +++

[PATCH 15/21] vim: rename internal notmuch_rb variables

Now we are the official one. Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- vim/notmuch.vim | 59 ++--- 1 file changed, 27 insertions(+), 32 deletions(-) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index 42c5f18..4e4dfb0

[PATCH 21/21] vim: add help file

Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- debian/notmuch-vim.dirs| 1 + debian/notmuch-vim.install | 1 + vim/Makefile | 1 + vim/notmuch.txt| 153 + vim/notmuch.yaml | 1 + 5 files

[PATCH 20/21] vim: check compose is done on delete

Not on unload, which happens when we switch buffers. Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- vim/notmuch.vim | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index 9109470..d7b310c 100644 --- a/vim/notmuch.vim +++

[PATCH 19/21] vim: remove unnecessary buffer queue

Vim handles the buffers just fine: when one is deleted, we go to the previous one. Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- vim/notmuch.vim | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/vim/notmuch.vim b/vim/notmuch.vim index

Re: Getting the right root mail of the thread

On Sat, Nov 2, 2013 at 7:50 AM, Jani Nikula j...@nikula.org wrote: On Sat, 02 Nov 2013, Felipe Contreras felipe.contre...@gmail.com wrote: I think there should be a way to get the root mail of a thread, irrespective of the search order. Largely agreed. It's just that nobody's gotten around

Re: [PATCH] test: fix compact backup / restore test

Tomi Ollila tomi.oll...@iki.fi writes: On Sat, Nov 02 2013, David Bremner da...@tethera.net wrote: It was looking in completely the wrong place for the backup and the (test) xapian database. Unfortunately test_begin_subtest hides the relevant errors. --- LGTM. It took me a while noticing

Re: Getting the right root mail of the thread

On Sat, 02 Nov 2013, Felipe Contreras felipe.contre...@gmail.com wrote: On Sat, Nov 2, 2013 at 7:50 AM, Jani Nikula j...@nikula.org wrote: On Sat, 02 Nov 2013, Felipe Contreras felipe.contre...@gmail.com wrote: I think there should be a way to get the root mail of a thread, irrespective of

Re: Build broken on OS X 10.9

Tomi Ollila tomi.oll...@iki.fi writes: On Fri, Nov 01 2013, Michael Phillips michaelalanphill...@gmail.com wrote: On Fri, Nov 1, 2013 at 1:44 AM, Tomi Ollila tomi.oll...@iki.fi wrote: Hmm, it seems the rule doing that says @mkdir -p .deps/$(@D) ... does `mkdir -p xyzdir/.` fail in OS X 10.9

Re: Build broken on OS X 10.9

On Sat, Nov 02 2013, Rainer M Krug rai...@krugs.de wrote: Tomi Ollila tomi.oll...@iki.fi writes: On Fri, Nov 01 2013, Michael Phillips michaelalanphill...@gmail.com wrote: On Fri, Nov 1, 2013 at 1:44 AM, Tomi Ollila tomi.oll...@iki.fi wrote: Hmm, it seems the rule doing that says @mkdir -p

Re: Build broken on OS X 10.9

Tomi Ollila tomi.oll...@iki.fi writes: On Sat, Nov 02 2013, Rainer M Krug rai...@krugs.de wrote: Tomi Ollila tomi.oll...@iki.fi writes: On Fri, Nov 01 2013, Michael Phillips michaelalanphill...@gmail.com wrote: On Fri, Nov 1, 2013 at 1:44 AM, Tomi Ollila tomi.oll...@iki.fi wrote: Hmm, it

Re: Build broken on OS X 10.9

Rainer M Krug rai...@krugs.de writes: Tomi Ollila tomi.oll...@iki.fi writes: Hi Tomi thanks for the immediate reply, but I am effectively clueless how I can apply this patch under homebrew. Any tips appreciated, Rainer I guess you should talk to the person that packages notmuch for

Re: [PATCH 1/3] database: Add notmuch_database_compact_close

On Wed, Oct 02 2013, Ben Gamari bgamari.f...@gmail.com wrote: +/* Compacts the given database, optionally saving the original database + * in backup_path. Additionally, a callback function can be provided to + * give the user feedback on the progress of the (likely long-lived) + * compaction

Re: Build broken on OS X 10.9

On Sat, Nov 02 2013, Tomi Ollila tomi.oll...@iki.fi wrote: On Sat, Nov 02 2013, Rainer M Krug rai...@krugs.de wrote: Tomi Ollila tomi.oll...@iki.fi writes: On Fri, Nov 01 2013, Michael Phillips michaelalanphill...@gmail.com wrote: On Fri, Nov 1, 2013 at 1:44 AM, Tomi Ollila