[PATCH v3] build: write VERSION file containing $(VERSION) string

2014-01-27 Thread Tomi Ollila
This version file will be as prerequisite to the target files that use the version info for some purpose, like printing it to the user to examine. The contents of the VERSION file is seldom read by the build system itself as the $(VERSION) variable has the same information. --- diffdiff to v2 -CL

[PATCH v2] build: write VERSION file containing $(VERSION) string

2014-01-27 Thread Tomi Ollila
This version file will be as prerequisite to the target files that use the version info for some purpose, like printing it to the user to examine. The contents of the VERSION file is seldom read by the build system itself as the $(VERSION) variable has the same information. --- This is version 2 o

[PATCH 1/1] emacs: ad-activate 'mm-shr after ad-disable-advice 'mm-shr

2014-01-27 Thread Tomi Ollila
Imitated from "Enabling advice" in Emacs lisp manual... ad-disable-advice by itself only changes the enable flag for a piece of advice. To make the change take effect in the advised definition, the advice needs to be activated again. --- emacs/notmuch-lib.el | 3 ++- 1 file changed, 2 insertions(

[PATCH 1/1] emacs: initialize ido(-completing-read) in emacs 23.[123]

2014-01-27 Thread Tomi Ollila
Otherwise `ido-completing-read' will freeze after PROMPT is displayed. --- I tested this on emacs 23.1 & 24.3. I also tested this by adding (sit-for 2.0) inside the advice -- this lead to the addition of (ad-activate 'ido-completing-read (*)). (*) http://lists.gnu.org/archive/html/emacs-pretest-

[PATCH v3] build: write VERSION file containing $(VERSION) string

2014-01-27 Thread David Bremner
Tomi Ollila writes: > +VERSION:=$(shell gv=`exec git describe --match '[0-9.]*'|sed -e s/_/~/ -e > s/-/+/ -e s/-/~/`; test -f VERSION || touch VERSION; read fv < VERSION; test > x"$$fv" = x"$$gv" || echo "$$gv" > VERSION; echo "$$gv") does this need to be one line long? It's a bit scary. > +#

[PATCH] compat: add canonicalize_file_name

2014-01-27 Thread Tomi Ollila
On Mon, Jan 27 2014, David Bremner wrote: > the POSIX 2008 behaviour of realpath is not available everywhere so we > provide a simple wrapper function. We use (and provide) the gnu > extension canonicalize_file_name to make it cleaner to test for the > feature we need; otherwise we have to rely

mm-image-fit-p: Invalid image specification

2014-01-27 Thread Michal Sojka
On Sat, Jan 25 2014, David Bremner wrote: > Michal Sojka writes: > >> Hello, >> >> in emacs, I have a problem displaying an email that contain the >> following part (--format=json): >> >> { >>"content-type" : "image/svg+xml", >>"filename" : "_logo.svg", >>"id" : 4 >

Unexpected search results

2014-01-27 Thread David Bremner
Paul Melis writes: > Hi, > > How exactly does the search function work when it comes to things like > searching in the from or subject field? See the below queries and (lack > of) results: > > paulmlocal at sara11006:/data$ notmuch search from:dem > paulmlocal at sara11006:/data$ notmuch search

Re: [PATCH v3] build: write VERSION file containing $(VERSION) string

2014-01-27 Thread David Bremner
Tomi Ollila writes: > +VERSION:=$(shell gv=`exec git describe --match '[0-9.]*'|sed -e s/_/~/ -e > s/-/+/ -e s/-/~/`; test -f VERSION || touch VERSION; read fv < VERSION; test > x"$$fv" = x"$$gv" || echo "$$gv" > VERSION; echo "$$gv") does this need to be one line long? It's a bit scary. > +#

Bug?: notmuch-search-show-thread shows several threads; only one containing matching messages

2014-01-27 Thread Eric
On Sun, 26 Jan 2014 22:26:04 +0100, Gregor Zattler wrote: > Hi David, > * David Bremner [24. Jan. 2014]: > > Mark Walters writes: > >> I have looked at this and I think this is not notmuch's fault: I think > >> it is a mua doing strange things: > >> > >> One of the mails has an in-reply-to heade

Bug: notmuch new chokes on dangling symlinks and quits

2014-01-27 Thread Eric
On Mon, 27 Jan 2014 02:14:27 +0100, Gregor Zattler wrote: > Hi David, > * David Bremner [26. Jan. 2014]: > > Gregor Zattler writes: > >> I consider this to be a bug. Instead notmuch should simply > >> ignore the symlink. > >> > > > > Since there is a test for specifically this behaviour, I'd h

Re: Unexpected search results

2014-01-27 Thread David Bremner
Paul Melis writes: > Hi, > > How exactly does the search function work when it comes to things like > searching in the from or subject field? See the below queries and (lack > of) results: > > paulmlocal@sara11006:/data$ notmuch search from:dem > paulmlocal@sara11006:/data$ notmuch search from:

Unexpected search results

2014-01-27 Thread Paul Melis
Hi, How exactly does the search function work when it comes to things like searching in the from or subject field? See the below queries and (lack of) results: paulmlocal@sara11006:/data$ notmuch search from:dem paulmlocal@sara11006:/data$ notmuch search from:demi paulmlocal@sara11006:/data$

[PATCH v3] build: write VERSION file containing $(VERSION) string

2014-01-27 Thread Tomi Ollila
This version file will be as prerequisite to the target files that use the version info for some purpose, like printing it to the user to examine. The contents of the VERSION file is seldom read by the build system itself as the $(VERSION) variable has the same information. --- diffdiff to v2 -CL

[PATCH v2] build: write VERSION file containing $(VERSION) string

2014-01-27 Thread Tomi Ollila
This version file will be as prerequisite to the target files that use the version info for some purpose, like printing it to the user to examine. The contents of the VERSION file is seldom read by the build system itself as the $(VERSION) variable has the same information. --- This is version 2 o

Bug: notmuch new chokes on dangling symlinks and quits

2014-01-27 Thread David Bremner
Gregor Zattler writes: > Hi David, > * David Bremner [26. Jan. 2014]: >> Gregor Zattler writes: >>> I consider this to be a bug. Instead notmuch should simply >>> ignore the symlink. >>> >> >> Since there is a test for specifically this behaviour, I'd have to say >> it's a design decision you

[PATCH 1/1] emacs: ad-activate 'mm-shr after ad-disable-advice 'mm-shr

2014-01-27 Thread Tomi Ollila
Imitated from "Enabling advice" in Emacs lisp manual... ad-disable-advice by itself only changes the enable flag for a piece of advice. To make the change take effect in the advised definition, the advice needs to be activated again. --- emacs/notmuch-lib.el | 3 ++- 1 file changed, 2 insertions(

[PATCH 1/1] emacs: initialize ido(-completing-read) in emacs 23.[123]

2014-01-27 Thread Tomi Ollila
Otherwise `ido-completing-read' will freeze after PROMPT is displayed. --- I tested this on emacs 23.1 & 24.3. I also tested this by adding (sit-for 2.0) inside the advice -- this lead to the addition of (ad-activate 'ido-completing-read (*)). (*) http://lists.gnu.org/archive/html/emacs-pretest-

Re: mm-image-fit-p: Invalid image specification

2014-01-27 Thread Michal Sojka
On Sat, Jan 25 2014, David Bremner wrote: > Michal Sojka writes: > >> Hello, >> >> in emacs, I have a problem displaying an email that contain the >> following part (--format=json): >> >> { >>"content-type" : "image/svg+xml", >>"filename" : "_logo.svg", >>"id" : 4 >

Unexpected search results

2014-01-27 Thread Paul Melis
Hi, How exactly does the search function work when it comes to things like searching in the from or subject field? See the below queries and (lack of) results: paulmlocal at sara11006:/data$ notmuch search from:dem paulmlocal at sara11006:/data$ notmuch search from:demi paulmlocal at sara11006:

Re: [PATCH] compat: add canonicalize_file_name

2014-01-27 Thread Tomi Ollila
On Mon, Jan 27 2014, David Bremner wrote: > the POSIX 2008 behaviour of realpath is not available everywhere so we > provide a simple wrapper function. We use (and provide) the gnu > extension canonicalize_file_name to make it cleaner to test for the > feature we need; otherwise we have to rely

[PATCH] compat: add canonicalize_file_name

2014-01-27 Thread David Bremner
the POSIX 2008 behaviour of realpath is not available everywhere so we provide a simple wrapper function. We use (and provide) the gnu extension canonicalize_file_name to make it cleaner to test for the feature we need; otherwise we have to rely on realpath segfaulting if the second argument is nu

Re: Bug: notmuch new chokes on dangling symlinks and quits

2014-01-27 Thread David Bremner
Gregor Zattler writes: > Hi David, > * David Bremner [26. Jan. 2014]: >> Gregor Zattler writes: >>> I consider this to be a bug. Instead notmuch should simply >>> ignore the symlink. >>> >> >> Since there is a test for specifically this behaviour, I'd have to say >> it's a design decision you

notmuch-emacs bug report -- infinite looping trying to select next message

2014-01-27 Thread Michael Hudson-Doyle
David Bremner writes: > Michael Hudson-Doyle writes: > >> The attached gzipped mbox appears to trip up the emacs interface. The >> problem seems to come from the message with id >> CAGNsrLCWv6=36q+q+5Hc_SzgdZ2ergeKkapT7T3xXvim=2cK+A at mail.gmail.com. >> > > I can't reproduce this bug in curren

Re: Bug?: notmuch-search-show-thread shows several threads; only one containing matching messages

2014-01-27 Thread Eric
On Sun, 26 Jan 2014 22:26:04 +0100, Gregor Zattler wrote: > Hi David, > * David Bremner [24. Jan. 2014]: > > Mark Walters writes: > >> I have looked at this and I think this is not notmuch's fault: I think > >> it is a mua doing strange things: > >> > >> One of the mails has an in-reply-to heade

notmuch emacs mode could be friendlier when the user has never run "notmuch setup"

2014-01-27 Thread David Bremner
Daniel Kahn Gillmor writes: > At the very least, the error message could say "please run 'notmuch > setup' from a shell". This is implimented in git commit 1c2f2c960c (with the patch series in this thread), and will be part of notmuch 0.18. So far I only added the assert to notmuch-hello (also

Re: Bug: notmuch new chokes on dangling symlinks and quits

2014-01-27 Thread Eric
On Mon, 27 Jan 2014 02:14:27 +0100, Gregor Zattler wrote: > Hi David, > * David Bremner [26. Jan. 2014]: > > Gregor Zattler writes: > >> I consider this to be a bug. Instead notmuch should simply > >> ignore the symlink. > >> > > > > Since there is a test for specifically this behaviour, I'd h

[PATCH] test: add basic tests for notmuch new --quiet option

2014-01-27 Thread David Bremner
Jani Nikula writes: > This does not cover all the possible paths notmuch new could output > stuff, but it's better than nothing. pushed. really, honest. d

[PATCH] compat: add canonicalize_file_name

2014-01-27 Thread David Bremner
the POSIX 2008 behaviour of realpath is not available everywhere so we provide a simple wrapper function. We use (and provide) the gnu extension canonicalize_file_name to make it cleaner to test for the feature we need; otherwise we have to rely on realpath segfaulting if the second argument is nu

Re: notmuch emacs mode could be friendlier when the user has never run "notmuch setup"

2014-01-27 Thread David Bremner
Daniel Kahn Gillmor writes: > At the very least, the error message could say "please run 'notmuch > setup' from a shell". This is implimented in git commit 1c2f2c960c (with the patch series in this thread), and will be part of notmuch 0.18. So far I only added the assert to notmuch-hello (also

Re: [PATCH] test: add basic tests for notmuch new --quiet option

2014-01-27 Thread David Bremner
Jani Nikula writes: > This does not cover all the possible paths notmuch new could output > stuff, but it's better than nothing. pushed. really, honest. d ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Bug?: notmuch-search-show-thread shows several threads; only one containing matching messages

2014-01-27 Thread Gregor Zattler
Hi David, * David Bremner [26. Jan. 2014]: > Gregor Zattler writes: > >> Today I produced another mbox with the very same command but with >> a now larger email corpus freshly indexed with a fresh notmuch. >> The mbox contains (according to mutt) 507 messages in 34 threads. >> One of them is the

Bug: notmuch new chokes on dangling symlinks and quits

2014-01-27 Thread Gregor Zattler
Hi David, * David Bremner [26. Jan. 2014]: > Gregor Zattler writes: >> I consider this to be a bug. Instead notmuch should simply >> ignore the symlink. >> > > Since there is a test for specifically this behaviour, I'd have to say > it's a design decision you don't agree with, not a bug ;). Ma