I have read most of this series, tested it and run the tests and LGTM +1.
I read the C code fairly carefully, the tests rather less so but they
looked sane, and I didn't really look at patch 9 for building old
databases.
Best wishes
Mark
On Sat, 22 Feb 2014, Jani Nikula wrote:
> Hi all,
In the [new] section, "tags=;" will cause notmuch to create empty tags
that are fairly hard to remove from the command line.
After some help on #bup, here's what I came up with to remove them,
though it assumes that the empty tag "+ " will always be first in dump's
output:
notmuch dump
This might or might not be considered a bug, or at least it might just
be wishlist severity, but in my case, I have
path=/home/rlb/notmuch
and notmuch contained:
/home/rlb/notmuch/.notmuch
/home/rlb/notmuch/Maildir -> /home/Maildir
I arranged things like that so I could easily drop
notmuch-show: For some reason a url got dropped.
notmuch-compact: Probably my synopsis converter misses a case
---
doc/man1/notmuch-compact.rst | 2 +-
doc/man1/notmuch-show.rst| 4 +---
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/doc/man1/notmuch-compact.rst
Many people have docutils installed, but not sphinx. Allow these
people to build the man pages.
---
Makefile | 2 +-
doc/conf.py| 2 +-
doc/rst2man/Makefile | 5 +
doc/rst2man/Makefile.local | 37
This is the output from sphinx-quickstart, massaged a bit, along with
a man and texinfo pages all converted to rst.
---
Makefile | 2 +-
doc/Makefile | 5 +
doc/Makefile.local| 28 +
doc/conf.py | 166
This version includes a complete conversion of the existing manpages.
The conversion uses doclifter + custom python code + pandoc. It is
pretty much fully automated, so I can rebase against changes to the
nroff source if needed.
On the other hand, it is fully automated, so there are bound to be
Austin Clements writes:
> This series fixes several bugs surrounding identity handling in Emacs.
> It was inspired by a problem that bjonnh on IRC had where forwarding
> from an address where the full name matched the mailbox would crash
> `notmuch-mua-new-forward-message'. While it was
David Bremner writes:
> Fix for Debian bug 739556
pushed this
d
On Thu, Feb 20 2014, Austin Clements wrote:
This seris LGTM. I don't know about patch 4 as I have not used
the features (hand-edited From: always...) maybe I should...
Tomi
> This patch rewrites `notmuch-mua-prompt-for-sender' to simply prompt
> for a full identity, where the list of
This uses the recent functionality to show the tag changes in the
search buffer. Currently this is only used to show changes the search
buffer makes itself: i.e., it does not make display any changes
reflecting tagging done by other notmuch-buffers.
---
This is a rewrite of this single patch. When
Patches 2 and 3 look fine +1.
I don't know any Make and haven't really being following the discussion
between Austin and Tomi so can't comment on Patch 1. It all seems to
work well in my testing.
Best wishes
Mark
On Fri, 21 Feb 2014, Tomi Ollila wrote:
> This version file will be as
If notmuch cli & notmuch emacs MUA versions differ, print also the
emacs MUA version string (along with the cli version) to the
minibuffer.
---
emacs/notmuch-hello.el | 15 +--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/emacs/notmuch-hello.el
The notmuch cli program and emacs lisp versions may differ. For now
we can help users with their emacs client problems better if we can
ask what version of emacs MUA they are running. In the future we can
put the emacs MUA version to User-Agent: string in outgoing mail.
---
emacs/Makefile.local |
This version file will be as prerequisite to the target files
that use the version info for some purpose, like printing
it for the user to examine. The contents of the version.stamp
file is seldom read by the build system itself as the $(VERSION)
variable has the same information.
Thanks to
Patches 2 and 3 look fine +1.
I don't know any Make and haven't really being following the discussion
between Austin and Tomi so can't comment on Patch 1. It all seems to
work well in my testing.
Best wishes
Mark
On Fri, 21 Feb 2014, Tomi Ollila tomi.oll...@iki.fi wrote:
This version file
On Thu, Feb 20 2014, Austin Clements amdra...@mit.edu wrote:
This seris LGTM. I don't know about patch 4 as I have not used
the features (hand-edited From: always...) maybe I should...
Tomi
This patch rewrites `notmuch-mua-prompt-for-sender' to simply prompt
for a full identity, where the
This uses the recent functionality to show the tag changes in the
search buffer. Currently this is only used to show changes the search
buffer makes itself: i.e., it does not make display any changes
reflecting tagging done by other notmuch-buffers.
---
This is a rewrite of this single patch. When
This is a more strict test for the insert test.
---
test/T070-insert.sh | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/test/T070-insert.sh b/test/T070-insert.sh
index e8dc4c099ed1..5de5da43cebb 100755
--- a/test/T070-insert.sh
+++ b/test/T070-insert.sh
@@ -126,14
---
man/man7/notmuch-search-terms.7 | 28 ++--
1 file changed, 22 insertions(+), 6 deletions(-)
diff --git a/man/man7/notmuch-search-terms.7 b/man/man7/notmuch-search-terms.7
index a768b630a4d1..907403dd6f2e 100644
--- a/man/man7/notmuch-search-terms.7
+++
Generated using:
$ cd test
$ ../devel/gen-testdb.sh -v 0.17 -c $PWD/corpus/folders -s v1
This database contains old style probabilistic folder: terms and no
path: terms.
---
corpus/database content dropped to save bandwidth, see
---
man/man1/notmuch-search.1 | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/man/man1/notmuch-search.1 b/man/man1/notmuch-search.1
index 55a81e79fce4..a2b1ae43f411 100644
--- a/man/man1/notmuch-search.1
+++ b/man/man1/notmuch-search.1
@@ -82,8 +82,14 @@ one per
In xapian terms, convert folder: prefix from probabilistic to boolean
prefix, matching the paths, relative form the maildir root, of the
message files, ignoring the maildir new and cur leaf directories.
folder:foo matches all message files in foo, foo/new, and foo/cur.
folder:foo/new does *not*
Add script to generate notmuch test databases using specified versions
of notmuch. This is useful for generating material for database
upgrade tests.
This reuses the test infrastructure to have a sandbox environment for
notmuch new etc.
---
devel/gen-testdb.sh | 124
Some of the folder: matching capabilities are lost in the
probabilistic to boolean prefix change. Fix them.
---
test/T100-search-by-folder.sh | 24 +---
1 file changed, 21 insertions(+), 3 deletions(-)
diff --git a/test/T100-search-by-folder.sh b/test/T100-search-by-folder.sh
Abstract some blocks of code for reuse. No functional changes.
---
lib/message.cc | 135 -
1 file changed, 66 insertions(+), 69 deletions(-)
diff --git a/lib/message.cc b/lib/message.cc
index c91f3a59836f..7aff4ae5111a 100644
---
The path: prefix is a literal boolean prefix matching the paths,
relative from the maildir root, of the message files.
path:foo matches all message files in foo (but not in foo/new or
foo/cur).
path:foo/new matches all message files in foo/new.
path: matches all message files in the top level
Additional tests for the boolean folder: and path: prefixes.
---
test/T101-search-by-folder-and-path.sh | 83 ++
1 file changed, 83 insertions(+)
create mode 100755 test/T101-search-by-folder-and-path.sh
diff --git a/test/T101-search-by-folder-and-path.sh
Test the upgrade from probabilistic to boolean folder: terms, and
addition of path: terms.
---
test/T530-upgrade.sh | 103 +++
1 file changed, 103 insertions(+)
create mode 100755 test/T530-upgrade.sh
diff --git a/test/T530-upgrade.sh
Move the existing corpus under corpus/default, and make it possible to
have multiple corpora under the directory.
---
test/.gitignore | 2 +-
test/Makefile.local | 2 +-
test/T480-hex-escaping.sh | 4 ++--
test/corpus/{ = default}/cur/01:2, | 0
---
corpus content dropped to save bandwidth, see
https://gitorious.org/jani/notmuch/commit/3aff18b55de46e3b27748376a59cda41b6cd7f6d
test/corpus/folders/01:2, | 34
test/corpus/folders/02:2, | 32 +++
test/corpus/folders/bar/17:2, | 23 +++
David Bremner da...@tethera.net writes:
Fix for Debian bug 739556
pushed this
d
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch
Austin Clements amdra...@mit.edu writes:
This series fixes several bugs surrounding identity handling in Emacs.
It was inspired by a problem that bjonnh on IRC had where forwarding
from an address where the full name matched the mailbox would crash
`notmuch-mua-new-forward-message'. While it
I have read most of this series, tested it and run the tests and LGTM +1.
I read the C code fairly carefully, the tests rather less so but they
looked sane, and I didn't really look at patch 9 for building old
databases.
Best wishes
Mark
On Sat, 22 Feb 2014, Jani Nikula j...@nikula.org
This version includes a complete conversion of the existing manpages.
The conversion uses doclifter + custom python code + pandoc. It is
pretty much fully automated, so I can rebase against changes to the
nroff source if needed.
On the other hand, it is fully automated, so there are bound to be
notmuch-show: For some reason a url got dropped.
notmuch-compact: Probably my synopsis converter misses a case
---
doc/man1/notmuch-compact.rst | 2 +-
doc/man1/notmuch-show.rst| 4 +---
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/doc/man1/notmuch-compact.rst
Many people have docutils installed, but not sphinx. Allow these
people to build the man pages.
---
Makefile | 2 +-
doc/conf.py| 2 +-
doc/rst2man/Makefile | 5 +
doc/rst2man/Makefile.local | 37
Hi
I was experimenting with letting notmuch new take an argument to tell it
to scan only a particular directory (and sub-directories) for new
messages. I came across the following strange behaviour which is also
present in master (with a fresh database)
I have a bunch of maildirs in /home/mail:
This might or might not be considered a bug, or at least it might just
be wishlist severity, but in my case, I have
path=/home/rlb/notmuch
and notmuch contained:
/home/rlb/notmuch/.notmuch
/home/rlb/notmuch/Maildir - /home/Maildir
I arranged things like that so I could easily drop other
In the [new] section, tags=; will cause notmuch to create empty tags
that are fairly hard to remove from the command line.
After some help on #bup, here's what I came up with to remove them,
though it assumes that the empty tag + will always be first in dump's
output:
notmuch dump
40 matches
Mail list logo
