[PATCH v2 10/10] man: update insert documentation

2014-04-16 Thread Peter Wang
Add documentation for the insert --must-index option and failure exit codes. --- doc/man1/notmuch-insert.rst | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/doc/man1/notmuch-insert.rst b/doc/man1/notmuch-insert.rst index 2be1a7b..02c516b 100644 ---

[PATCH v2 09/10] test: test insert --must-index

2014-04-16 Thread Peter Wang
Test the insert --must-index option. --- test/T070-insert.sh | 28 +--- 1 file changed, 25 insertions(+), 3 deletions(-) diff --git a/test/T070-insert.sh b/test/T070-insert.sh index c576efc..4e289c0 100755 --- a/test/T070-insert.sh +++ b/test/T070-insert.sh @@ -21,11

[PATCH v2 07/10] cli: indicate insert failure mode in exit status

2014-04-16 Thread Peter Wang
Make insert return a different exit code, 2, for failure to write the message file to disk, and exit code 1 for other errors. --- notmuch-insert.c| 30 ++ test/T070-insert.sh | 4 ++-- 2 files changed, 20 insertions(+), 14 deletions(-) diff --git

[PATCH v2 06/10] cli: refactor insert

2014-04-16 Thread Peter Wang
Change insert_message into write_message and move its responsibilities for indexing the message into the main function, to simplify the control flow. --- notmuch-insert.c | 63 +++- 1 file changed, 30 insertions(+), 33 deletions(-) diff --git

[PATCH v2 05/10] ruby: handle return status of database close

2014-04-16 Thread Peter Wang
Throw an exception if notmuch_database_destroy fails. --- bindings/ruby/database.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/bindings/ruby/database.c b/bindings/ruby/database.c index e84f726..c03d701 100644 --- a/bindings/ruby/database.c +++ b/bindings/ruby/database.c

[PATCH v2 04/10] go: add return status to database close method

2014-04-16 Thread Peter Wang
Add return status to the Database.Close() method that calls notmuch_database_destroy. --- bindings/go/src/notmuch/notmuch.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bindings/go/src/notmuch/notmuch.go b/bindings/go/src/notmuch/notmuch.go index 00bd53a..b9230ad

[PATCH v2 03/10] python: handle return status of database close and destroy

2014-04-16 Thread Peter Wang
Throw an exception if notmuch_database_close or notmuch_database_destroy fail. --- bindings/python/notmuch/database.py | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/bindings/python/notmuch/database.py b/bindings/python/notmuch/database.py index 7ddf5cf..5b58e09

[PATCH v2 02/10] lib: bump soname

2014-04-16 Thread Peter Wang
Adding return values to notmuch_database_close and notmuch_database_destroy may require bumping the soname. --- lib/Makefile.local | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/Makefile.local b/lib/Makefile.local index c56cba9..4120390 100644 --- a/lib/Makefile.local +++

[PATCH v2 01/10] lib: add return status to database close and destroy

2014-04-16 Thread Peter Wang
From: Jani Nikula notmuch_database_close may fail in Xapian ->flush() or ->close(), so report the status. Similarly for notmuch_database_destroy which calls close. This is required for notmuch insert to report error status if message indexing failed. --- lib/database.cc | 30

[PATCH v2 00/10] add insert --must-index option

2014-04-16 Thread Peter Wang
Follow up to id:1374365254-13227-1-git-send-email-novalazy at gmail.com The main changes are to take into account failures during tagging and flushing of the database. I took Jani's patch id:1390152046-6509-1-git-send-email-jani at nikula.org without modification. The soname bump is included in

[PATCH 1/1] emacs: hello: bugfix for saved searches defcustom

2014-04-16 Thread Mark Walters
The recent changes for saved searches introduced a bug when notmuch was loaded after the saved search was defined. This was caused by a utility function not being defined when the defcustom was loaded. Fix this by moving some code around: the defcustom is moved into notmuch-hello (which is a more

[PATCH 0/1] emacs: hello: bugfix for saved searches defcustom

2014-04-16 Thread Mark Walters
This is almost the same as id:1397627927-9692-1-git-send-email-markwalters1009 at gmail.com but witha commit message a couple of function renames and a couple of

Emacs Keybindings no longer work after upgrading to 0.17

2014-04-16 Thread Tomi Ollila
On Wed, Apr 16 2014, Neeum Zawaz wrote: > Hi, > > I have this function: > > > (define-key notmuch-search-mode-map "a" > (lambda () > "Archive message." > (interactive) > (notmuch-search-tag "-inbox") > (notmuch-search-tag "-lowpriority") >

[WIP PATCH] emacs: hello: bugfix for saved searches defcustom

2014-04-16 Thread David Bremner
Mark Walters writes: > --- > Hi > > David found a bug in the recent notmuch hello saved searches and > reduced to a small test case. The problem occurs if the user sets > notmuch-saved-searches and then loads notmuch. The reason is that the > defcustom calls some utility functions and these need

[WIP PATCH] emacs: hello: bugfix for saved searches defcustom

2014-04-16 Thread Mark Walters
--- Hi David found a bug in the recent notmuch hello saved searches and reduced to a small test case. The problem occurs if the user sets notmuch-saved-searches and then loads notmuch. The reason is that the defcustom calls some utility functions and these need to be defined (not just declared)

Synchronization success stories?

2014-04-16 Thread Tilmann Singer
: not available Type: application/pgp-signature Size: 489 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20140416/0249247e/attachment.pgp>

Re: Emacs Keybindings no longer work after upgrading to 0.17

2014-04-16 Thread Tomi Ollila
On Wed, Apr 16 2014, Neeum Zawaz mailingli...@nawaz.org wrote: Hi, I have this function: (define-key notmuch-search-mode-map a (lambda () Archive message. (interactive) (notmuch-search-tag -inbox) (notmuch-search-tag -lowpriority)

Re: [WIP PATCH] emacs: hello: bugfix for saved searches defcustom

2014-04-16 Thread David Bremner
Mark Walters markwalters1...@gmail.com writes: --- Hi David found a bug in the recent notmuch hello saved searches and reduced to a small test case. The problem occurs if the user sets notmuch-saved-searches and then loads notmuch. The reason is that the defcustom calls some utility

[PATCH v2 00/10] add insert --must-index option

2014-04-16 Thread Peter Wang
Follow up to id:1374365254-13227-1-git-send-email-noval...@gmail.com The main changes are to take into account failures during tagging and flushing of the database. I took Jani's patch id:1390152046-6509-1-git-send-email-j...@nikula.org without modification. The soname bump is included in case

[PATCH v2 01/10] lib: add return status to database close and destroy

2014-04-16 Thread Peter Wang
From: Jani Nikula j...@nikula.org notmuch_database_close may fail in Xapian -flush() or -close(), so report the status. Similarly for notmuch_database_destroy which calls close. This is required for notmuch insert to report error status if message indexing failed. --- lib/database.cc | 30

[PATCH v2 02/10] lib: bump soname

2014-04-16 Thread Peter Wang
Adding return values to notmuch_database_close and notmuch_database_destroy may require bumping the soname. --- lib/Makefile.local | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/Makefile.local b/lib/Makefile.local index c56cba9..4120390 100644 --- a/lib/Makefile.local +++

[PATCH v2 03/10] python: handle return status of database close and destroy

2014-04-16 Thread Peter Wang
Throw an exception if notmuch_database_close or notmuch_database_destroy fail. --- bindings/python/notmuch/database.py | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/bindings/python/notmuch/database.py b/bindings/python/notmuch/database.py index 7ddf5cf..5b58e09

[PATCH v2 05/10] ruby: handle return status of database close

2014-04-16 Thread Peter Wang
Throw an exception if notmuch_database_destroy fails. --- bindings/ruby/database.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/bindings/ruby/database.c b/bindings/ruby/database.c index e84f726..c03d701 100644 --- a/bindings/ruby/database.c +++ b/bindings/ruby/database.c

[PATCH v2 04/10] go: add return status to database close method

2014-04-16 Thread Peter Wang
Add return status to the Database.Close() method that calls notmuch_database_destroy. --- bindings/go/src/notmuch/notmuch.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bindings/go/src/notmuch/notmuch.go b/bindings/go/src/notmuch/notmuch.go index 00bd53a..b9230ad

[PATCH v2 06/10] cli: refactor insert

2014-04-16 Thread Peter Wang
Change insert_message into write_message and move its responsibilities for indexing the message into the main function, to simplify the control flow. --- notmuch-insert.c | 63 +++- 1 file changed, 30 insertions(+), 33 deletions(-) diff --git

[PATCH v2 08/10] cli: add insert --must-index option

2014-04-16 Thread Peter Wang
This option causes notmuch insert to fail (with exit code 3) on failure to index the message, or failure to set the tags on the message, or if closing (flushing) the database fails. Failure to sync tags to flags has no effect. --- notmuch-insert.c | 57

[PATCH v2 10/10] man: update insert documentation

2014-04-16 Thread Peter Wang
Add documentation for the insert --must-index option and failure exit codes. --- doc/man1/notmuch-insert.rst | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/doc/man1/notmuch-insert.rst b/doc/man1/notmuch-insert.rst index 2be1a7b..02c516b 100644 ---

[PATCH v2 09/10] test: test insert --must-index

2014-04-16 Thread Peter Wang
Test the insert --must-index option. --- test/T070-insert.sh | 28 +--- 1 file changed, 25 insertions(+), 3 deletions(-) diff --git a/test/T070-insert.sh b/test/T070-insert.sh index c576efc..4e289c0 100755 --- a/test/T070-insert.sh +++ b/test/T070-insert.sh @@ -21,11

Re: [PATCH v2] NEWS: Document the recent 'nmbug clone' and @{upstream} changes

2014-04-16 Thread Tomi Ollila
On Wed, Apr 16 2014, W. Trevor King wk...@tremily.us wrote: The changes landed with c200167 (nmbug: Add 'clone' and replace FETCH_HEAD with @{upstream}, 2014-03-09). The preferred markup language for NEWS seems to be Markdown, which is parsed by devel/news2wiki.pl into Markdown chunks for

[PATCH 1/1] emacs: hello: bugfix for saved searches defcustom

2014-04-16 Thread Mark Walters
The recent changes for saved searches introduced a bug when notmuch was loaded after the saved search was defined. This was caused by a utility function not being defined when the defcustom was loaded. Fix this by moving some code around: the defcustom is moved into notmuch-hello (which is a more

[PATCH 0/1] emacs: hello: bugfix for saved searches defcustom

2014-04-16 Thread Mark Walters
This is almost the same as id:1397627927-9692-1-git-send-email-markwalters1...@gmail.com but with a commit message a couple of function renames and a couple of

[PATCH] emacs: search: edit current query

2014-04-16 Thread Mark Walters
This adds an option to edit the current query. It is bound to prefix-key f as it is a sort of inverse operation to filtering. --- rlb asked for the option to modify the existing search query on irc. This implements that for the search view. Best wishes Mark emacs/notmuch.el | 37