[PATCH] build: check .git directory existence in srcdir (for out-of-tree builds)

2014-05-06 Thread Tomi Ollila
So that $(VERSION) and version.stamp uses the git-describe -based version data instead of the content of `version' file. For consistency also the git commands in Makefile[.local] target `verify-no-dirty-code' uses the git --git-dir=$srcdir/.git ... commands (inside ifeq($(IS_GIT),yes)).

[PATCH 4/5] T360-symbol-hiding: Added code to support testing on Mac OS X.

2014-05-06 Thread Tomi Ollila
On Tue, May 06 2014, Charles Celerier wrote: > Tomi Ollila writes: > >> On Tue, May 06 2014, Charles Celerier wrote: >> >>> The Mac OS X platform uses *.dylib object files instead of *.so object >>> files for linking. Adding the path to notmuch.dylib to the end of >>>

[PATCH 2/2] test: redirect gdb output to a file.

2014-05-06 Thread David Bremner
It seems that the normal output redirection in the test suite doesn't work for gdb, but it's nice to have output in a file for debugging. --- test/T380-atomicity.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/T380-atomicity.sh b/test/T380-atomicity.sh index

[PATCH 1/2] test: allow pending break points in atomicity script.

2014-05-06 Thread David Bremner
This seems to fix problems with the symbol rename not being defined at startup on at least OS/X and some Debian Linux architectures. --- test/atomicity.gdb | 4 1 file changed, 4 insertions(+) diff --git a/test/atomicity.gdb b/test/atomicity.gdb index fd67525..15adb16 100644 ---

No subject

2014-05-06 Thread David Bremner
The first of these fixes a build failure on Debian Linux/armhf (and OS/X). If the patch seems ok, I'd like to roll it into a bug fix release. The second is more of a suggestion to make that atomicity test easier to debug, since it seems to find the dark corners of gdb.

[PATCH] emacs: Correct the documentation for `notmuch-search-line-faces'.

2014-05-06 Thread Tomi Ollila
On Tue, May 06 2014, David Edmondson wrote: > The implementation and documentation for `notmuch-search-line-faces' > disagreed in how elements in the list were merged. Correct the > documentation to match the implementation (that is, the earlier > elements in the list have precedence over later

[no subject]

2014-05-06 Thread Tomi Ollila
On Tue, May 06 2014, David Bremner wrote: > The first of these fixes a build failure on Debian Linux/armhf (and > OS/X). If the patch seems ok, I'd like to roll it into a bug fix > release. The second is more of a suggestion to make that atomicity > test easier to debug, since it seems to find

[PATCH 3/5] atomicity.gdb: Allow breakpoint symbols to be resolved later.

2014-05-06 Thread Tomi Ollila
On Tue, May 06 2014, Charles Celerier wrote: > On the Mac OS X platform, the rename() function symbol is not found > until the debugger begins running. The reason for this is unknown, but > allowing breakpoint symbols to be resolved later both solves the problem > and does not change the test. >

[PATCH 4/5] T360-symbol-hiding: Added code to support testing on Mac OS X.

2014-05-06 Thread Tomi Ollila
On Tue, May 06 2014, Charles Celerier wrote: > The Mac OS X platform uses *.dylib object files instead of *.so object > files for linking. Adding the path to notmuch.dylib to the end of > DYLD_FALLBACK_LIBRARY_PATH has a similar effect to adding the path to > notmuch.so to LD_LIBRARY_PATH on

[PATCH] emacs: Correct the documentation for `notmuch-search-line-faces'.

2014-05-06 Thread Mark Walters
LGTM too +1 Mark On Tue, 06 May 2014, Tomi Ollila wrote: > On Tue, May 06 2014, David Edmondson wrote: > >> The implementation and documentation for `notmuch-search-line-faces' >> disagreed in how elements in the list were merged. Correct the >> documentation to match the implementation (that

[PATCH] emacs: hello: allow arbitrary lisp for generating the count.

2014-05-06 Thread Mark Walters
This allows a function to be given for the count-query of a saved search. The function will be called with the query plist as an argument to generate the count shown and should return either a string or a number to be displayed as the count. If this option is a function then its query will not be

[RFC] [PATCH] emacs: Add support for saved search accelerators.

2014-05-06 Thread Mark Walters
Hi Yes this looks nice modulo polishing. I think the nifty window-splitting Austin's notmuch-go does is moderately orthogonal to the keyboard shortcuts (since shortcuts can be used without it, and it could be used for other things too) On Tue, 06 May 2014, David Edmondson wrote: > Extended the

notmuch release 0.18 now available

2014-05-06 Thread David Bremner
ut notmuch, see http://notmuchmail.org -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 647 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20140506/af9ab4b9/attachment.pgp>

Improving spam-tagging keybinding function to act on region in emacs

2014-05-06 Thread Mark Walters
Hello As this section was rather outdated I have updated to modern notmuch. (In fact the lisp snippets should work back to at least 0.13) On Tue, 06 May 2014, Olivier Berger wrote: > Hi. > > I've tried tu use the tips indicated at > http://notmuchmail.org/emacstips/#index8h2 so as to add a

[RFC] [PATCH] emacs: Add support for saved search accelerators.

2014-05-06 Thread David Edmondson
Extended the saved search definition to allow the inclusion of an accelerator key for the search. Bind 'j' in the common mode map as a leader for such accelerator keys. --- This arose out a conversation in #notmuch and Mark's patch to extend the saved search custom specification based on

[PATCH] lib: Precede all function names in notmuch-private.h with an underscore.

2014-05-06 Thread Charles Celerier
An underscore should precede every function name in lib/notmuch-private.h. This was not true and was noted by the failure of test T360-symbol-hiding on Mac OS/X. This patch inserts an underscore before each function name in lib/notmuch-private.h where the underscore was missing and renames

[PATCH 4/5] T360-symbol-hiding: Added code to support testing on Mac OS X.

2014-05-06 Thread Charles Celerier
notmuch/xapian' >> -- >> 1.8.5.2 (Apple Git-48) >> >> ___ >> notmuch mailing list >> notmuch at notmuchmail.org >> http://notmuchmail.org/mailman/listinfo/notmuch -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 840 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20140506/84a39a84/attachment.pgp>

Improving spam-tagging keybinding function to act on region in emacs

2014-05-06 Thread Olivier Berger
Hi. I've tried tu use the tips indicated at http://notmuchmail.org/emacstips/#index8h2 so as to add a keybinding to tag spam messages, and wonder if there's a possibility to make it apply on selected regions, like what notmuch-search-archive-thread does. I can achieve the same result using a

[PATCH 5/5] T360-symbol-hiding: Use nm instead of objdump.

2014-05-06 Thread Charles Celerier
The output of `objdump -t` depends on the format of the object files which are different across platforms (e.g. Mac OS X). Since we really just want to filter the symbols in the object file, nm is a more appropriate tool since it only lists symbols from object files (nm(1)) and has a consistent

[PATCH 3/5] atomicity.gdb: Allow breakpoint symbols to be resolved later.

2014-05-06 Thread Charles Celerier
On the Mac OS X platform, the rename() function symbol is not found until the debugger begins running. The reason for this is unknown, but allowing breakpoint symbols to be resolved later both solves the problem and does not change the test. Signed-off-by: Charles Celerier ---

[PATCH 2/5] configure, test: Added variables for paths to true and false.

2014-05-06 Thread Charles Celerier
The path to true may not be the same on all platforms (e.g. on Mac OS X it is /usr/bin/true), so the hard-coded path of /bin/true is not portable. This is resolved by adding a step to the configure script to locate the path of true and to use the TRUE variable wherever /bin/true was needed. The

[PATCH 1/5] test/Makefile.local: Added configured TALLOC_LDFLAGS.

2014-05-06 Thread Charles Celerier
The linking to talloc is hard-coded in the testing Makefile. This patch causes the linking to talloc to be done according to how TALLOC_LDFLAGS was configured. Signed-off-by: Charles Celerier --- test/Makefile.local | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 0/5] Improving portability to Mac OS X

2014-05-06 Thread Charles Celerier
The patches in this series include a number of minor changes intended to better support the portability of notmuch to Mac OS X. The changes are relatively non-intrusive. You may observe that these patches apply entirely to the notmuch tests; it turns out, with the exception of the tests, notmuch

Linux-only fdatasync() in 3c13bc

2014-05-06 Thread Xīcò
Size: 2827 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20140506/6ef37585/attachment.patch>

pkg-config zlib check in 3c13bc

2014-05-06 Thread Xīcò
-for-zlib-version.patch Type: text/x-diff Size: 4774 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20140506/a8e94213/attachment.patch>

Notmuch-tree add/remove/toggle tag

2014-05-06 Thread 'Mash
Quoting Mark Walters : > 'Mash writes: > >> I am trying to setup a tag toggle to be used in the Notmuch-tree. >> >> I referred to "Add a key binding to add/remove/toggle a tag": >> http://notmuchmail.org/emacstips/#index8h2 >> >> Looking at "notmuch-tree.el" I noticed >> >> (defun

Notmuch-tree add/remove/toggle tag

2014-05-06 Thread 'Mash
I am trying to setup a tag toggle to be used in the Notmuch-tree. I referred to "Add a key binding to add/remove/toggle a tag": http://notmuchmail.org/emacstips/#index8h2 Looking at "notmuch-tree.el" I noticed (defun notmuch-tree-get-tags () "Return the tags of the current message."

[PATCH] emacs: Correct the documentation for `notmuch-search-line-faces'.

2014-05-06 Thread David Edmondson
nts/20140506/2d1a9e6c/attachment-0001.pgp>

[PATCH] emacs: Correct the documentation for `notmuch-search-line-faces'.

2014-05-06 Thread David Edmondson
The implementation and documentation for `notmuch-search-line-faces' disagreed in how elements in the list were merged. Correct the documentation to match the implementation (that is, the earlier elements in the list have precedence over later elements). --- emacs/notmuch.el | 10 +- 1

[PATCH] emacs: Correct the documentation for `notmuch-search-line-faces'.

2014-05-06 Thread David Edmondson
The implementation and documentation for `notmuch-search-line-faces' disagreed in how elements in the list were merged. Correct the documentation to match the implementation (that is, the earlier elements in the list have precedence over later elements). --- emacs/notmuch.el | 10 +- 1

precedence in `notmuch-search-line-faces'

2014-05-06 Thread David Edmondson
more general later. That makes sense. Patch follows. -- next part -- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 310 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20140506/ede9ce48/attachment.pgp>

[PATCH] emacs: put current query as default value in notmuch-read-query

2014-05-06 Thread David Edmondson
gt; > What do you think? This is nicer than the current patch. -- next part -- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 310 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20140506/57bcc05a/attachment-0001.pgp>

folder and path completely broken in HEAD?

2014-05-06 Thread Mark Walters
On Mon, 05 May 2014, Jani Nikula wrote: > Hi Carl - > > On Tue, 06 May 2014, Carl Worth wrote: >> dm-list-email-notmuch at scs.stanford.edu writes: >>> However, currently it seems strange that there are *two* different >>> search terms (folder and path), and that neither one lets you search for

[PATCH] emacs: put current query as default value in notmuch-read-query

2014-05-06 Thread Mark Walters
Hi On Tue, 06 May 2014, David Edmondson wrote: > On Sat, May 03 2014, Mark Walters wrote: >> An alternative to putting the logic in notmuch-read-query would be to >> store the query in a consistently named buffer local variable in all >> the modes. If we want to show the actually run query in

[PATCH] emacs: put current query as default value in notmuch-read-query

2014-05-06 Thread David Edmondson
vailable URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20140506/d5014b57/attachment.pgp>

folder and path completely broken in HEAD?

2014-05-06 Thread Jani Nikula
Hi Carl - On Tue, 06 May 2014, Carl Worth wrote: > dm-list-email-notmuch at scs.stanford.edu writes: >> However, currently it seems strange that there are *two* different >> search terms (folder and path), and that neither one lets you search for >> a portion of your folder name. > > For what

Re: [PATCH] emacs: put current query as default value in notmuch-read-query

2014-05-06 Thread David Edmondson
On Sat, May 03 2014, Mark Walters wrote: An alternative to putting the logic in notmuch-read-query would be to store the query in a consistently named buffer local variable in all the modes. If we want to show the actually run query in notmuch-show above then this is probably the neatest

Re: [PATCH] emacs: put current query as default value in notmuch-read-query

2014-05-06 Thread Mark Walters
Hi On Tue, 06 May 2014, David Edmondson d...@dme.org wrote: On Sat, May 03 2014, Mark Walters wrote: An alternative to putting the logic in notmuch-read-query would be to store the query in a consistently named buffer local variable in all the modes. If we want to show the actually run query

Re: folder and path completely broken in HEAD?

2014-05-06 Thread Mark Walters
On Mon, 05 May 2014, Jani Nikula j...@nikula.org wrote: Hi Carl - On Tue, 06 May 2014, Carl Worth cwo...@cworth.org wrote: dm-list-email-notm...@scs.stanford.edu writes: However, currently it seems strange that there are *two* different search terms (folder and path), and that neither one

notmuch release 0.18 now available

2014-05-06 Thread David Bremner
Where to obtain notmuch 0.18 === http://notmuchmail.org/releases/notmuch-0.18.tar.gz Which can be verified with: http://notmuchmail.org/releases/notmuch-0.18.tar.gz.sha1 bfbcdc340c4b0d544904b3a8ba70be4e819859d9 notmuch-0.18.tar.gz

Re: precedence in `notmuch-search-line-faces'

2014-05-06 Thread David Edmondson
On Sun, May 04 2014, Mark Walters wrote: I have a slight preference for making it do the comment (ie reverse the list). My reason is that we have some other cases such as notmuch-tag-format that apply the first match, so users might be used to having the specific first and the more general

Re: [PATCH] emacs: Correct the documentation for `notmuch-search-line-faces'.

2014-05-06 Thread David Edmondson
Sorry for the duplicates - MTA troubles. The two versions are the same. signature.asc Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Notmuch-tree add/remove/toggle tag

2014-05-06 Thread 'Mash
I am trying to setup a tag toggle to be used in the Notmuch-tree. I referred to Add a key binding to add/remove/toggle a tag: http://notmuchmail.org/emacstips/#index8h2 Looking at notmuch-tree.el I noticed (defun notmuch-tree-get-tags () Return the tags of the current message.

Re: Notmuch-tree add/remove/toggle tag

2014-05-06 Thread Mark Walters
'Mash subscr...@toshine.net writes: I am trying to setup a tag toggle to be used in the Notmuch-tree. I referred to Add a key binding to add/remove/toggle a tag: http://notmuchmail.org/emacstips/#index8h2 Looking at notmuch-tree.el I noticed (defun notmuch-tree-get-tags () Return

Re: Notmuch-tree add/remove/toggle tag

2014-05-06 Thread 'Mash
Quoting Mark Walters markwalters1...@gmail.com: 'Mash subscr...@toshine.net writes: I am trying to setup a tag toggle to be used in the Notmuch-tree. I referred to Add a key binding to add/remove/toggle a tag: http://notmuchmail.org/emacstips/#index8h2 Looking at notmuch-tree.el I noticed

Improving spam-tagging keybinding function to act on region in emacs

2014-05-06 Thread Olivier Berger
Hi. I've tried tu use the tips indicated at http://notmuchmail.org/emacstips/#index8h2 so as to add a keybinding to tag spam messages, and wonder if there's a possibility to make it apply on selected regions, like what notmuch-search-archive-thread does. I can achieve the same result using a

[no subject]

2014-05-06 Thread David Bremner
The first of these fixes a build failure on Debian Linux/armhf (and OS/X). If the patch seems ok, I'd like to roll it into a bug fix release. The second is more of a suggestion to make that atomicity test easier to debug, since it seems to find the dark corners of gdb.

[PATCH 1/2] test: allow pending break points in atomicity script.

2014-05-06 Thread David Bremner
This seems to fix problems with the symbol rename not being defined at startup on at least OS/X and some Debian Linux architectures. --- test/atomicity.gdb | 4 1 file changed, 4 insertions(+) diff --git a/test/atomicity.gdb b/test/atomicity.gdb index fd67525..15adb16 100644 ---

[RFC] [PATCH] emacs: Add support for saved search accelerators.

2014-05-06 Thread David Edmondson
Extended the saved search definition to allow the inclusion of an accelerator key for the search. Bind 'j' in the common mode map as a leader for such accelerator keys. --- This arose out a conversation in #notmuch and Mark's patch to extend the saved search custom specification based on

Re: Improving spam-tagging keybinding function to act on region in emacs

2014-05-06 Thread Mark Walters
Hello As this section was rather outdated I have updated to modern notmuch. (In fact the lisp snippets should work back to at least 0.13) On Tue, 06 May 2014, Olivier Berger olivier.ber...@telecom-sudparis.eu wrote: Hi. I've tried tu use the tips indicated at

Re: [RFC] [PATCH] emacs: Add support for saved search accelerators.

2014-05-06 Thread Mark Walters
Hi Yes this looks nice modulo polishing. I think the nifty window-splitting Austin's notmuch-go does is moderately orthogonal to the keyboard shortcuts (since shortcuts can be used without it, and it could be used for other things too) On Tue, 06 May 2014, David Edmondson d...@dme.org wrote:

[PATCH 1/5] test/Makefile.local: Added configured TALLOC_LDFLAGS.

2014-05-06 Thread Charles Celerier
The linking to talloc is hard-coded in the testing Makefile. This patch causes the linking to talloc to be done according to how TALLOC_LDFLAGS was configured. Signed-off-by: Charles Celerier ccel...@cs.stanford.edu --- test/Makefile.local | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 4/5] T360-symbol-hiding: Added code to support testing on Mac OS X.

2014-05-06 Thread Charles Celerier
The Mac OS X platform uses *.dylib object files instead of *.so object files for linking. Adding the path to notmuch.dylib to the end of DYLD_FALLBACK_LIBRARY_PATH has a similar effect to adding the path to notmuch.so to LD_LIBRARY_PATH on most Linux-based platforms (see dyld(1)). Signed-off-by:

[PATCH 5/5] T360-symbol-hiding: Use nm instead of objdump.

2014-05-06 Thread Charles Celerier
The output of `objdump -t` depends on the format of the object files which are different across platforms (e.g. Mac OS X). Since we really just want to filter the symbols in the object file, nm is a more appropriate tool since it only lists symbols from object files (nm(1)) and has a consistent

[PATCH 2/5] configure, test: Added variables for paths to true and false.

2014-05-06 Thread Charles Celerier
The path to true may not be the same on all platforms (e.g. on Mac OS X it is /usr/bin/true), so the hard-coded path of /bin/true is not portable. This is resolved by adding a step to the configure script to locate the path of true and to use the TRUE variable wherever /bin/true was needed. The

[PATCH 3/5] atomicity.gdb: Allow breakpoint symbols to be resolved later.

2014-05-06 Thread Charles Celerier
On the Mac OS X platform, the rename() function symbol is not found until the debugger begins running. The reason for this is unknown, but allowing breakpoint symbols to be resolved later both solves the problem and does not change the test. Signed-off-by: Charles Celerier ccel...@cs.stanford.edu

Re:

2014-05-06 Thread Jameson Graef Rollins
On Tue, May 06 2014, David Bremner da...@tethera.net wrote: The first of these fixes a build failure on Debian Linux/armhf (and OS/X). If the patch seems ok, I'd like to roll it into a bug fix release. The second is more of a suggestion to make that atomicity test easier to debug, since it

Re: [PATCH 4/5] T360-symbol-hiding: Added code to support testing on Mac OS X.

2014-05-06 Thread Tomi Ollila
On Tue, May 06 2014, Charles Celerier ccel...@cs.stanford.edu wrote: The Mac OS X platform uses *.dylib object files instead of *.so object files for linking. Adding the path to notmuch.dylib to the end of DYLD_FALLBACK_LIBRARY_PATH has a similar effect to adding the path to notmuch.so to

Re: [PATCH 3/5] atomicity.gdb: Allow breakpoint symbols to be resolved later.

2014-05-06 Thread Tomi Ollila
On Tue, May 06 2014, Charles Celerier ccel...@cs.stanford.edu wrote: On the Mac OS X platform, the rename() function symbol is not found until the debugger begins running. The reason for this is unknown, but allowing breakpoint symbols to be resolved later both solves the problem and does not

Re:

2014-05-06 Thread Tomi Ollila
On Tue, May 06 2014, David Bremner da...@tethera.net wrote: The first of these fixes a build failure on Debian Linux/armhf (and OS/X). If the patch seems ok, I'd like to roll it into a bug fix release. The second is more of a suggestion to make that atomicity test easier to debug, since it

[PATCH] emacs: hello: allow arbitrary lisp for generating the count.

2014-05-06 Thread Mark Walters
This allows a function to be given for the count-query of a saved search. The function will be called with the query plist as an argument to generate the count shown and should return either a string or a number to be displayed as the count. If this option is a function then its query will not be

Re: [PATCH 4/5] T360-symbol-hiding: Added code to support testing on Mac OS X.

2014-05-06 Thread Charles Celerier
Tomi Ollila tomi.oll...@iki.fi writes: On Tue, May 06 2014, Charles Celerier ccel...@cs.stanford.edu wrote: The Mac OS X platform uses *.dylib object files instead of *.so object files for linking. Adding the path to notmuch.dylib to the end of DYLD_FALLBACK_LIBRARY_PATH has a similar effect

[PATCH] lib: Precede all function names in notmuch-private.h with an underscore.

2014-05-06 Thread Charles Celerier
An underscore should precede every function name in lib/notmuch-private.h. This was not true and was noted by the failure of test T360-symbol-hiding on Mac OS/X. This patch inserts an underscore before each function name in lib/notmuch-private.h where the underscore was missing and renames

Re: [PATCH 4/5] T360-symbol-hiding: Added code to support testing on Mac OS X.

2014-05-06 Thread Tomi Ollila
On Tue, May 06 2014, Charles Celerier ccel...@cs.stanford.edu wrote: Tomi Ollila tomi.oll...@iki.fi writes: On Tue, May 06 2014, Charles Celerier ccel...@cs.stanford.edu wrote: The Mac OS X platform uses *.dylib object files instead of *.so object files for linking. Adding the path to

[PATCH] build: check .git directory existence in srcdir (for out-of-tree builds)

2014-05-06 Thread Tomi Ollila
So that $(VERSION) and version.stamp uses the git-describe -based version data instead of the content of `version' file. For consistency also the git commands in Makefile[.local] target `verify-no-dirty-code' uses the git --git-dir=$srcdir/.git ... commands (inside ifeq($(IS_GIT),yes)).

pkg-config zlib check in 3c13bc

2014-05-06 Thread Xīcò
Dear notmuch, Although notmuch was configuring fine on FreeBSD before 3c13bc, the pkg-config check introduced for zlib does not work. Indeed, zlib is part of the base system, and always assumed to be present. Proposed patch puts platform test before pkg-config checks, and add a special case for

Linux-only fdatasync() in 3c13bc

2014-05-06 Thread Xīcò
Also, commit 3c13bc introduced a call to fdatasync() which is not available on FreeBSD, and probably not either on MacOS at least. Best, -- Xīcò From e2b9520e69e52b35348d07eb53a6a88d1397fa3f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?X=C4=ABc=C3=B2?= x...@atelo.org Date: Tue, 6 May 2014 12:56:03

Re: pkg-config zlib check in 3c13bc

2014-05-06 Thread Tomi Ollila
On Tue, May 06 2014, Xīcò x...@atelo.org wrote: Dear notmuch, Although notmuch was configuring fine on FreeBSD before 3c13bc, the pkg-config check introduced for zlib does not work. Indeed, zlib is part of the base system, and always assumed to be present. Proposed patch puts platform test

Re: [PATCH v2 00/10] add insert --must-index option

2014-05-06 Thread Tomi Ollila
On Wed, Apr 16 2014, Peter Wang noval...@gmail.com wrote: Follow up to id:1374365254-13227-1-git-send-email-noval...@gmail.com The main changes are to take into account failures during tagging and flushing of the database. I took Jani's patch

[PATCH v2 5/5] T360-symbol-hiding: Use nm instead of objdump.

2014-05-06 Thread Charles Celerier
The output of `objdump -t` depends on the format of the object files which are different across platforms (e.g. Mac OS X). Since we really just want to filter the symbols in the object file, nm is a more appropriate tool since it only lists symbols from object files (nm(1)) and has a consistent

[PATCH v2 4/5] T360-symbol-hiding: Added code to support testing on Mac OS X.

2014-05-06 Thread Charles Celerier
The Mac OS X platform uses *.dylib object files instead of *.so object files for linking. Adding the path to notmuch.dylib to the end of DYLD_FALLBACK_LIBRARY_PATH has a similar effect to adding the path to notmuch.so to LD_LIBRARY_PATH on most Linux-based platforms (see dyld(1)). Signed-off-by:

Re: [PATCH] emacs: hello: allow arbitrary lisp for generating the count.

2014-05-06 Thread David Edmondson
Looks good, two nits: On Tue, May 06 2014, Mark Walters markwalters1...@gmail.com wrote: This allows a function to be given for the count-query of a saved search. The function will be called with the query plist as an argument to generate the count shown and should return either a string or a