[PATCH v2 5/5] T360-symbol-hiding: Use nm instead of objdump.

2014-05-10 Thread David Bremner
Charles Celerier writes: > David Bremner writes: > > $ nm --version > GNU nm (GNU Binutils) 2.24 > Copyright 2013 Free Software Foundation, Inc. > This program is free software; you may redistribute it under the terms of > the GNU General Public License version 3 or (at your

[PATCH] Fallback check for zlib.

2014-05-10 Thread David Bremner
X?c? writes: > --- > compat/have_zlib.c | 6 ++ > configure | 21 - > 2 files changed, 22 insertions(+), 5 deletions(-) > create mode 100644 compat/have_zlib.c If you're doing a second version for Tomi's comments, please put roughly the comments from the cover

[PATCH] ruby: Add wrapper for notmuch_query_count_threads

2014-05-10 Thread Felipe Contreras
Wael M. Nasreddine wrote: > --- > bindings/ruby/defs.h | 3 +++ > bindings/ruby/init.c | 1 + > bindings/ruby/query.c | 19 +++ > 3 files changed, 23 insertions(+) LGTM. -- Felipe Contreras

[PATCH] ruby: Add wrapper for notmuch_query_count_threads

2014-05-10 Thread Felipe Contreras
Wael M. Nasreddine wrote: > This patch exposes query.cc::notmuch_query_count_threads to Ruby, the > benchmark on 85k emails is amazing: I meant to do this but forgot. Thanks! -- Felipe Contreras

[PATCH 1/2] configure: add a fallback check for zlib

2014-05-10 Thread Felipe Contreras
Tomi Ollila wrote: > On Sun, May 11 2014, Felipe Contreras wrote: > > > X?c? wrote: > >> Since zlib is part of the base system, FreeBSD chose not to register it > >> in pkg-config through zlib.pc. As a fallback test, configure will build > >> and run a zlib version check and make sure the header

[PATCH v2] emacs: Add support for saved search accelerators

2014-05-10 Thread Aaron Ecay
Hello, 2014ko maiatzak 8an, Mark Walters-ek idatzi zuen: > > Hi > > This version looks good to me. > > The only slight query I have is which key to bind it to: Austin used g > in notmuch-go and this uses j. Austin said on irc that he chose g > because it wasn't bound and matched gmail's shortcut.

[PATCH 1/2] configure: add a fallback check for zlib

2014-05-10 Thread Felipe Contreras
X?c? wrote: > Since zlib is part of the base system, FreeBSD chose not to register it > in pkg-config through zlib.pc. As a fallback test, configure will build > and run a zlib version check and make sure the header and library > versions are compatible. We could try to generate our on zlib.pc, th

[PATCH] nmbug-status: Make the footer's gray

2014-05-10 Thread W. Trevor King
So it's less agressive. IE uses 'color' for drawing the rule, while Gecko and Opera use the border or 'background-color' [1]. [1]: https://bugzilla.mozilla.org/show_bug.cgi?id=239386 --- On Sun, May 11, 2014 at 12:08:10AM +0300, Tomi Ollila wrote: > The rendered irritates me a bit, though. Maybe

[PATCH] nmbug-status: Make the footer's gray

2014-05-10 Thread W. Trevor King
So it's less agressive. IE uses 'color' for drawing the rule, while Gecko and Opera use the border or 'background-color' [1]. [1]: https://bugzilla.mozilla.org/show_bug.cgi?id=239386 --- On Sun, May 11, 2014 at 12:08:10AM +0300, Tomi Ollila wrote: > The rendered irritates me a bit, though. Maybe

RE: [PATCH] ruby: Add wrapper for notmuch_query_count_threads

2014-05-10 Thread Felipe Contreras
Wael M. Nasreddine wrote: > --- > bindings/ruby/defs.h | 3 +++ > bindings/ruby/init.c | 1 + > bindings/ruby/query.c | 19 +++ > 3 files changed, 23 insertions(+) LGTM. -- Felipe Contreras ___ notmuch mailing list notmuch@notmuchm

RE: [PATCH] ruby: Add wrapper for notmuch_query_count_threads

2014-05-10 Thread Felipe Contreras
Wael M. Nasreddine wrote: > This patch exposes query.cc::notmuch_query_count_threads to Ruby, the > benchmark on 85k emails is amazing: I meant to do this but forgot. Thanks! -- Felipe Contreras ___ notmuch mailing list notmuch@notmuchmail.org http://n

RE: [PATCH 1/2] configure: add a fallback check for zlib

2014-05-10 Thread Felipe Contreras
Tomi Ollila wrote: > On Sun, May 11 2014, Felipe Contreras wrote: > > > Xīcò wrote: > >> Since zlib is part of the base system, FreeBSD chose not to register it > >> in pkg-config through zlib.pc. As a fallback test, configure will build > >> and run a zlib version check and make sure the header

RE: [PATCH 1/2] configure: add a fallback check for zlib

2014-05-10 Thread Tomi Ollila
On Sun, May 11 2014, Felipe Contreras wrote: > Xīcò wrote: >> Since zlib is part of the base system, FreeBSD chose not to register it >> in pkg-config through zlib.pc. As a fallback test, configure will build >> and run a zlib version check and make sure the header and library >> versions are com

[PATCH] ruby: Add wrapper for notmuch_query_count_threads

2014-05-10 Thread Wael M. Nasreddine
This patch exposes query.cc::notmuch_query_count_threads to Ruby, the benchmark on 85k emails is amazing: user system totalreal query.count_threads 6.27 0.24 6.51 ( 6.507064) query.search_threads.count 14.04 3.13

[PATCH] ruby: Add wrapper for notmuch_query_count_threads

2014-05-10 Thread Wael M. Nasreddine
--- bindings/ruby/defs.h | 3 +++ bindings/ruby/init.c | 1 + bindings/ruby/query.c | 19 +++ 3 files changed, 23 insertions(+) diff --git a/bindings/ruby/defs.h b/bindings/ruby/defs.h index 5b44585..f4901a0 100644 --- a/bindings/ruby/defs.h +++ b/bindings/ruby/defs.h @@ -231,

[PATCH] ruby: Add wrapper for notmuch_query_count_threads

2014-05-10 Thread Wael M. Nasreddine
--- bindings/ruby/defs.h | 3 +++ bindings/ruby/init.c | 1 + bindings/ruby/query.c | 19 +++ 3 files changed, 23 insertions(+) diff --git a/bindings/ruby/defs.h b/bindings/ruby/defs.h index 5b44585..f4901a0 100644 --- a/bindings/ruby/defs.h +++ b/bindings/ruby/defs.h @@ -231,

[PATCH] ruby: Add wrapper for notmuch_query_count_threads

2014-05-10 Thread Wael M. Nasreddine
This patch exposes query.cc::notmuch_query_count_threads to Ruby, the benchmark on 85k emails is amazing: user system totalreal query.count_threads 6.27 0.24 6.51 ( 6.507064) query.search_threads.count 14.04 3.13

[PATCH] emacs install: make sure all components to be installed are there

2014-05-10 Thread Tomi Ollila
`make install-emacs` will copy $(emacs_sources), $(emacs_images) and $(emacs_bytecode) to their target directories. $(emacs_bytecode) was already a prerequisite of make install-emacs as these obviously needed to be build. Until a while ago all of $(emacs_sources) was available in the repository, bu

RE: [PATCH 1/2] configure: add a fallback check for zlib

2014-05-10 Thread Felipe Contreras
Xīcò wrote: > Since zlib is part of the base system, FreeBSD chose not to register it > in pkg-config through zlib.pc. As a fallback test, configure will build > and run a zlib version check and make sure the header and library > versions are compatible. We could try to generate our on zlib.pc, th

Re: [PATCH 0/5] nmbug-status fixups from notmuch-to-html

2014-05-10 Thread Tomi Ollila
On Sat, May 10 2014, "W. Trevor King" wrote: > I've cherry-picked the three patches I liked from Carl's master [1,2] > and added two cleanup commits of my own. I've left Carl's commit > messages unchanged. I'm fine squashing my fixups into Carl's > originals (leaving Carl as the author) if that

Re: [PATCH v2] emacs: Add support for saved search accelerators

2014-05-10 Thread Aaron Ecay
Hello, 2014ko maiatzak 8an, Mark Walters-ek idatzi zuen: > > Hi > > This version looks good to me. > > The only slight query I have is which key to bind it to: Austin used g > in notmuch-go and this uses j. Austin said on irc that he chose g > because it wasn't bound and matched gmail's shortcut.

Bug: make install depends on emacs being detected during configure in 0.18

2014-05-10 Thread Benjamin Podszun
Hi. As discussed on IRC, mostly to archive the issue here as well: 0.18 fails during make install if emacs is missing, due to a missing emacs/notmuch-version.el file (which is generated from a template, but not if you don't _have_ emacs). Full build log below, please ignore the nix specific stuff

[PATCH] Fallback check for zlib.

2014-05-10 Thread Tomi Ollila
On Sat, May 10 2014, David Bremner wrote: > X?c? writes: > >> --- >> compat/have_zlib.c | 6 ++ >> configure | 21 - >> 2 files changed, 22 insertions(+), 5 deletions(-) >> create mode 100644 compat/have_zlib.c > > If you're doing a second version for Tomi's c

[PATCH 1/2] configure: add a fallback check for zlib

2014-05-10 Thread Xīcò
Since zlib is part of the base system, FreeBSD chose not to register it in pkg-config through zlib.pc. As a fallback test, configure will build and run a zlib version check and make sure the header and library versions are compatible. --- compat/have_zlib.c | 6 ++ configure | 21 +++

[PATCH 1/2] configure: add a fallback check for zlib

2014-05-10 Thread Xīcò
Since zlib is part of the base system, FreeBSD chose not to register it in pkg-config through zlib.pc. As a fallback test, configure will build and run a zlib version check and make sure the header and library versions are compatible. --- compat/have_zlib.c | 6 ++ configure | 21 +++

[PATCH 0/2] nmbug-config errors for illegible configs

2014-05-10 Thread W. Trevor King
More accessible errors and consistent config loading inspired by Carl's report of the unhelpful 'No JSON object' traceback [1]. Cheers, Trevor [1]: id:87wqegr3dm@yoom.home.cworth.org http://article.gmane.org/gmane.mail.notmuch.general/17995 W. Trevor King (2): nmbug-status: Clarify er

[PATCH 2/2] nmbug-status: Use 'show-ref --heads' for loading configs

2014-05-10 Thread W. Trevor King
When loading configs from Git, the bare branch name (without a refs/heads/ prefix or similar) matches all branches of that name (including remote-tracking branches): .nmbug $ git show-ref config 48f3bbf1d1492e5f3d2f01de6ea79a30d3840f20 refs/heads/config 48f3bbf1d1492e5f3d2f01de6ea79a30d3840f

[PATCH 1/2] nmbug-status: Clarify errors for illegible configs

2014-05-10 Thread W. Trevor King
Carl Worth pointed out that errors like: $ ./nmbug-status fatal: Not a git repository: '/home/cworth/.nmbug' fatal: Not a git repository: '/home/cworth/.nmbug' Traceback (most recent call last): File "./nmbug-status", line 254, in config = read_config(path=args.config) File

[PATCH 2/2] nmbug-status: Use 'show-ref --heads' for loading configs

2014-05-10 Thread W. Trevor King
When loading configs from Git, the bare branch name (without a refs/heads/ prefix or similar) matches all branches of that name (including remote-tracking branches): .nmbug $ git show-ref config 48f3bbf1d1492e5f3d2f01de6ea79a30d3840f20 refs/heads/config 48f3bbf1d1492e5f3d2f01de6ea79a30d3840f

[PATCH 1/2] nmbug-status: Clarify errors for illegible configs

2014-05-10 Thread W. Trevor King
Carl Worth pointed out that errors like: $ ./nmbug-status fatal: Not a git repository: '/home/cworth/.nmbug' fatal: Not a git repository: '/home/cworth/.nmbug' Traceback (most recent call last): File "./nmbug-status", line 254, in config = read_config(path=args.config) File

[PATCH 0/2] nmbug-config errors for illegible configs

2014-05-10 Thread W. Trevor King
More accessible errors and consistent config loading inspired by Carl's report of the unhelpful 'No JSON object' traceback [1]. Cheers, Trevor [1]: id:87wqegr3dm.fsf at yoom.home.cworth.org http://article.gmane.org/gmane.mail.notmuch.general/17995 W. Trevor King (2): nmbug-status: Clarify

[PATCH 5/5] nmbug-status: Shift the script description into a docstring

2014-05-10 Thread W. Trevor King
This way we can use it as the ArgumentParser description (formatted with 'nmbug-status --help') and script readers still have it near the top of the file. I rephrased things a bit to match PEP 257's summary-line-and-body format [1] while elaborating on the "if available" Gmane views. [1]: http://

[PATCH 2/5] Move the generated date from the top of the page to the footer.

2014-05-10 Thread W. Trevor King
From: Carl Worth It's useful reference information, but anyone who wants it will look for and find it. We don't need this front-and-center. --- devel/nmbug/nmbug-status | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/devel/nmbug/nmbug-status b/devel/nmbug/nmbug-status

[PATCH 4/5] Add a comment describing the program

2014-05-10 Thread W. Trevor King
From: Carl Worth It's quite simple, really. --- devel/nmbug/nmbug-status | 3 +++ 1 file changed, 3 insertions(+) diff --git a/devel/nmbug/nmbug-status b/devel/nmbug/nmbug-status index e14fecd..c9cc745 100755 --- a/devel/nmbug/nmbug-status +++ b/devel/nmbug/nmbug-status @@ -1,5 +1,8 @@ #!/usr/

[PATCH 1/5] Add explicit license information

2014-05-10 Thread W. Trevor King
From: Carl Worth The "same license as notmuch" text was probably fine when the file was contained within the notmuch source repository, but here, externally, we should be explicit. --- The "externally" reference in patch 1/5 won't apply if this commit lands in master. I'm not sure it's worth cha

[PATCH 0/5] nmbug-status fixups from notmuch-to-html

2014-05-10 Thread W. Trevor King
I've cherry-picked the three patches I liked from Carl's master [1,2] and added two cleanup commits of my own. I've left Carl's commit messages unchanged. I'm fine squashing my fixups into Carl's originals (leaving Carl as the author) if that's ok with him. Cheers, Trevor [1]: id:20140423001824

[PATCH 3/5] nmbug-status: Use a triple-quoted string for the footer template

2014-05-10 Thread W. Trevor King
Follow the pattern set by our header template and avoid the long line. --- devel/nmbug/nmbug-status | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/devel/nmbug/nmbug-status b/devel/nmbug/nmbug-status index b4f9829..e14fecd 100755 --- a/devel/nmbug/nmbug-status +++ b/devel

[PATCH 5/5] nmbug-status: Shift the script description into a docstring

2014-05-10 Thread W. Trevor King
This way we can use it as the ArgumentParser description (formatted with 'nmbug-status --help') and script readers still have it near the top of the file. I rephrased things a bit to match PEP 257's summary-line-and-body format [1] while elaborating on the "if available" Gmane views. [1]: http://

[PATCH 4/5] Add a comment describing the program

2014-05-10 Thread W. Trevor King
From: Carl Worth It's quite simple, really. --- devel/nmbug/nmbug-status | 3 +++ 1 file changed, 3 insertions(+) diff --git a/devel/nmbug/nmbug-status b/devel/nmbug/nmbug-status index e14fecd..c9cc745 100755 --- a/devel/nmbug/nmbug-status +++ b/devel/nmbug/nmbug-status @@ -1,5 +1,8 @@ #!/usr/

[PATCH 3/5] nmbug-status: Use a triple-quoted string for the footer template

2014-05-10 Thread W. Trevor King
Follow the pattern set by our header template and avoid the long line. --- devel/nmbug/nmbug-status | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/devel/nmbug/nmbug-status b/devel/nmbug/nmbug-status index b4f9829..e14fecd 100755 --- a/devel/nmbug/nmbug-status +++ b/devel

[PATCH 2/5] Move the generated date from the top of the page to the footer.

2014-05-10 Thread W. Trevor King
From: Carl Worth It's useful reference information, but anyone who wants it will look for and find it. We don't need this front-and-center. --- devel/nmbug/nmbug-status | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/devel/nmbug/nmbug-status b/devel/nmbug/nmbug-status

[PATCH 1/5] Add explicit license information

2014-05-10 Thread W. Trevor King
From: Carl Worth The "same license as notmuch" text was probably fine when the file was contained within the notmuch source repository, but here, externally, we should be explicit. --- The "externally" reference in patch 1/5 won't apply if this commit lands in master. I'm not sure it's worth cha

[PATCH 0/5] nmbug-status fixups from notmuch-to-html

2014-05-10 Thread W. Trevor King
I've cherry-picked the three patches I liked from Carl's master [1,2] and added two cleanup commits of my own. I've left Carl's commit messages unchanged. I'm fine squashing my fixups into Carl's originals (leaving Carl as the author) if that's ok with him. Cheers, Trevor [1]: id:20140423001824

[PATCH] doc: Fix parallel build of roff files

2014-05-10 Thread Austin Clements
On Sat, 10 May 2014, "W. Trevor King" wrote: > On Thu, Apr 17, 2014 at 04:34:57PM -0400, Austin Clements wrote: >> +$(DOCBUILDDIR)/.roff.stamp: ${MAN_RST_FILES} >> ifeq ($(HAVE_SPHINX),1) >> $(SPHINXBUILD) -b man $(ALLSPHINXOPTS) $(DOCBUILDDIR)/man >> for section in 1 5 7; do \ >> @@ -4

[PATCH v2 2/5] test: Made T010-help-test and T020-compact tests more portable.

2014-05-10 Thread Charles Celerier
The tests T010-help-test and T020-compact use the files have-man and have-compact, respectively, as indicators of how notmuch is configured. These were symbolic links to true and false for use in bash tests. Unfortunately, the paths to true and false may not be the same on all platforms (e.g. on Ma

[PATCH] configure: add a fallback check for zlib

2014-05-10 Thread Xīcò
Since zlib is part of the base system, FreeBSD chose not to register it in pkg-config through zlib.pc. As a fallback test, configure will build and run a zlib version check and make sure the header and library versions are compatible. --- compat/have_zlib.c | 6 ++ configure | 21 +++

[PATCH] configure: add a fallback check for zlib

2014-05-10 Thread Xīcò
Since zlib is part of the base system, FreeBSD chose not to register it in pkg-config through zlib.pc. As a fallback test, configure will build and run a zlib version check and make sure the header and library versions are compatible. --- compat/have_zlib.c | 6 ++ configure | 21 +++

pkg-config zlib check in 3c13bc

2014-05-10 Thread David Bremner
X?c? writes: > On Sat, May 10, 2014 at 09:46:00AM +0900, David Bremner wrote: >> > int main(void) >> > { >> > return(ZLIB_VERNUM >= 0x1252); >> > } >> >> OK, that sounds like it could work. Ideally, somebody on FreeBSD could >> check... >> >> d > > Such check will work on FreeBSD, and woul

[PATCH] Fallback check for zlib.

2014-05-10 Thread Tomi Ollila
On Sat, May 10 2014, X?c? wrote: > --- I must say I like the patch. One thing I would change: +return (ZLIB_VERNUM) < (MINVER) || zlibVersion()[0] != (ZLIB_VERSION)[0]; i.e. short-circuiting potential failure before executing zlibVersion()... (parenthesising macros is just extra fanciness

[PATCH v2 5/5] T360-symbol-hiding: Use nm instead of objdump.

2014-05-10 Thread Charles Celerier
consistent since its a simpler program. chuck -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 494 bytes Desc: not available URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20140510/4f22a64f/attachment-0001.pgp>

Github?

2014-05-10 Thread Tomi Ollila
On Sat, May 10 2014, "Wael M. Nasreddine" wrote: > On Fri, May 9, 2014 at 6:21 PM, David Bremner wrote: >> Felipe Contreras writes: >> >>> Amadeusz ?o?nowski wrote: The same goes for Travis. There's already a build bot. Why bother with Travis? >>> >>> I've never seen any buildbot res

Github?

2014-05-10 Thread David Bremner
Felipe Contreras writes: > Amadeusz ?o?nowski wrote: >> The same goes for Travis. There's already a build bot. Why bother >> with Travis? > > I've never seen any buildbot results. TravisCI's interface is just > simple and easy. And all it requires is one file. > Not to take a position on travis

[PATCH v2 5/5] doc: Add rst2html support for building HTML docs

2014-05-10 Thread W. Trevor King
We already fall back to rst2man if Sphinx isn't available for building the man pages. With this commit we'll fall back to rst2html for building the HTML docs too. The only tricky bit here is that HAVE_SPHINX explicitly checks for sphinx.writers.manpage. I'm just assuming sphinx.writers.html exis

[PATCH v2 4/5] doc: Consolidate Makefile targets around {build|install}-{format}

2014-05-10 Thread W. Trevor King
The rst2man target was removed in 9d9a700 (doc: build man pages at build time; introduce HAVE_SPHINX, HAVE_RST2MAN, 2014-03-13), but a reference in the install docs slipped through. While I was removing that reference, I also: * Converted doc/INSTALL to reStructuredText, so I can link to Sphinx

[PATCH v2 2/5] doc/prerst2man.py: Convert execfile to import

2014-05-10 Thread W. Trevor King
excefile is gone in Python 3 [1]. Instead of exec-ing the configuration, it's easier to insert the source directory in Python's path [2], and just import the configuration. With this change, prerst2man.py is compatible with both Python 2 and 3. [1]: https://docs.python.org/3.0/whatsnew/3.0.html#

[PATCH v2 3/5] doc/prerst2x.py: Adjust to handle any output format, not just man pages

2014-05-10 Thread W. Trevor King
For example, with these changes we can build HTML output using: $ prerst2x.py rst2html ${SRCDIR} ${OUTDIR} html The extension adjustment ensures that the output filenames from the above command match what we currently generate with sphinx-html. --- doc/Makefile.local | 4 +-- doc/prerst2man.p

[PATCH v2 0/5] rst2man.py support and doc-build cleanups

2014-05-10 Thread W. Trevor King
The first four patches from v1 have already landed in master. This series is v2 of the remainder of the series [1]. In patch 1/5 (v1's 5/7): * Explicitly empty RST2MAN [2,3], rather than letting external environment variables fall through (or explicitly using them to bypass configure's detect

[PATCH v2 5/5] doc: Add rst2html support for building HTML docs

2014-05-10 Thread W. Trevor King
We already fall back to rst2man if Sphinx isn't available for building the man pages. With this commit we'll fall back to rst2html for building the HTML docs too. The only tricky bit here is that HAVE_SPHINX explicitly checks for sphinx.writers.manpage. I'm just assuming sphinx.writers.html exis

[PATCH v2 4/5] doc: Consolidate Makefile targets around {build|install}-{format}

2014-05-10 Thread W. Trevor King
The rst2man target was removed in 9d9a700 (doc: build man pages at build time; introduce HAVE_SPHINX, HAVE_RST2MAN, 2014-03-13), but a reference in the install docs slipped through. While I was removing that reference, I also: * Converted doc/INSTALL to reStructuredText, so I can link to Sphinx

[PATCH v2 3/5] doc/prerst2x.py: Adjust to handle any output format, not just man pages

2014-05-10 Thread W. Trevor King
For example, with these changes we can build HTML output using: $ prerst2x.py rst2html ${SRCDIR} ${OUTDIR} html The extension adjustment ensures that the output filenames from the above command match what we currently generate with sphinx-html. --- doc/Makefile.local | 4 +-- doc/prerst2man.p

[PATCH v2 2/5] doc/prerst2man.py: Convert execfile to import

2014-05-10 Thread W. Trevor King
excefile is gone in Python 3 [1]. Instead of exec-ing the configuration, it's easier to insert the source directory in Python's path [2], and just import the configuration. With this change, prerst2man.py is compatible with both Python 2 and 3. [1]: https://docs.python.org/3.0/whatsnew/3.0.html#

[PATCH v2 1/5] doc: Allow rst2man.py as an alternative to rst2man

2014-05-10 Thread W. Trevor King
Gentoo's dev-python/docutils-0.10 installs Docutils scripts with a *.py extension, so I have /usr/bin/rst2man.py and no rst2man script. This patch supports users with both types of systems by checking for rst2man, falling back on rst2man.py, and giving up only if neither is found. Users can also s

[PATCH v2 0/5] rst2man.py support and doc-build cleanups

2014-05-10 Thread W. Trevor King
The first four patches from v1 have already landed in master. This series is v2 of the remainder of the series [1]. In patch 1/5 (v1's 5/7): * Explicitly empty RST2MAN [2,3], rather than letting external environment variables fall through (or explicitly using them to bypass configure's detect

pkg-config zlib check in 3c13bc

2014-05-10 Thread David Bremner
Tomi Ollila writes: > > Actually my suggestion would be that if that pkg-config line for > zlib does not work (btw why does it not work) I guess because FreeBSD (and maybe other systems) have a distinction between the "base system" and "add on packages" and pkg-config only works for the latte

[PATCH v2] emacs: Improve the cited message included in replies

2014-05-10 Thread Mark Walters
On Thu, 08 May 2014, David Edmondson wrote: > emacs: Improve the cited message included in replies > > v2: > - Don't run the text/plain hooks when generating the message to quote. > In principle I like this approach: keeping show and reply closely linked seems good. At the moment, as you say, th

Re: [PATCH] doc: Fix parallel build of roff files

2014-05-10 Thread Austin Clements
On Sat, 10 May 2014, "W. Trevor King" wrote: > On Thu, Apr 17, 2014 at 04:34:57PM -0400, Austin Clements wrote: >> +$(DOCBUILDDIR)/.roff.stamp: ${MAN_RST_FILES} >> ifeq ($(HAVE_SPHINX),1) >> $(SPHINXBUILD) -b man $(ALLSPHINXOPTS) $(DOCBUILDDIR)/man >> for section in 1 5 7; do \ >> @@ -4

[PATCH] doc/conf.py: Remove _static from html_static_path

2014-05-10 Thread W. Trevor King
Avoid: $ make HAVE_SPHINX=1 sphinx-html python ./doc/mkdocdeps.py ./doc doc/_build doc/docdeps.mk sphinx-build -b html -d doc/_build/doctrees -q ./doc doc/_build/html Making output directory... WARNING: html_static_path entry '/home/wking/src/notmuch/notmuch/doc/_static' does not exist

[PATCH] doc/conf.py: Remove _static from html_static_path

2014-05-10 Thread W. Trevor King
Avoid: $ make HAVE_SPHINX=1 sphinx-html python ./doc/mkdocdeps.py ./doc doc/_build doc/docdeps.mk sphinx-build -b html -d doc/_build/doctrees -q ./doc doc/_build/html Making output directory... WARNING: html_static_path entry '/home/wking/src/notmuch/notmuch/doc/_static' does not exist

[PATCH v2 2/5] test: Made T010-help-test and T020-compact tests more portable.

2014-05-10 Thread Charles Celerier
The tests T010-help-test and T020-compact use the files have-man and have-compact, respectively, as indicators of how notmuch is configured. These were symbolic links to true and false for use in bash tests. Unfortunately, the paths to true and false may not be the same on all platforms (e.g. on Ma

Re: [PATCH] doc: Fix parallel build of roff files

2014-05-10 Thread W. Trevor King
On Thu, Apr 17, 2014 at 04:34:57PM -0400, Austin Clements wrote: > +$(DOCBUILDDIR)/.roff.stamp: ${MAN_RST_FILES} > ifeq ($(HAVE_SPHINX),1) > $(SPHINXBUILD) -b man $(ALLSPHINXOPTS) $(DOCBUILDDIR)/man > for section in 1 5 7; do \ > @@ -48,6 +54,7 @@ else > @echo "Fatal: build depen

[PATCH] doc: Fix parallel build of roff files

2014-05-10 Thread W. Trevor King
ure.asc Type: application/pgp-signature Size: 836 bytes Desc: OpenPGP digital signature URL: <http://notmuchmail.org/pipermail/notmuch/attachments/20140510/0e1cbab8/attachment.pgp>

Re: [PATCH v2 5/5] T360-symbol-hiding: Use nm instead of objdump.

2014-05-10 Thread Charles Celerier
David Bremner writes: > Charles Celerier writes: > >> At this point, I'm not sure how to create a better version of this >> patch. Are we renaming functions in notmuch-private.h? Should we stick >> with objdump or switch to using nm? > > I'd go with renaming any functions that start with notmuch

Bug: make install depends on emacs being detected during configure in 0.18

2014-05-10 Thread Benjamin Podszun
Hi. As discussed on IRC, mostly to archive the issue here as well: 0.18 fails during make install if emacs is missing, due to a missing emacs/notmuch-version.el file (which is generated from a template, but not if you don't _have_ emacs). Full build log below, please ignore the nix specific stuff

Re: [PATCH] Fallback check for zlib.

2014-05-10 Thread Tomi Ollila
On Sat, May 10 2014, David Bremner wrote: > Xīcò writes: > >> --- >> compat/have_zlib.c | 6 ++ >> configure | 21 - >> 2 files changed, 22 insertions(+), 5 deletions(-) >> create mode 100644 compat/have_zlib.c > > If you're doing a second version for Tomi's c

Github?

2014-05-10 Thread Felipe Contreras
Tomi Ollila wrote: > BTW: does .travis.yml support comment lines ? It's YAML. So, yes. -- Felipe Contreras

Re: [PATCH v2 5/5] T360-symbol-hiding: Use nm instead of objdump.

2014-05-10 Thread David Bremner
Charles Celerier writes: > David Bremner writes: > > $ nm --version > GNU nm (GNU Binutils) 2.24 > Copyright 2013 Free Software Foundation, Inc. > This program is free software; you may redistribute it under the terms of > the GNU General Public License version 3 or (at your

Re: [PATCH] Fallback check for zlib.

2014-05-10 Thread David Bremner
Xīcò writes: > --- > compat/have_zlib.c | 6 ++ > configure | 21 - > 2 files changed, 22 insertions(+), 5 deletions(-) > create mode 100644 compat/have_zlib.c If you're doing a second version for Tomi's comments, please put roughly the comments from the cover

Re: [PATCH v2] emacs: Improve the cited message included in replies

2014-05-10 Thread Mark Walters
On Thu, 08 May 2014, David Edmondson wrote: > emacs: Improve the cited message included in replies > > v2: > - Don't run the text/plain hooks when generating the message to quote. > In principle I like this approach: keeping show and reply closely linked seems good. At the moment, as you say, th

Re: Github?

2014-05-10 Thread Felipe Contreras
Tomi Ollila wrote: > BTW: does .travis.yml support comment lines ? It's YAML. So, yes. -- Felipe Contreras ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] Fallback check for zlib.

2014-05-10 Thread Tomi Ollila
On Sat, May 10 2014, Xīcò wrote: > --- I must say I like the patch. One thing I would change: +return (ZLIB_VERNUM) < (MINVER) || zlibVersion()[0] != (ZLIB_VERSION)[0]; i.e. short-circuiting potential failure before executing zlibVersion()... (parenthesising macros is just extra fanciness

Re: Github?

2014-05-10 Thread Tomi Ollila
On Sat, May 10 2014, "Wael M. Nasreddine" wrote: > On Fri, May 9, 2014 at 6:21 PM, David Bremner wrote: >> Felipe Contreras writes: >> >>> Amadeusz Żołnowski wrote: The same goes for Travis. There's already a build bot. Why bother with Travis? >>> >>> I've never seen any buildbot res