[PATCH 1/3] build: don't add sub Makefiles to the global deps
On Sun, 25 May 2014, Felipe Contreras wrote: > Jani Nikula wrote: >> On Sun, 25 May 2014, Felipe Contreras wrote: >> > Jani Nikula wrote: >> >> On Fri, 23 May 2014, Felipe Contreras >> >> wrote: >> >> > They don't affect the global build. >> >> >> >> They do. >> > >> > They don't. >> >> Your patch, your commit message, please explain *why* you think they >> wouldn't or shouldn't affect the global build. Just to mention one >> thing, why someone modifying cflags in sub makefiles shouldn't cause >> rebuild? > > Go to emacs/Makefile, it's basically a stub, why would any modifications > there affect the global build? It's not included anywhere. > > emacs/Makefile.local is included in the global build, emacs/Makefile is > not. Fair enough. And what is the benefit of not depending on them, since they hardly ever change? I'd rather err on the depending side. BR, Jani.
[RFC PATCH] configure: Create sh.config based on Makefile.config data
On Sun, May 25 2014, Jani Nikula wrote:
> On Sun, 11 May 2014, Tomi Ollila wrote:
>> Read Makefile.config and when line matches var = val assignment
>> create _var='val' from it. var must match [a-zA-Z_][a-zA-Z0-9_]*
>> and val [^'\]* ('\' usually meaning multiline assignments).
>>
>> Write these lines to sh.config.
>>
>> sh.config can then be used e.g. in test scripts.
>
> I like the general idea here much better than [1] or the symlinks that
> we have now. However I'm wary of the sed magic and the various ways it
> might trip over. The resulting file has way more info than we need, but
> then it also misses the multiline settings (which we luckily don't
> need).
>
> At the risk of duplicating stuff, I'd go with manually generated config
> for shell with minimal amount of information. For now, we'd only need
> this for HAVE_XAPIAN_COMPACT and HAVE_MAN (the latter of which could
> also be dropped from Makefile.config).
I agree with this. It looks simpler and cleaner to an outside observer.
I don't think the duplication of (one variable now) stuff is of any issue
here (now or in foreseeable future).
>
> BR,
> Jani.
>
>
> [1] id:1399737224-79348-1-git-send-email-cceleri at cs.stanford.edu
In any case, this sh.config to be useful sourcing of it needs to be
added to test/test-lib.sh and then used in the followup patch of
the above...
Tomi
>> ---
>> configure | 5 +
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/configure b/configure
>> index 9bde2eb72b0e..feb0e480f86a 100755
>> --- a/configure
>> +++ b/configure
>> @@ -935,3 +935,8 @@ CONFIGURE_CXXFLAGS = -DHAVE_GETLINE=\$(HAVE_GETLINE)
>> \$(GMIME_CFLAGS)\\
>>
>> CONFIGURE_LDFLAGS = \$(GMIME_LDFLAGS) \$(TALLOC_LDFLAGS) \$(ZLIB_LDFLAGS)
>> \$(XAPIAN_LDFLAGS)
>> EOF
>> +
>> +# Create sh.config based on Makefile.config values.
>> +# Output will be _var='val', val not containing ' nor \ (skipping
>> multiline).
>> +sed -n 's/^\([a-zA-Z_][a-zA-Z0-9_]*\) *= *\([^\\'\'']*\)$/_\1='\''\2'\''/p'
>> \
>> +Makefile.config > sh.config
>> --
>> 1.8.0
>>
>> ___
>> notmuch mailing list
>> notmuch at notmuchmail.org
>> http://notmuchmail.org/mailman/listinfo/notmuch
> ___
> notmuch mailing list
> notmuch at notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
Cannot apply multiple tags to a selection in search view
Hi,
After upgrading to version 0.17, the following function that used to
work fine in the past misbehaves when I select multiple messages:
(define-key notmuch-search-mode-map "d"
(lambda ()
"Delete message."
(interactive)
(notmuch-search-tag '("+delete" "-inbox" "-lowpriority" "- at review"
"- at respond" "-unread"
If I press "d", it only applies the tags to the message my cursor is on
- not my whole message.
If I manually execute the notmuch-search-tag command, it does work on
the whole selection, though.
Any ideas?
Thanks!
[RFC PATCH] configure: Create sh.config based on Makefile.config data
On Sun, 11 May 2014, Tomi Ollila wrote:
> Read Makefile.config and when line matches var = val assignment
> create _var='val' from it. var must match [a-zA-Z_][a-zA-Z0-9_]*
> and val [^'\]* ('\' usually meaning multiline assignments).
>
> Write these lines to sh.config.
>
> sh.config can then be used e.g. in test scripts.
I like the general idea here much better than [1] or the symlinks that
we have now. However I'm wary of the sed magic and the various ways it
might trip over. The resulting file has way more info than we need, but
then it also misses the multiline settings (which we luckily don't
need).
At the risk of duplicating stuff, I'd go with manually generated config
for shell with minimal amount of information. For now, we'd only need
this for HAVE_XAPIAN_COMPACT and HAVE_MAN (the latter of which could
also be dropped from Makefile.config).
BR,
Jani.
[1] id:1399737224-79348-1-git-send-email-cceleri at cs.stanford.edu
> ---
> configure | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/configure b/configure
> index 9bde2eb72b0e..feb0e480f86a 100755
> --- a/configure
> +++ b/configure
> @@ -935,3 +935,8 @@ CONFIGURE_CXXFLAGS = -DHAVE_GETLINE=\$(HAVE_GETLINE)
> \$(GMIME_CFLAGS)\\
>
> CONFIGURE_LDFLAGS = \$(GMIME_LDFLAGS) \$(TALLOC_LDFLAGS) \$(ZLIB_LDFLAGS)
> \$(XAPIAN_LDFLAGS)
> EOF
> +
> +# Create sh.config based on Makefile.config values.
> +# Output will be _var='val', val not containing ' nor \ (skipping multiline).
> +sed -n 's/^\([a-zA-Z_][a-zA-Z0-9_]*\) *= *\([^\\'\'']*\)$/_\1='\''\2'\''/p' \
> + Makefile.config > sh.config
> --
> 1.8.0
>
> ___
> notmuch mailing list
> notmuch at notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
[PATCH v1] emacs: Add `notmuch-show-toggle-citation-visibility', bound to '>'
On Tue, 20 May 2014, David Edmondson wrote: > Add a function and key-binding to toggle the collapsing of citations > within the current message. ... > + (define-key map ">" 'notmuch-show-toggle-citation-visibility) Bikeshedding... I'd like to reserve '>' for either redirecting (see '|') or indentation (see '<'). Jani.
Re: [PATCH v1] emacs: Add `notmuch-show-toggle-citation-visibility', bound to ''
On Tue, 20 May 2014, David Edmondson d...@dme.org wrote: Add a function and key-binding to toggle the collapsing of citations within the current message. ... + (define-key map 'notmuch-show-toggle-citation-visibility) Bikeshedding... I'd like to reserve '' for either redirecting (see '|') or indentation (see ''). Jani. ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH 1/3] build: don't add sub Makefiles to the global deps
On Fri, 23 May 2014, Felipe Contreras felipe.contre...@gmail.com wrote: They don't affect the global build. They do. BR, Jani. Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 4c0e8c6..2d1aee9 100644 --- a/Makefile +++ b/Makefile @@ -20,7 +20,7 @@ include Makefile.config # We make all targets depend on the Makefiles themselves. global_deps = Makefile Makefile.config Makefile.local \ - $(subdirs:%=%/Makefile) $(subdirs:%=%/Makefile.local) + $(subdirs:%=%/Makefile.local) Makefile.config: $(srcdir)/configure ifeq ($(configure_options),) -- 1.9.3+fc1~5~gfaddd51 ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH 1/3] build: don't add sub Makefiles to the global deps
Jani Nikula wrote: On Fri, 23 May 2014, Felipe Contreras felipe.contre...@gmail.com wrote: They don't affect the global build. They do. They don't. Cheers. -- Felipe Contreras ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: [RFC PATCH] configure: Create sh.config based on Makefile.config data
On Sun, 11 May 2014, Tomi Ollila tomi.oll...@iki.fi wrote:
Read Makefile.config and when line matches var = val assignment
create _var='val' from it. var must match [a-zA-Z_][a-zA-Z0-9_]*
and val [^'\]* ('\' usually meaning multiline assignments).
Write these lines to sh.config.
sh.config can then be used e.g. in test scripts.
I like the general idea here much better than [1] or the symlinks that
we have now. However I'm wary of the sed magic and the various ways it
might trip over. The resulting file has way more info than we need, but
then it also misses the multiline settings (which we luckily don't
need).
At the risk of duplicating stuff, I'd go with manually generated config
for shell with minimal amount of information. For now, we'd only need
this for HAVE_XAPIAN_COMPACT and HAVE_MAN (the latter of which could
also be dropped from Makefile.config).
BR,
Jani.
[1] id:1399737224-79348-1-git-send-email-ccel...@cs.stanford.edu
---
configure | 5 +
1 file changed, 5 insertions(+)
diff --git a/configure b/configure
index 9bde2eb72b0e..feb0e480f86a 100755
--- a/configure
+++ b/configure
@@ -935,3 +935,8 @@ CONFIGURE_CXXFLAGS = -DHAVE_GETLINE=\$(HAVE_GETLINE)
\$(GMIME_CFLAGS)\\
CONFIGURE_LDFLAGS = \$(GMIME_LDFLAGS) \$(TALLOC_LDFLAGS) \$(ZLIB_LDFLAGS)
\$(XAPIAN_LDFLAGS)
EOF
+
+# Create sh.config based on Makefile.config values.
+# Output will be _var='val', val not containing ' nor \ (skipping multiline).
+sed -n 's/^\([a-zA-Z_][a-zA-Z0-9_]*\) *= *\([^\\'\'']*\)$/_\1='\''\2'\''/p' \
+ Makefile.config sh.config
--
1.8.0
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH 1/3] build: don't add sub Makefiles to the global deps
On Sun, 25 May 2014, Felipe Contreras felipe.contre...@gmail.com wrote: Jani Nikula wrote: On Fri, 23 May 2014, Felipe Contreras felipe.contre...@gmail.com wrote: They don't affect the global build. They do. They don't. Your patch, your commit message, please explain *why* you think they wouldn't or shouldn't affect the global build. Just to mention one thing, why someone modifying cflags in sub makefiles shouldn't cause rebuild? BR, Jani. ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: [RFC PATCH] configure: Create sh.config based on Makefile.config data
On Sun, May 25 2014, Jani Nikula j...@nikula.org wrote:
On Sun, 11 May 2014, Tomi Ollila tomi.oll...@iki.fi wrote:
Read Makefile.config and when line matches var = val assignment
create _var='val' from it. var must match [a-zA-Z_][a-zA-Z0-9_]*
and val [^'\]* ('\' usually meaning multiline assignments).
Write these lines to sh.config.
sh.config can then be used e.g. in test scripts.
I like the general idea here much better than [1] or the symlinks that
we have now. However I'm wary of the sed magic and the various ways it
might trip over. The resulting file has way more info than we need, but
then it also misses the multiline settings (which we luckily don't
need).
At the risk of duplicating stuff, I'd go with manually generated config
for shell with minimal amount of information. For now, we'd only need
this for HAVE_XAPIAN_COMPACT and HAVE_MAN (the latter of which could
also be dropped from Makefile.config).
I agree with this. It looks simpler and cleaner to an outside observer.
I don't think the duplication of (one variable now) stuff is of any issue
here (now or in foreseeable future).
BR,
Jani.
[1] id:1399737224-79348-1-git-send-email-ccel...@cs.stanford.edu
In any case, this sh.config to be useful sourcing of it needs to be
added to test/test-lib.sh and then used in the followup patch of
the above...
Tomi
---
configure | 5 +
1 file changed, 5 insertions(+)
diff --git a/configure b/configure
index 9bde2eb72b0e..feb0e480f86a 100755
--- a/configure
+++ b/configure
@@ -935,3 +935,8 @@ CONFIGURE_CXXFLAGS = -DHAVE_GETLINE=\$(HAVE_GETLINE)
\$(GMIME_CFLAGS)\\
CONFIGURE_LDFLAGS = \$(GMIME_LDFLAGS) \$(TALLOC_LDFLAGS) \$(ZLIB_LDFLAGS)
\$(XAPIAN_LDFLAGS)
EOF
+
+# Create sh.config based on Makefile.config values.
+# Output will be _var='val', val not containing ' nor \ (skipping
multiline).
+sed -n 's/^\([a-zA-Z_][a-zA-Z0-9_]*\) *= *\([^\\'\'']*\)$/_\1='\''\2'\''/p'
\
+Makefile.config sh.config
--
1.8.0
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH 1/3] build: don't add sub Makefiles to the global deps
Jani Nikula wrote: On Sun, 25 May 2014, Felipe Contreras felipe.contre...@gmail.com wrote: Jani Nikula wrote: On Fri, 23 May 2014, Felipe Contreras felipe.contre...@gmail.com wrote: They don't affect the global build. They do. They don't. Your patch, your commit message, please explain *why* you think they wouldn't or shouldn't affect the global build. Just to mention one thing, why someone modifying cflags in sub makefiles shouldn't cause rebuild? Go to emacs/Makefile, it's basically a stub, why would any modifications there affect the global build? It's not included anywhere. emacs/Makefile.local is included in the global build, emacs/Makefile is not. -- Felipe Contreras ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH 1/3] build: don't add sub Makefiles to the global deps
On Sun, 25 May 2014, Felipe Contreras felipe.contre...@gmail.com wrote: Jani Nikula wrote: On Sun, 25 May 2014, Felipe Contreras felipe.contre...@gmail.com wrote: Jani Nikula wrote: On Fri, 23 May 2014, Felipe Contreras felipe.contre...@gmail.com wrote: They don't affect the global build. They do. They don't. Your patch, your commit message, please explain *why* you think they wouldn't or shouldn't affect the global build. Just to mention one thing, why someone modifying cflags in sub makefiles shouldn't cause rebuild? Go to emacs/Makefile, it's basically a stub, why would any modifications there affect the global build? It's not included anywhere. emacs/Makefile.local is included in the global build, emacs/Makefile is not. Fair enough. And what is the benefit of not depending on them, since they hardly ever change? I'd rather err on the depending side. BR, Jani. ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Cannot apply multiple tags to a selection in search view
Hi, After upgrading to version 0.17, the following function that used to work fine in the past misbehaves when I select multiple messages: (define-key notmuch-search-mode-map d (lambda () Delete message. (interactive) (notmuch-search-tag '(+delete -inbox -lowpriority -@review -@respond -unread If I press d, it only applies the tags to the message my cursor is on - not my whole message. If I manually execute the notmuch-search-tag command, it does work on the whole selection, though. Any ideas? Thanks! ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: Cannot apply multiple tags to a selection in search view
Hi I think notmuch-search-tag (and other tagging functions) were cleaned up for 0.17: in particular their interactive behaviour changed. notmuch-search-tag now only looks at the region if called interactively. I think the following would do what you want (define-key notmuch-search-mode-map d (lambda (beg end) Delete message. (interactive (notmuch-search-interactive-region)) (notmuch-search-tag '(+delete -inbox -lowpriority -@review -@respond -unread) beg end))) Best wishes Mark On Sun, 25 May 2014, mailingli...@nawaz.org wrote: Hi, After upgrading to version 0.17, the following function that used to work fine in the past misbehaves when I select multiple messages: (define-key notmuch-search-mode-map d (lambda () Delete message. (interactive) (notmuch-search-tag '(+delete -inbox -lowpriority -@review -@respond -unread If I press d, it only applies the tags to the message my cursor is on - not my whole message. If I manually execute the notmuch-search-tag command, it does work on the whole selection, though. Any ideas? Thanks! ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
