[PATCH 00/11] notmuch insert updates

2014-09-25 Thread Tomi Ollila
On Thu, Sep 25 2014, David Bremner wrote: > Jani Nikula writes: > >> This series refactors and cleans up insert, improves error handling and >> reporting, and adds post-insert hook. I intend to add documentation and >> more tests, but the code is ready for review. Also, at least some of the >>

[PATCH 1/5] cli: Refactor option passing in the search command

2014-09-25 Thread Michal Sojka
On Thu, Sep 25 2014, Tomi Ollila wrote: > On Mon, Sep 22 2014, Michal Sojka wrote: > >> Many functions that implement the search command need to access command >> line options. Instead of passing each option in a separate variable, put >> them in a structure and pass only this structure. > > This

[PATCH 1/5] cli: Refactor option passing in the search command

2014-09-25 Thread Tomi Ollila
On Mon, Sep 22 2014, Michal Sojka wrote: > Many functions that implement the search command need to access command > line options. Instead of passing each option in a separate variable, put > them in a structure and pass only this structure. This patch looks good to me. Although the test and

[PATCH 00/11] notmuch insert updates

2014-09-25 Thread David Bremner
Jani Nikula writes: > This series refactors and cleans up insert, improves error handling and > reporting, and adds post-insert hook. I intend to add documentation and > more tests, but the code is ready for review. Also, at least some of the > cleanups and fixes in the beginning of the series

Re: [PATCH 00/11] notmuch insert updates

2014-09-25 Thread David Bremner
Jani Nikula j...@nikula.org writes: This series refactors and cleans up insert, improves error handling and reporting, and adds post-insert hook. I intend to add documentation and more tests, but the code is ready for review. Also, at least some of the cleanups and fixes in the beginning of

Re: [PATCH 1/5] cli: Refactor option passing in the search command

2014-09-25 Thread Tomi Ollila
On Mon, Sep 22 2014, Michal Sojka sojk...@fel.cvut.cz wrote: Many functions that implement the search command need to access command line options. Instead of passing each option in a separate variable, put them in a structure and pass only this structure. This patch looks good to me.

Re: [PATCH 00/11] notmuch insert updates

2014-09-25 Thread Tomi Ollila
On Thu, Sep 25 2014, David Bremner da...@tethera.net wrote: Jani Nikula j...@nikula.org writes: This series refactors and cleans up insert, improves error handling and reporting, and adds post-insert hook. I intend to add documentation and more tests, but the code is ready for review. Also,

Re: [PATCH 1/5] cli: Refactor option passing in the search command

2014-09-25 Thread Michal Sojka
On Thu, Sep 25 2014, Tomi Ollila wrote: On Mon, Sep 22 2014, Michal Sojka sojk...@fel.cvut.cz wrote: Many functions that implement the search command need to access command line options. Instead of passing each option in a separate variable, put them in a structure and pass only this