[RFC PATCH 2/2] cli: add notmuch address command

2014-11-01 Thread Jani Nikula
--- notmuch-client.h | 3 ++ notmuch-search.c | 128 +++ notmuch.c| 2 + 3 files changed, 87 insertions(+), 46 deletions(-) diff --git a/notmuch-client.h b/notmuch-client.h index e1efbe0c8252..5e0d47508c6a 100644 ---

[RFC PATCH 1/2] cli: add support for hierarchical command line option arrays

2014-11-01 Thread Jani Nikula
NOTMUCH_OPT_INHERIT expects a notmuch_opt_desc_t * pointer in output_var. --- command-line-arguments.c | 11 +++ command-line-arguments.h | 1 + 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/command-line-arguments.c b/command-line-arguments.c index

[RFC PATCH 0/2] cli: split 'notmuch address' from 'notmuch search'

2014-11-01 Thread Jani Nikula
On Sat, 01 Nov 2014, Michal Sojka wrote: > On Sat, Nov 01 2014, Jani Nikula wrote: >> On Fri, 31 Oct 2014, Michal Sojka wrote: >>> This option allows to configure the criterion for duplicate address >>> filtering. Without this option, all unique combinations of name and >>> address parts are

[PATCH v2 2/1] devel: man-to-mdwn.pl: add GPLv3+ notice to manpages.mdwn

2014-11-01 Thread Tomi Ollila
Make the generated head manual page (in the notmuchmail wiki) display the licence information the whole notmuch software is licenced under. --- devel/man-to-mdwn.pl | 6 ++ 1 file changed, 6 insertions(+) diff --git a/devel/man-to-mdwn.pl b/devel/man-to-mdwn.pl index

[PATCH v2 0/2] cli: search --duplicate=N with --output=messages

2014-11-01 Thread Tomi Ollila
On Sat, Nov 01 2014, Jani Nikula wrote: > This is v2 of [1], rebased, tests added, no functional changes. Applies cleanly, tests pass. my own tests works as expected. +1 Tomi > > BR, > Jani. > > [1] id:1414705489-30771-1-git-send-email-jani at nikula.org > > Jani Nikula (2): > cli: add

[PATCH v2] configure: move make {,install} instructions to the end

2014-11-01 Thread Tomi Ollila
There was theorical possibility that writing the config files could have skipped (by interruption) after the instructions how to make notmuch was printed out. --- v2 of id:1411825219-12455-1-git-send-email-tomi.ollila at iki.fi -- .gitignore change dropped (already there) -- one newline removed

[PATCH v2 2/2] test: add tests for --output=messages --duplicate=N

2014-11-01 Thread Jani Nikula
Basic smoke tests for the feature, nothing fancy. --- test/T090-search-output.sh | 37 + 1 file changed, 37 insertions(+) diff --git a/test/T090-search-output.sh b/test/T090-search-output.sh index 947d572ebeff..fe2ec9af8c2a 100755 ---

[PATCH v2 1/2] cli: add support for notmuch search --duplicate=N with --output=messages

2014-11-01 Thread Jani Nikula
Print the message IDs of all messages matching the search terms that have at least N files associated with them. --- doc/man1/notmuch-search.rst | 12 notmuch-search.c| 35 +++ 2 files changed, 39 insertions(+), 8 deletions(-) diff --git

[PATCH v2 0/2] cli: search --duplicate=N with --output=messages

2014-11-01 Thread Jani Nikula
This is v2 of [1], rebased, tests added, no functional changes. BR, Jani. [1] id:1414705489-30771-1-git-send-email-jani at nikula.org Jani Nikula (2): cli: add support for notmuch search --duplicate=N with --output=messages test: add tests for --output=messages --duplicate=N

[PATCH v6 7/7] cli: search: Add --filter-by option to configure address filtering

2014-11-01 Thread Jani Nikula
On Fri, 31 Oct 2014, Michal Sojka wrote: > This option allows to configure the criterion for duplicate address > filtering. Without this option, all unique combinations of name and > address parts are printed. This option allows to filter the output > more, for example to only contain unique

[DRAFT PATCH] modified notmuch-emacs-mua

2014-11-01 Thread Tomi Ollila
On Wed, Oct 29 2014, Jani Nikula wrote: Thanks for quick response. There are only one (and half) thing that needs to be resolved before first inclusion, the desire for more versatile options can be discussed later... > On Fri, 11 Jul 2014, Tomi Ollila wrote: >> Highlights: >> >> *

[PATCH v6 7/7] cli: search: Add --filter-by option to configure address filtering

2014-11-01 Thread Michal Sojka
On Sat, Nov 01 2014, Jani Nikula wrote: > On Fri, 31 Oct 2014, Michal Sojka wrote: >> This option allows to configure the criterion for duplicate address >> filtering. Without this option, all unique combinations of name and >> address parts are printed. This option allows to filter the output >>

[PATCH] test: Make gen-threads work with python3

2014-11-01 Thread Tomi Ollila
On Fri, Oct 31 2014, "W. Trevor King" wrote: > On Fri, Oct 31, 2014 at 01:33:25PM -0400, Jesse Rosenthal wrote: >> We instead initalize the dictionary using the dict comprehension and >> then update it with the values from the tree. This will work with >> both python2 and python3. > > Dict

[PATCH v1] NEWS: Improved `q` binding.

2014-11-01 Thread David Bremner
David Edmondson writes: > --- > NEWS | 6 ++ > 1 file changed, 6 insertions(+) > applied, with thanks d

[PATCH v6 4/7] cli: search: Add --output={sender,recipients}

2014-11-01 Thread David Bremner
Michal Sojka writes: > The new outputs allow printing senders, recipients or both of matching > messages. To print both, the user can use --output=sender and > --output=recipients simultaneously. > I have pushed the first 4 in this series. I guess the 5th is also ready as well, but I'll see if

[PATCH v6 6/7] cli: search: Add --output=count

2014-11-01 Thread Mark Walters
On Fri, 31 Oct 2014, Michal Sojka wrote: > This output can be used with --output=recipients or --output=sender > and in addition to the addresses, it prints how many times was each > address encountered during search. Hi I have a couple comments on this patch. > --- >

[PATCH v6 0/7] notmuch search --output=sender/recipients

2014-11-01 Thread Mark Walters
On Fri, 31 Oct 2014, Michal Sojka wrote: > Hi all, > > this is v6 of the search --output=address series. It obsoletes v5 > (id:1414713573-21461-1-git-send-email-sojkam1 at fel.cvut.cz). I have tested patches 1-5 and they LGTM. +1 from me. Best wishes Mark > Changes from v5 (full diff below):

Re: [PATCH v6 4/7] cli: search: Add --output={sender,recipients}

2014-11-01 Thread David Bremner
Michal Sojka sojk...@fel.cvut.cz writes: The new outputs allow printing senders, recipients or both of matching messages. To print both, the user can use --output=sender and --output=recipients simultaneously. I have pushed the first 4 in this series. I guess the 5th is also ready as well,

Re: [PATCH v1] NEWS: Improved `q` binding.

2014-11-01 Thread David Bremner
David Edmondson d...@dme.org writes: --- NEWS | 6 ++ 1 file changed, 6 insertions(+) applied, with thanks d ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] test: Make gen-threads work with python3

2014-11-01 Thread Tomi Ollila
On Fri, Oct 31 2014, W. Trevor King wk...@tremily.us wrote: On Fri, Oct 31, 2014 at 01:33:25PM -0400, Jesse Rosenthal wrote: We instead initalize the dictionary using the dict comprehension and then update it with the values from the tree. This will work with both python2 and python3. Dict

Re: [DRAFT PATCH] modified notmuch-emacs-mua

2014-11-01 Thread Tomi Ollila
On Wed, Oct 29 2014, Jani Nikula j...@nikula.org wrote: Thanks for quick response. There are only one (and half) thing that needs to be resolved before first inclusion, the desire for more versatile options can be discussed later... On Fri, 11 Jul 2014, Tomi Ollila tomi.oll...@iki.fi wrote:

Re: [PATCH v6 7/7] cli: search: Add --filter-by option to configure address filtering

2014-11-01 Thread Michal Sojka
On Sat, Nov 01 2014, Jani Nikula wrote: On Fri, 31 Oct 2014, Michal Sojka sojk...@fel.cvut.cz wrote: This option allows to configure the criterion for duplicate address filtering. Without this option, all unique combinations of name and address parts are printed. This option allows to filter

[PATCH v2 2/2] test: add tests for --output=messages --duplicate=N

2014-11-01 Thread Jani Nikula
Basic smoke tests for the feature, nothing fancy. --- test/T090-search-output.sh | 37 + 1 file changed, 37 insertions(+) diff --git a/test/T090-search-output.sh b/test/T090-search-output.sh index 947d572ebeff..fe2ec9af8c2a 100755 ---

[PATCH v2] configure: move make {,install} instructions to the end

2014-11-01 Thread Tomi Ollila
There was theorical possibility that writing the config files could have skipped (by interruption) after the instructions how to make notmuch was printed out. --- v2 of id:1411825219-12455-1-git-send-email-tomi.oll...@iki.fi -- .gitignore change dropped (already there) -- one newline removed --

Re: [PATCH v2 0/2] cli: search --duplicate=N with --output=messages

2014-11-01 Thread Tomi Ollila
On Sat, Nov 01 2014, Jani Nikula j...@nikula.org wrote: This is v2 of [1], rebased, tests added, no functional changes. Applies cleanly, tests pass. my own tests works as expected. +1 Tomi BR, Jani. [1] id:1414705489-30771-1-git-send-email-j...@nikula.org Jani Nikula (2): cli: add

[PATCH v2 2/1] devel: man-to-mdwn.pl: add GPLv3+ notice to manpages.mdwn

2014-11-01 Thread Tomi Ollila
Make the generated head manual page (in the notmuchmail wiki) display the licence information the whole notmuch software is licenced under. --- devel/man-to-mdwn.pl | 6 ++ 1 file changed, 6 insertions(+) diff --git a/devel/man-to-mdwn.pl b/devel/man-to-mdwn.pl index

[RFC PATCH 0/2] cli: split 'notmuch address' from 'notmuch search'

2014-11-01 Thread Jani Nikula
On Sat, 01 Nov 2014, Michal Sojka sojk...@fel.cvut.cz wrote: On Sat, Nov 01 2014, Jani Nikula wrote: On Fri, 31 Oct 2014, Michal Sojka sojk...@fel.cvut.cz wrote: This option allows to configure the criterion for duplicate address filtering. Without this option, all unique combinations of name

[PATCH 02/10] cli: search: Move more variables into search_context_t

2014-11-01 Thread Michal Sojka
Just refactoring, no functional changes. --- notmuch-search.c | 49 ++--- 1 file changed, 26 insertions(+), 23 deletions(-) diff --git a/notmuch-search.c b/notmuch-search.c index c354ddc..70e7d1b 100644 --- a/notmuch-search.c +++ b/notmuch-search.c @@

[PATCH 01/10] cli: search: Rename options to context

2014-11-01 Thread Michal Sojka
Just text replacement, no other changes. --- notmuch-search.c | 136 +++ 1 file changed, 68 insertions(+), 68 deletions(-) diff --git a/notmuch-search.c b/notmuch-search.c index 671fe41..c354ddc 100644 --- a/notmuch-search.c +++

[PATCH 07/10] cli: search: Convert --output to keyword argument

2014-11-01 Thread Michal Sojka
Now, when address related outputs are in a separate command, it makes no sense to combine multiple --output options in search command line. Using switch statement to handle different outputs is more readable than a series of if statements. --- doc/man1/notmuch-search.rst | 3 ---

[PATCH 08/10] cli: address: Do not output duplicate addresses

2014-11-01 Thread Michal Sojka
This filters out duplicate addresses from address command output. It also also adds tests for the address command. The code here is an extended version of a patch from Jani Nikula. --- doc/man1/notmuch-address.rst | 2 +- notmuch-search.c | 40 -

[PATCH 06/10] cli: Introduce notmuch address command

2014-11-01 Thread Michal Sojka
This moves address-related functionality from search command to the new address command. The implementation shares almost all code and some command line options. Options --offset and --limit were intentionally not included in the address command, because they refer to messages numbers, which

[PATCH 03/10] cli: search: Convert ctx. to ctx-

2014-11-01 Thread Michal Sojka
Mostly text replacement. --- notmuch-search.c | 77 1 file changed, 39 insertions(+), 38 deletions(-) diff --git a/notmuch-search.c b/notmuch-search.c index 70e7d1b..ad7a92a 100644 --- a/notmuch-search.c +++ b/notmuch-search.c @@ -453,7

[PATCH 09/10] cli: address: Add --output=count

2014-11-01 Thread Michal Sojka
This output prints how many times was each address encountered during search. --- completion/notmuch-completion.bash | 2 +- completion/notmuch-completion.zsh | 2 +- doc/man1/notmuch-address.rst | 7 ++ notmuch-search.c | 49 --

[PATCH 05/10] cli: add support for hierarchical command line option arrays

2014-11-01 Thread Michal Sojka
From: Jani Nikula j...@nikula.org NOTMUCH_OPT_INHERIT expects a notmuch_opt_desc_t * pointer in output_var. --- command-line-arguments.c | 14 -- command-line-arguments.h | 1 + 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/command-line-arguments.c

[PATCH 04/10] cli: search: Split notmuch_search_command to smaller functions

2014-11-01 Thread Michal Sojka
In the next commit, these functions will be used to share some functionality between search and address commands. --- notmuch-search.c | 155 ++- 1 file changed, 86 insertions(+), 69 deletions(-) diff --git a/notmuch-search.c b/notmuch-search.c

[PATCH 00/10] notmuch address command

2014-11-01 Thread Michal Sojka
Hi all, this patch series is continuation of address output patches [1] and applies on current master. It is based on Jani's idea to have new command notmuch address, but share the implementation with search [2]. I tried to do it in a bit more cleaner way than Jani's RFC. In particular I wanted

Re: [PATCH v6 6/7] cli: search: Add --output=count

2014-11-01 Thread Michal Sojka
On Sat, Nov 01 2014, Mark Walters wrote: On Fri, 31 Oct 2014, Michal Sojka sojk...@fel.cvut.cz wrote: This output can be used with --output=recipients or --output=sender and in addition to the addresses, it prints how many times was each address encountered during search. Hi I have a