Jinwoo Lee writes:
> Thanks for the review, guys. Sent yet another patch. BTW I'm not sure
> if I should specify --in-reply-to when sending updates.
>
> -jinwoo
It's up to you. I generally specify in-reply-to unless the thread alread
seems too long.
d
Jinwoo Lee writes:
> And what's the process for checking the code in? I just push to the
> repo?
>
> -jinwoo
Hi Jinwoo;
I pushed it. We're pretty miserly with push access, but once you get
through the reviews, getting the code in is quick.
Welcome aboard ;).
d
On Mon, Feb 02 2015, Jinwoo Lee wrote:
> It's default value is ".", meaning all remote images will be blocked
> by default.
>
> ---
> Addressed review comments.
Ok, looks good to me. David can perhaps amend away the (accidental)
whitespace change in the last hunk ?
Tomi
> ---
>
On Mon, Feb 2, 2015 at 02:15 PM, David Bremner wrote:
> Jinwoo Lee writes:
>
>> And what's the process for checking the code in? I just push to the
>> repo?
>>
>> -jinwoo
>
> Hi Jinwoo;
>
> I pushed it. We're pretty miserly with push access, but once you get
> through the reviews, getting the
And what's the process for checking the code in? I just push to the
repo?
-jinwoo
It's default value is ".", meaning all remote images will be blocked
by default.
---
Addressed review comments.
---
emacs/notmuch-show.el | 24 +---
1 file changed, 17 insertions(+), 7 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index
On Mon, Feb 2, 2015 at 12:32 PM, Tomi Ollila wrote:
> On Mon, Feb 02 2015, Jinwoo Lee wrote:
>
>> It's default value is ".", meaning all remote images will be blocked
>> by default.
>>
>> ---
>> Addressed review comments.
>
> Ok, looks good to me. David can perhaps amend away the (accidental)
>
Thanks for the review, guys. Sent yet another patch. BTW I'm not sure
if I should specify --in-reply-to when sending updates.
-jinwoo
It's default value is ".", meaning all remote images will be blocked
by default.
---
Addressed review comments.
---
emacs/notmuch-show.el | 27 +++
1 file changed, 19 insertions(+), 8 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index
And what's the process for checking the code in? I just push to the
repo?
-jinwoo
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch
Jinwoo Lee jinwo...@gmail.com writes:
Thanks for the review, guys. Sent yet another patch. BTW I'm not sure
if I should specify --in-reply-to when sending updates.
-jinwoo
It's up to you. I generally specify in-reply-to unless the thread alread
seems too long.
d
On Mon, Feb 2, 2015 at 02:15 PM, David Bremner da...@tethera.net wrote:
Jinwoo Lee jinwo...@gmail.com writes:
And what's the process for checking the code in? I just push to the
repo?
-jinwoo
Hi Jinwoo;
I pushed it. We're pretty miserly with push access, but once you get
through the
Jinwoo Lee jinwo...@gmail.com writes:
And what's the process for checking the code in? I just push to the
repo?
-jinwoo
Hi Jinwoo;
I pushed it. We're pretty miserly with push access, but once you get
through the reviews, getting the code in is quick.
Welcome aboard ;).
d
It's default value is ., meaning all remote images will be blocked
by default.
---
Addressed review comments.
---
emacs/notmuch-show.el | 24 +---
1 file changed, 17 insertions(+), 7 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index
On Mon, Feb 02 2015, Jinwoo Lee jinwo...@gmail.com wrote:
It's default value is ., meaning all remote images will be blocked
by default.
---
Addressed review comments.
Ok, looks good to me. David can perhaps amend away the (accidental)
whitespace change in the last hunk ?
Tomi
---
On Mon, Feb 2, 2015 at 12:32 PM, Tomi Ollila tomi.oll...@iki.fi wrote:
On Mon, Feb 02 2015, Jinwoo Lee jinwo...@gmail.com wrote:
It's default value is ., meaning all remote images will be blocked
by default.
---
Addressed review comments.
Ok, looks good to me. David can perhaps amend
Hi Franz,
We already had folding via syntax in Ians fork. It turned out to be not that
great.
https://github.com/imain/notmuch-vim/issues/3
Ah all right, I just thought syntax fold would be more elegant.
In short:
Those syntax fold marks are for one specific notmuch-show-buffer. If you
I think the API should be clear and easy to understand, because people will
probably bind them to custom shortcuts. You should not have to think about
what that weird extra parameter (-1, false, ...) means and go read the docs.
I agree. One might replace the parameter with a string like prev
Franz Fellner wrote:
Hi Bartosz,
Great to see one more person interested in notmuch-vim! Hopefully this will
make review a little bit easier.
Bartosz Telenczuk wrote:
Ian Main wrote:
This patch makes the folder screen refresh each time you 'enter' it.
This way when you read a
I would appreciate an option to configure the sent box per provider. I
implemented this feature in this patch:
id:1420891384-992-4-git-send-email-telenc...@unic.cnrs-gif.fr
Generally it might work. But there are other features that may rely on
per-account-settings (drafts, outbox,
It's default value is ., meaning all remote images will be blocked
by default.
---
Addressed review comments.
---
emacs/notmuch-show.el | 27 +++
1 file changed, 19 insertions(+), 8 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index
Thanks for the review, guys. Sent yet another patch. BTW I'm not sure
if I should specify --in-reply-to when sending updates.
-jinwoo
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch
22 matches
Mail list logo
