[PATCH] go: add binding for notmuch_message_get_date

2015-03-03 Thread David Bremner
Tomi Ollila writes: >On Mon, Mar 02 2015, Trevor Jim wrote: >> >> -// TODO: wrap notmuch_message_get_date >> +func (self *Message) GetDate() int64 { >> +if self.message == nil { >> +return -1 > > -1 is 1969-dec-31 23:59:59 UTC > > Should we care -- and e.g. return status in

[PATCH] go: add binding for notmuch_message_get_date

2015-03-03 Thread Tomi Ollila
On Mon, Mar 02 2015, Trevor Jim wrote: > --- > bindings/go/src/notmuch/notmuch.go | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/bindings/go/src/notmuch/notmuch.go > b/bindings/go/src/notmuch/notmuch.go > index b9230ad..f5fd54c 100644 > ---

[PATCH] go: add binding for notmuch_message_get_date

2015-03-03 Thread Trevor Jim
> -1 is 1969-dec-31 23:59:59 UTC > > Should we care -- and e.g. return status in separate return value ? BTW, I notice that when a message has no Date: field, notmuch reports its timestamp as 0 without reporting an error :-) -Trevor

[PATCH] go: add binding for notmuch_message_get_date

2015-03-03 Thread Trevor Jim
> Given the current troubles with the main library API and missing status > values, I'd say in the long run we'll be happier with a real status > return. OTOH, I don't much about go. I'm not sure what the "current troubles" are (happy to hear more), but the way I've handled the nil case is in

Re: [PATCH] go: add binding for notmuch_message_get_date

2015-03-03 Thread Tomi Ollila
On Mon, Mar 02 2015, Trevor Jim t...@mac.com wrote: --- bindings/go/src/notmuch/notmuch.go | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/bindings/go/src/notmuch/notmuch.go b/bindings/go/src/notmuch/notmuch.go index b9230ad..f5fd54c 100644 ---

Re: [PATCH] go: add binding for notmuch_message_get_date

2015-03-03 Thread Trevor Jim
Given the current troubles with the main library API and missing status values, I'd say in the long run we'll be happier with a real status return. OTOH, I don't much about go. I'm not sure what the current troubles are (happy to hear more), but the way I've handled the nil case is in keeping

Re: [PATCH] go: add binding for notmuch_message_get_date

2015-03-03 Thread Trevor Jim
-1 is 1969-dec-31 23:59:59 UTC Should we care -- and e.g. return status in separate return value ? BTW, I notice that when a message has no Date: field, notmuch reports its timestamp as 0 without reporting an error :-) -Trevor ___ notmuch mailing