[PATCH 2/2] emacs: prefer notmuch-emacs-version in User-Agent: header

2015-08-02 Thread Tomi Ollila
Now that we have `notmuch-emacs-version' defined in notmuch emacs MUA use that as a part of User-Agent: header to provide more accurate version information when sending emails. In case some incomplete installation of notmuch emacs MUA is used and `notmuch-emacs-version' is defined as "unknown"

[PATCH 1/2] emacs: renamed function notmuch-version to notmuch-cli-version

2015-08-02 Thread Tomi Ollila
As it asks `notmuch` binary for its version number. --- This is 3rd revision, previous in id:1426932955-23174-1-git-send-email-tomi.ollila at iki.fi emacs/notmuch-hello.el | 2 +- emacs/notmuch-lib.el | 4 ++-- emacs/notmuch-mua.el | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-)

[PATCH] devel/release-checks: added checking of copyright year in documentation

2015-08-02 Thread Tomi Ollila
Check that copyright year will be current year in generated documentation. The checking is done my matching that copyright line contains current year as a substring which is good enough "approximation" in this context. --- devel/release-checks.sh | 12 1 file changed, 12

[PATCH] devel/release-checks.sh: made python version check work with python 3

2015-08-02 Thread Tomi Ollila
This trivial change consists of just putting print() argument in parentheses. --- devel/release-checks.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/devel/release-checks.sh b/devel/release-checks.sh index efd0b3441f2e..bf0d68a444b6 100755 --- a/devel/release-checks.sh +++

[PATCH] custom search prefix

2015-08-02 Thread David Bremner
Hi Sebastian; Sorry this sat so long in the queue. I agree it doesn't cost much to add it, but offhand I'm not sure what the use case is. It would be be good to (briefly) mention this in the commit message and also expand the docstring for the variable a bit, since this is currently our only

[PATCH] notmuch-emacs-mua: do not start emacs daemon w/o --create-frame

2015-08-02 Thread David Bremner
Tomi Ollila writes: > notmuch-emacs-mua --client used to start daemon process if it was > not running -- just that no emacs mail window of any kind from > that is visible to the user. > > When not starting emacs server in this case notmuch-emacs-mua > user will get the same message as would

[PATCH v2] cli/new: add more debugging output

2015-08-02 Thread Tomi Ollila
On Sun, Aug 02 2015, David Bremner wrote: > Try to narrow down what part of the code adds files and directories to > the queue(s) to be deleted. > --- Looks trivial enough to me. +1 Tomi > > - print slightly less scary messages > - use git-send-email to send > > notmuch-new.c | 14

[PATCH] test: use the python interpreter in sh.config

2015-08-02 Thread Tomi Ollila
On Sun, Aug 02 2015, David Bremner wrote: > The configure script chooses "python" if both python and python{2,3} > exist exists, so this could change the version of python used to run > the test suite. LGTM. tests pass. > > The checking for ${NOTMUCH_PYTHON} in the test suite is arguably >

[PATCH v2] cli/new: add more debugging output

2015-08-02 Thread David Bremner
Try to narrow down what part of the code adds files and directories to the queue(s) to be deleted. --- - print slightly less scary messages - use git-send-email to send notmuch-new.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/notmuch-new.c b/notmuch-new.c index

[PATCH] test: use the python interpreter in sh.config

2015-08-02 Thread David Bremner
The configure script chooses "python" if both python and python{2,3} exist exists, so this could change the version of python used to run the test suite. The checking for ${NOTMUCH_PYTHON} in the test suite is arguably over-engineering, since the configure step will fail if it can't find it. ---

[PATCH v2] cli/new: add more debugging output

2015-08-02 Thread David Bremner
Try to narrow down what part of the code adds files and directories to the queue(s) to be deleted. --- - print slightly less scary messages - use git-send-email to send notmuch-new.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/notmuch-new.c b/notmuch-new.c index

Re: [PATCH v2] cli/new: add more debugging output

2015-08-02 Thread Tomi Ollila
On Sun, Aug 02 2015, David Bremner da...@tethera.net wrote: Try to narrow down what part of the code adds files and directories to the queue(s) to be deleted. --- Looks trivial enough to me. +1 Tomi - print slightly less scary messages - use git-send-email to send notmuch-new.c |

[PATCH] test: use the python interpreter in sh.config

2015-08-02 Thread David Bremner
The configure script chooses python if both python and python{2,3} exist exists, so this could change the version of python used to run the test suite. The checking for ${NOTMUCH_PYTHON} in the test suite is arguably over-engineering, since the configure step will fail if it can't find it. ---

Re: [PATCH] test: use the python interpreter in sh.config

2015-08-02 Thread Tomi Ollila
On Sun, Aug 02 2015, David Bremner da...@tethera.net wrote: The configure script chooses python if both python and python{2,3} exist exists, so this could change the version of python used to run the test suite. LGTM. tests pass. The checking for ${NOTMUCH_PYTHON} in the test suite is

[PATCH] devel/release-checks: added checking of copyright year in documentation

2015-08-02 Thread Tomi Ollila
Check that copyright year will be current year in generated documentation. The checking is done my matching that copyright line contains current year as a substring which is good enough approximation in this context. --- devel/release-checks.sh | 12 1 file changed, 12 insertions(+)

Re: [PATCH] custom search prefix

2015-08-02 Thread David Bremner
Hi Sebastian; Sorry this sat so long in the queue. I agree it doesn't cost much to add it, but offhand I'm not sure what the use case is. It would be be good to (briefly) mention this in the commit message and also expand the docstring for the variable a bit, since this is currently our only

[PATCH 1/2] emacs: renamed function notmuch-version to notmuch-cli-version

2015-08-02 Thread Tomi Ollila
As it asks `notmuch` binary for its version number. --- This is 3rd revision, previous in id:1426932955-23174-1-git-send-email-tomi.oll...@iki.fi emacs/notmuch-hello.el | 2 +- emacs/notmuch-lib.el | 4 ++-- emacs/notmuch-mua.el | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-)

[PATCH 2/2] emacs: prefer notmuch-emacs-version in User-Agent: header

2015-08-02 Thread Tomi Ollila
Now that we have `notmuch-emacs-version' defined in notmuch emacs MUA use that as a part of User-Agent: header to provide more accurate version information when sending emails. In case some incomplete installation of notmuch emacs MUA is used and `notmuch-emacs-version' is defined as unknown then

Re: [PATCH] notmuch-emacs-mua: do not start emacs daemon w/o --create-frame

2015-08-02 Thread David Bremner
Tomi Ollila tomi.oll...@iki.fi writes: notmuch-emacs-mua --client used to start daemon process if it was not running -- just that no emacs mail window of any kind from that is visible to the user. When not starting emacs server in this case notmuch-emacs-mua user will get the same message