Re: problems with nmbug and empty prefix (UnicodeWarning and broken pipe)

On Sat, Feb 13, 2016 at 10:41:40PM -0400, David Bremner wrote: > Traceback (most recent call last): > File "/home/bremner/.config/scripts/nmbug.real", line 834, in > args.func(**kwargs) > File "/home/bremner/.config/scripts/nmbug.real", line 324, in commit > status = get_status() > F

Re: problems with nmbug and empty prefix (UnicodeWarning and broken pipe)

"W. Trevor King" writes: > > $ nmbug --log-level debug commit > > which will give us the full traceback. > Traceback (most recent call last): File "/home/bremner/.config/scripts/nmbug.real", line 834, in args.func(**kwargs) File "/home/bremner/.config/scripts/nmbug.real", line 324, in

Re: nmbug in the Debian packages?

"W. Trevor King" writes: > I'd floated notmuch-dtag earlier [1]. Does that sound right? Or do > folks prefer another name? I'd like to hear feedback from others about that. >> It would also need some tests. > > In tests/, or devel/dtag/tests? If the latter, how should I handle > the test fra

Re: problems with nmbug and empty prefix (UnicodeWarning and broken pipe)

On Sat, Feb 13, 2016 at 03:10:16PM -0400, David Bremner wrote: > bremner@zancas:~$ export NMBGIT=/tmp/nmbug > bremner@zancas:~$ export NMBPREFIX="" > bremner@zancas:~$ nmbug commit > /usr/lib/python2.7/urllib.py:1303: UnicodeWarning: Unicode equal comparison > failed to convert both arguments to U

Re: nmbug in the Debian packages?

On Sat, Feb 13, 2016 at 02:17:44PM -0400, David Bremner wrote: > > On Mon, Feb 08, 2016 at 07:33:10AM -0400, David Bremner wrote: > >> We can include it in /usr/bin along and install a proper man page… > > > > I'm happy to write up a man page. Do you want it in a separate > > directory from nmbug-

problems with nmbug and empty prefix

Currently nmbug doesn't seem to work with an empty prefix for me. ╭─ zancas:~ ╰─% bash bremner@zancas:~$ export NMBGIT=/tmp/nmbug bremner@zancas:~$ export NMBPREFIX="" bremner@zancas:~$ nmbug commit /usr/lib/python2.7/urllib.py:1303: UnicodeWarning: Unicode equal comparison failed to convert bo

Re: nmbug in the Debian packages?

"W. Trevor King" writes: > On Mon, Feb 08, 2016 at 07:33:10AM -0400, David Bremner wrote: >> We can include it in /usr/bin along and install a proper man page… > > I'm happy to write up a man page. Do you want it in a separate > directory from nmbug-status / notmuch-report [1]? Do you want to >

Re: [PATCH v3 15/16] added notmuch_message_reindex

Daniel Kahn Gillmor writes: > > I think when a message is removed from the database, we need to know > whether anything else (in its same thread?) refers to it. If so, we > should keep it around as a ghost message instead of fully removing it. > > does this sound like the right approach? > This

[PATCH 1/2] STYLE: document some rules about variable declarations

No-one seemed opposed to C99 style loop variable declarations. The requirement to declare variables at the top of blocks is maybe a little more contested, but I believe it reflects the status quo. --- devel/STYLE | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/devel/STYL

[PATCH 2/2] STYLE: suggest long names

Hopefully the exceptions are common sense. --- devel/STYLE | 4 1 file changed, 4 insertions(+) diff --git a/devel/STYLE b/devel/STYLE index b22d8d3..da65312 100644 --- a/devel/STYLE +++ b/devel/STYLE @@ -71,6 +71,10 @@ Naming * Use lowercase_with_underscores for function, variable, and typ

Re: [PATCH v5 3/3] emacs: Bind filter in search to 'l'

Mark Walters writes: > Change the key binding for filter (or "limit") in search-mode. This > gives consistency with the new filter in show-mode, and frees 'f' for > forward-thread in the future. Pushed. It occurs to me this deserves a NEWS entry. d __

Re: [PATCH] configure: pass HAVE_TIMEGM to build

Tomi Ollila writes: > Checking the existence of timegm() function and setting > configure internal variable ${have_timegm} was done, but > actually defining HAVE_TIMEGM in build was not done -- > meaning that compat timegm() was always part of final > notmuch binaries. pushed, d ___

Re: [PATCH 2/3] test: fix typo in informational message

David Bremner writes: > Thanks to Olly Betts for noticing > --- > test/Makefile.local | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/test/Makefile.local b/test/Makefile.local > index 2b18691..30d420e 100644 > --- a/test/Makefile.local > +++ b/test/Makefile.local > @@ -5

Re: [PATCH v1] emacs: Fix compiler warnings.

David Edmondson writes: > notmuch-mua.el should declare functions that it uses from > notmuch-maildir-fcc.el. > --- > emacs/notmuch-mua.el | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el > index 5462f54..d4fad7b 100644 > --- a/emacs/notmuch-

Re: [PATCH] emacs: hello: tell the user about help and notmuch customization

Jani Nikula writes: > Make it easier for new users to find out about thing in notmuch-emacs. > --- > emacs/notmuch-hello.el | 11 +-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el > index b42e0f24148a..738baad23b20 1006