Notmuch dev workflow: applying patches to local trees

2016-11-07 Thread Matt Armstrong
I'm not experienced with managing patches via email on this list, especially when it comes to applying patches sent out for review and testing. Is there a documented best practice? Ideally, I'd like a "dwim" command that does something reasonable, such as take messages from the current thread

Re: [PATCH] emacs: mua: add a pre-send-check-hook

2016-11-07 Thread Matt Armstrong
Hey Mark, For consistency with Emacs' own elisp, perhaps rename notmuch-mua-pre-send-check-hooks to notmuch-mua-pre-send-check-functions? This patch reminded me of a recent discussion on emacs-devel about the definition of "hook" in Emacs code and documentation. There is the broad meaning of

Re: [Patch v5 3/4] emacs: check drafts for encryption tags before saving

2016-11-07 Thread Mark Walters
On Mon, 07 Nov 2016, David Bremner wrote: > In general the user may not want to save plaintext copies of messages > that they are sending encrypted, so give them a chance to abort. > --- > emacs/notmuch-draft.el | 40 >

[Patch v5 1/4] emacs: tree: remove binding for pressing button in message pane

2016-11-07 Thread David Bremner
From: Mark Walters We want to use "e" for editting postponed messages in show, and in tree view, so remove the binding for the function which does (In message pane) Activate BUTTON or button at point --- emacs/notmuch-tree.el | 1 - 1 file changed, 1 deletion(-)

v5 emacs postpone/resume patches

2016-11-07 Thread David Bremner
This obsoletes id:20161106121501.11062-2-da...@tethera.net The actual net diff is the same, except for adding some tests. The changes have been broken up into smaller pieces to make review easier. ___ notmuch mailing list notmuch@notmuchmail.org

[Patch v5 2/4] emacs: postpone a message

2016-11-07 Thread David Bremner
From: Mark Walters This provides initial support for postponing in the emacs frontend; resuming will follow in a later commit. On saving/postponing it uses notmuch insert to put the message in the notmuch database Current bindings are C-x C-s to save a draft, C-c C-p

[Patch v5 4/4] emacs: resume messages

2016-11-07 Thread David Bremner
Provide functionality to resume editing a mesage previously saved with notmuch-draft-save, including decoding the X-Notmuch-Emacs-Secure header. Resume gets the raw file from notmuch and using the emacs function mime-to-mml reconstructs the message (including attachments). 'e' is bound to resume

[Patch v5 3/4] emacs: check drafts for encryption tags before saving

2016-11-07 Thread David Bremner
In general the user may not want to save plaintext copies of messages that they are sending encrypted, so give them a chance to abort. --- emacs/notmuch-draft.el | 40 test/T630-emacs-draft.sh | 13 + 2 files changed, 53 insertions(+) diff