[PATCH] fix "shadow build"

2016-11-13 Thread Tomi Ollila
With working tests. --- Some day we dump `find_notmuch_path()` configure | 6 -- test/test-lib-common.sh | 2 ++ test/test-lib.sh| 6 +++--- 3 files changed, 9 insertions(+), 5 deletions(-) diff --git a/configure b/configure index 2a0ce9e..05b964d 100755 ---

[Travis CI] Broken: notmuch/notmuch#283 (master - 2dd96d6)

2016-11-13 Thread David Bremner
I'm fairly sure these test failures are emacs 23 specific. In particular I tested on debian jessie with on old install of emacs23 and I can replicate them, but not if I switch to emacs24. The tests also fail under emacs23 with id:1477191835-17828-1-git-send-email-markwalters1...@gmail.com

Re: [PATCH v7 0/4] emacs postpone/resume patches

2016-11-13 Thread David Bremner
Mark Walters writes: > The previous version of this series is at > id:1479036106-32453-1-git-send-email-markwalters1...@gmail.com > > The only change is for the error handling for resume. In show mode is > is actually simpler than before -- notmuch-show-get-message-id

Re: [PATCH] emacs: rename notmuch-address-completion-hook to notmuch-address-post-completion-functions

2016-11-13 Thread David Bremner
David Bremner writes: > Apparently it is a (not completely adhered to) emacs convention [1] that > only hooks that don't take arguments end in 'hook' > > [1]: https://www.gnu.org/software/emacs/manual/html_node/elisp/Hooks.html > --- pushed to master

[PATCH v7 3/4] emacs: check drafts for encryption tags before saving

2016-11-13 Thread Mark Walters
From: David Bremner In general the user may not want to save plaintext copies of messages that they are sending encrypted, so give them a chance to abort. --- emacs/notmuch-draft.el | 39 +++ test/T630-emacs-draft.sh | 13 + 2

[PATCH v7 4/4] emacs: resume messages

2016-11-13 Thread Mark Walters
From: David Bremner Provide functionality to resume editing a message previously saved with notmuch-draft-save, including decoding the X-Notmuch-Emacs-Secure header. Resume gets the raw file from notmuch and using the emacs function mime-to-mml reconstructs the message

[PATCH v7 0/4] emacs postpone/resume patches

2016-11-13 Thread Mark Walters
The previous version of this series is at id:1479036106-32453-1-git-send-email-markwalters1...@gmail.com The only change is for the error handling for resume. In show mode is is actually simpler than before -- notmuch-show-get-message-id will always return an id, so we don't need to check for

[PATCH v7 2/4] emacs: postpone a message

2016-11-13 Thread Mark Walters
This provides initial support for postponing in the emacs frontend; resuming will follow in a later commit. On saving/postponing it uses notmuch insert to put the message in the notmuch database Current bindings are C-x C-s to save a draft, C-c C-p to postpone a draft (save and exit compose

[PATCH v7 1/4] emacs: tree: remove binding for pressing button in message pane

2016-11-13 Thread Mark Walters
We want to use "e" for editting postponed messages in show, and in tree view, so remove the binding for the function which does (In message pane) Activate BUTTON or button at point --- emacs/notmuch-tree.el | 1 - 1 file changed, 1 deletion(-) diff --git a/emacs/notmuch-tree.el

Re: [PATCH v6 0/4] emacs postpone/resume patches

2016-11-13 Thread David Bremner
Mark Walters writes: > This version 6 of this series. The previous version is at > id:20161107125211.23405-1-da...@tethera.net > > This addresses the review comments on the previous version, adds a > couple of "requires" to fix some compile warnings, and1 updates on >

Re: [Patch v5 4/4] emacs: resume messages

2016-11-13 Thread David Bremner
Mark Walters writes: > On Sat, 12 Nov 2016, David Bremner wrote: >>> +(defun notmuch-show-resume-message () >>> + "Resume EDITING the current draft message." >>> + (interactive) >>> + (let ((id (notmuch-show-get-message-id))) >>> +(when id

[PATCH] emacs: rename notmuch-address-completion-hook to notmuch-address-post-completion-functions

2016-11-13 Thread David Bremner
Apparently it is a (not completely adhered to) emacs convention [1] that only hooks that don't take arguments end in 'hook' [1]: https://www.gnu.org/software/emacs/manual/html_node/elisp/Hooks.html --- emacs/notmuch-address.el | 4 ++-- emacs/notmuch-company.el | 2 +- 2 files changed, 3

Re: [PATCH v4] emacs: add notmuch-address-post-completion-hook

2016-11-13 Thread Tomi Ollila
(Trying to send this w/o Mark in To: -- in the hope also Mark receive this email to his gmail account...) On Sun, Nov 13 2016, Mark Walters wrote: > On Sat, 12 Nov 2016, David Bremner wrote: >> Tomi Ollila writes: >> >>> Like

[PATCH v6 4/4] emacs: resume messages

2016-11-13 Thread Mark Walters
From: David Bremner Provide functionality to resume editing a message previously saved with notmuch-draft-save, including decoding the X-Notmuch-Emacs-Secure header. Resume gets the raw file from notmuch and using the emacs function mime-to-mml reconstructs the message

[PATCH v6 3/4] emacs: check drafts for encryption tags before saving

2016-11-13 Thread Mark Walters
From: David Bremner In general the user may not want to save plaintext copies of messages that they are sending encrypted, so give them a chance to abort. --- emacs/notmuch-draft.el | 39 +++ test/T630-emacs-draft.sh | 13 + 2

[PATCH v6 0/4] emacs postpone/resume patches

2016-11-13 Thread Mark Walters
This version 6 of this series. The previous version is at id:20161107125211.23405-1-da...@tethera.net This addresses the review comments on the previous version, adds a couple of "requires" to fix some compile warnings, and1 updates on function name which was missed previously. I also rejigged

[PATCH v6 2/4] emacs: postpone a message

2016-11-13 Thread Mark Walters
This provides initial support for postponing in the emacs frontend; resuming will follow in a later commit. On saving/postponing it uses notmuch insert to put the message in the notmuch database Current bindings are C-x C-s to save a draft, C-c C-p to postpone a draft (save and exit compose

[PATCH v6 1/4] emacs: tree: remove binding for pressing button in message pane

2016-11-13 Thread Mark Walters
We want to use "e" for editting postponed messages in show, and in tree view, so remove the binding for the function which does (In message pane) Activate BUTTON or button at point --- emacs/notmuch-tree.el | 1 - 1 file changed, 1 deletion(-) diff --git a/emacs/notmuch-tree.el

Re: [Patch v5 4/4] emacs: resume messages

2016-11-13 Thread Mark Walters
On Sat, 12 Nov 2016, David Bremner wrote: > David Bremner writes: > >> Provide functionality to resume editing a mesage previously saved with >> notmuch-draft-save, including decoding the X-Notmuch-Emacs-Secure >> header. > > s/mesage/message/ > >> +(defun

Re: [Patch v5 2/4] emacs: postpone a message

2016-11-13 Thread Mark Walters
On Sat, 12 Nov 2016, David Bremner wrote: > David Bremner writes: > >> From: Mark Walters > > This really Mark's work, that I have split out into a separate file. > >> +(defcustom notmuch-draft-tags '("+draft") >> + "List of tags