Re: [PATCH 1/3] test: shrink T590-thread-breakage test decription to one line

2017-03-04 Thread David Bremner
Jani Nikula writes: > The test description is used for log output, I think the intention is > to keep it as a one-liner. Leave the rest of the long description as a > comment. pushed this one patch to master ___ notmuch mailing list

Re: [PATCH 1/2] lib: centralize query parsing, store results.

2017-03-04 Thread David Bremner
David Bremner writes: > The main goal is to prepare the way for non-destructive (or at least > less destructive) exclude tag handling. It does this by having a > pre-parsed query available for further processing. This also allows us > to provide slightly more precise errorr

Re: [PATCH] lib: use delete[] to free buffer allocated using new[]

2017-03-04 Thread David Bremner
Jani Nikula writes: > Fix warning caught by clang: > > lib/regexp-fields.cc:41:2: warning: 'delete' applied to a pointer that was > allocated > with 'new[]'; did you mean 'delete[]'? [-Wmismatched-new-delete] > delete buffer; > ^ > [] >

Re: [PATCH v3 1/2] Test: emacs: test for folding long headers.

2017-03-04 Thread David Bremner
Mark Walters writes: > Headers of more than 998 characters should be folded when sending. > However, until recently, emacs did not do this. series pushed to master d ___ notmuch mailing list notmuch@notmuchmail.org

[PATCH v3 1/2] Test: emacs: test for folding long headers.

2017-03-04 Thread Mark Walters
Headers of more than 998 characters should be folded when sending. However, until recently, emacs did not do this. This adds a (known broken) test for this when sending messages in emacs. We will backport the fix to notmuch-emacs in the next changeset. --- test/T310-emacs.sh | 78

[PATCH v3 0/2] emacs: fold long headers when sending

2017-03-04 Thread Mark Walters
Version 2 of this series is at id:1488649637-19006-1-git-send-email-markwalters1...@gmail.com The change here is to split the folding headers function into an explicit function as this makes managing the hook simpler. Best wishes Mark Mark Walters (2): Test: emacs: test for folding long

[PATCH v3 2/2] emacs: compat: backport fix for folding long headers when sending

2017-03-04 Thread Mark Walters
This backports the fix from emacs master (commit 77bbca8c82f6e553c42abbfafca28f55fc995d00) to notmuch-emacs to wrap long headers. This fixes the test introduced in the previous changeset. --- emacs/notmuch-compat.el | 28 1 file changed, 24 insertions(+), 4

Re: [PATCH v2 2/2] emacs: compat: backport fix for folding long headers when sending

2017-03-04 Thread David Bremner
Mark Walters writes: > This backports the fix from emacs master (commit > 77bbca8c82f6e553c42abbfafca28f55fc995d00) to notmuch-emacs to wrap > long headers. > > This fixes the test introduced in the previous changeset. > --- > emacs/notmuch-compat.el | 28

Re: [PATCH v2 1/2] Test: emacs: test for folding long headers.

2017-03-04 Thread David Bremner
Mark Walters writes: > Headers of more than 998 characters should be folded when sending. > However, until recently, emacs did not do this. > > This adds a (known broken) test for this when sending messages in > emacs. We will backport the fix to notmuch-emacs in the

[PATCH v2 0/2] emacs: fold long headers when sending

2017-03-04 Thread Mark Walters
The only change from v1 (at id:1485684281-2760-1-git-send-email-markwalters1...@gmail.com ) is an updated test as suggested by Domo using echo {1..1000} instead of seq. Best wishes Mark Mark Walters (2): Test: emacs: test for folding long headers. emacs: compat: backport fix for folding

[PATCH v2 2/2] emacs: compat: backport fix for folding long headers when sending

2017-03-04 Thread Mark Walters
This backports the fix from emacs master (commit 77bbca8c82f6e553c42abbfafca28f55fc995d00) to notmuch-emacs to wrap long headers. This fixes the test introduced in the previous changeset. --- emacs/notmuch-compat.el | 28 1 file changed, 24 insertions(+), 4

[PATCH v2 1/2] Test: emacs: test for folding long headers.

2017-03-04 Thread Mark Walters
Headers of more than 998 characters should be folded when sending. However, until recently, emacs did not do this. This adds a (known broken) test for this when sending messages in emacs. We will backport the fix to notmuch-emacs in the next changeset. --- test/T310-emacs.sh | 78

[PATCH] lib: use delete[] to free buffer allocated using new[]

2017-03-04 Thread Jani Nikula
Fix warning caught by clang: lib/regexp-fields.cc:41:2: warning: 'delete' applied to a pointer that was allocated with 'new[]'; did you mean 'delete[]'? [-Wmismatched-new-delete] delete buffer; ^ [] lib/regexp-fields.cc:37:17: note: allocated with 'new[]' here

Re: Github an licensing

2017-03-04 Thread Mark Walters
> On irc rlb pointed me to > https://joeyh.name/blog/entry/removing_everything_from_github/ > > IANAL so I don't know whether it is a real problem, a hypothetical > problem or not a problem. I got a couple of links sent to me privately which look relevant: *

Github an licensing

2017-03-04 Thread Mark Walters
Dear All On irc rlb pointed me to https://joeyh.name/blog/entry/removing_everything_from_github/ IANAL so I don't know whether it is a real problem, a hypothetical problem or not a problem. My guess is that it can't affect the main notmuch license as the bulk of notmuch's copyright is owned by

Re: some issues with emacs 25

2017-03-04 Thread David Bremner
David Bremner writes: > Matthew Lear writes: > > >> Thanks David. Yes it does. After recompiling the v25 lisp with these >> changes, I'm unable to reproduce the problems with both the test emails I >> sent you. Wonderful :-) >> Are you going to raise