Re: fix for maildir synced tags in new.tags

2017-08-30 Thread David Bremner
David Bremner writes: > As I mentioned in [1], it's currently not possible to have maildir > synced tags like 'flagged' in new.tags, which blocks some ideas about > synching tags via maildir (in addition to just being a bug). > > This series fixes that. As I write this I remember that it doesn't

Re: [Patch v2] build: add target to run cppcheck

2017-08-30 Thread David Bremner
Jani Nikula writes: > > I thought the quiet build lines like > > CPPCHECK .stamps/cppcheck/util/error_util.c > > were a bit ugly, so I came up with [1]. With that plus this change: > > - $(call quiet,CPPCHECK) --template=gcc --error-exitcode=1 --quiet $< > + $(call quiet,CPPCHECK,$<) --tem

Re: [PATCH 1/3] build: avoid an extra shell out in quiet variable function

2017-08-30 Thread David Bremner
Jani Nikula writes: > $(word 1, $1) yields the same result as the more complicated > $(shell echo $1 | sed -e s'/ .*//') series pushed. d ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 0/7] Travis and test suite improvements

2017-08-30 Thread David Bremner
David Bremner writes: > Vladimir Panteleev writes: > >> Test more things better on Travis CI, and fix things in the test suite >> that did not run properly on Travis CI. >> > > I've pushed the first 5 in the series. I haven't had a chance to review > the last two yet. > > d Ah right now I remem

Re: [PATCH 0/7] Travis and test suite improvements

2017-08-30 Thread David Bremner
Vladimir Panteleev writes: > Test more things better on Travis CI, and fix things in the test suite > that did not run properly on Travis CI. > I've pushed the first 5 in the series. I haven't had a chance to review the last two yet. d ___ notmuch mai

Re: [PATCH 2/3] build: add optional target parameter to quiet variable function

2017-08-30 Thread David Bremner
Jani Nikula writes: > We could also remove the default, and have all callers of quiet pass in > $< or $@ or whatever as part of the first parameter. It's more verbose > everywhere, but I think simpler overall. Since I've got a rebased version of my patch on top of your existing proposal to add a

Re: [PATCH 2/3] build: add optional target parameter to quiet variable function

2017-08-30 Thread Jani Nikula
On Tue, 29 Aug 2017, David Bremner wrote: > Jani Nikula writes: > >> Sometimes using $@ as the target in the quiet build lines can be >> confusing. Accept an optional second parameter in the quiet variable >> function to specify the target. > > I'm OK with this, but I wondered about a simpler cha

[PATCH v2] python: deprecated add_message calls index_file correctly and returns result

2017-08-30 Thread Gaute Hope
The deprecated Database.add_message now calls the new index_file with correct number of arguments (without an extra `self`), and returns the tuple from index_file - as it used to do before. This change also adds a DeprecationWarning to the function. --- bindings/python/notmuch/database.py | 6 +++

Re: Colorized git-format-patches in notmuch-show?

2017-08-30 Thread Jani Nikula
On Wed, Aug 30, 2017 at 8:55 AM, William Casarin wrote: > I'm not sure if this is an option somewhere, but is there a way to > colorize git-format-patch emails in the notmuch-show buffer? I noticed > it works fine if it's an attachment, but not if it's a git-submitted > patch. Try M-x customize-v

Re: [PATCH] python: deprecated add_message calls index_file correctly and returns result

2017-08-30 Thread Tomi Ollila
On Wed, Aug 30 2017, Gaute Hope wrote: > Tomi Ollila writes on august 30, 2017 0:00: >> On Mon, Aug 28 2017, Gaute Hope wrote: >> >>> The deprecated Database.add_message now calls the new index_file with >>> correct number of arguments (without an extra `self`), and returns the >>> tuple from inde