Re: Washing GitHub emails to include inline patch?

William Casarin writes: > This worked pretty well, I've modified it a bit to support a generic > github repo location which is parsed from the subject, Great, glad you were able to tweak that test function into something that works well with your setup. > and origin/master

Re: cleartext indexing, round 3

Daniel Kahn Gillmor writes: > What follows is the third round of the latest revision of cleartext > indexing patches. pushed patches 1,2,3, and 5 to master. d ___ notmuch mailing list notmuch@notmuchmail.org

Re: [PATCH v3 10/15] crypto: index encrypted parts when indexopts try_decrypt is set.

Daniel Kahn Gillmor writes: > + if (status) { > + _notmuch_database_log (notmuch, "Warning: setup failed for > decrypting " > +"during indexing. (%d)\n", status); > + status = notmuch_message_add_property (message,

Re: Washing GitHub emails to include inline patch?

Kyle Meyer writes: > --8<---cut here---start->8--- > > (defun km/notmuch-github-pr-number () > "Return the PR number for this message." > (let (pr) > (with-current-notmuch-show-message > (goto-char (point-min)) > (if

Re: [PATCH v4 08/15] index: implement notmuch_indexopts_t with try_decrypt

On Thu 2017-10-12 08:18:15 -0300, David Bremner wrote: > Daniel Kahn Gillmor writes: > >> >> +if (!indexopts) >> +indexopts = def_indexopts = notmuch_database_get_default_indexopts >> (notmuch); >> + > > I think I'd like parens here > > indexopts =

Re: [PATCH v3 04/15] crypto: move into libutil

Hi Bremner-- Thanks for the review! On Thu 2017-10-12 07:54:33 -0300, David Bremner wrote: > Daniel Kahn Gillmor writes: > >> This prepares us for using the crypto object in both the library and >> the client. > > I think we could be more precise about names here, to

Re: [PATCH v4 08/15] index: implement notmuch_indexopts_t with try_decrypt

Daniel Kahn Gillmor writes: > > + if (!indexopts) > + indexopts = def_indexopts = notmuch_database_get_default_indexopts > (notmuch); > + I think I'd like parens here indexopts = (def_indexopts = notmuch_database_get_default_indexopts (notmuch)); or

Re: [PATCH v3 04/15] crypto: move into libutil

Daniel Kahn Gillmor writes: > This prepares us for using the crypto object in both the library and > the client. I think we could be more precise about names here, to help outsiders get up to speed on the code. libutil was renamed to libnotmuch_util, and "the library"