Re: [PATCH 1/3] cli: add support for --no- prefixed boolean and keyword flag arguments

Tested ACK 1-3 + id:20171014201836.4486-1-j...@nikula.org ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 1/3] cli: add support for --no- prefixed boolean and keyword flag arguments

Jani Nikula writes: > *blush* I screwed those enums up. Here's a patch that takes care of both > issues id:20171014201836.4486-1-j...@nikula.org. It's independent of > this series. Works, thanks. -- https://jb55.com ___ notmuch

Re: [PATCH 1/3] cli: add support for --no- prefixed boolean and keyword flag arguments

On Sat, 14 Oct 2017, William Casarin wrote: > Hey Jani, > > Patches look good so far, concept ack for sure. > > > Jani Nikula writes: > >> For example, you can use --no-exclude instead of --exclude=false in >> notmuch show. If we had keyword flag arguments with

[PATCH] cli: make notmuch count --exclude a boolean argument

Commit 0f314c0c99be ("cli: convert notmuch_bool_t to stdbool") over-eagerly converted EXCLUDE_TRUE and EXCLUDE_FALSE to EXCLUDE_true and EXCLUDE_false in notmuch-count.c. We could just fix the case back, but convert the option to an actual boolean argument instead. We've used a keyword argument

Re: [bug] [emacs] notmuch-show: names not shown on some mailing lists

Nevermind, the issue seems to go away on master Sorry for the noise... ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH 1/3] cli: add support for --no- prefixed boolean and keyword flag arguments

Hey Jani, Patches look good so far, concept ack for sure. Jani Nikula writes: > For example, you can use --no-exclude instead of --exclude=false in > notmuch show. If we had keyword flag arguments with some flags > defaulting to on, say --include=tags in notmuch

Re: [bug] [emacs] notmuch-show: names not shown on some mailing lists

William Casarin writes: > Jani Nikula writes: > >> The information comes from the cli. Can you reproduce this using some >> notmuch show --format=sexp --body=false query, perhaps on just one of >> the messages? > > I get this: > > :From "Person via Mailing

Re: [bug] [emacs] notmuch-show: names not shown on some mailing lists

Jani Nikula writes: > The information comes from the cli. Can you reproduce this using some > notmuch show --format=sexp --body=false query, perhaps on just one of > the messages? I get this: :From "Person via Mailing list\011" --

Re: [PATCH v3 11/15] config: indexing defaults will be stored in the database.

Daniel Kahn Gillmor writes: > static int > _print_db_config(notmuch_config_t *config, const char *name) > @@ -859,6 +860,8 @@ notmuch_config_command_get (notmuch_config_t *config, > char *item) > notmuch_built_with (item + strlen (BUILT_WITH_PREFIX)) ?

Re: [PATCH v3 09/15] gmime-extra: drop compat layer for g_mime_multipart_encrypted_decrypt

Daniel Kahn Gillmor writes: > In practice, we're going to see this function invoked differently > depending on which gmime we build against. The compatibility layer > forces our code into the lowest-common-denominator -- unable to make > use of new features even when

[PATCH 2/3] cli: use the negating boolean support for new and insert --no-hooks

This lets us use the positive hooks variable in code, increasing clarity. --- notmuch-insert.c | 6 +++--- notmuch-new.c| 8 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/notmuch-insert.c b/notmuch-insert.c index 32be74193472..6878313e188f 100644 ---

[PATCH 2/2] test: test regexp based new.ignore

Just some basics. --- test/T050-new.sh | 22 ++ 1 file changed, 22 insertions(+) diff --git a/test/T050-new.sh b/test/T050-new.sh index 272ed417aa2e..ee9ce08c8e86 100755 --- a/test/T050-new.sh +++ b/test/T050-new.sh @@ -259,6 +259,28 @@ ln -s i_do_not_exist

[PATCH 3/3] test: expand argument parsing sanity checks

Test the various boolean formats and --no- prefixed boolean and keyword flag arguments. --- test/T410-argument-parsing.sh | 28 1 file changed, 28 insertions(+) diff --git a/test/T410-argument-parsing.sh b/test/T410-argument-parsing.sh index

[PATCH 1/2] cli/new: support // in new.ignore

Add support for using // style regular expressions in new.ignore, mixed with the old style verbatim file and directory basenames. The regex is matched against the relative path from the database path. --- doc/man1/notmuch-config.rst | 21 +-- notmuch-new.c | 134

[PATCH 1/3] cli: add support for --no- prefixed boolean and keyword flag arguments

Add transparent support for negating boolean and keyword flag arguments using --no-argument style on the command line. That is, if the option description contains a boolean or a keyword flag argument named "argument", --no-argument will match and negate it. For boolean arguments this obviously

[PATCH] cli: allow empty strings for notmuch insert --folder argument

Now that it's easy to add argument specific modifiers in opt descriptions, add a new .allow_empty field to allow empty strings for individual string arguments while retaining strict checks elsewhere. Use this for notmuch insert --folder, where the empty string means top level folder. --- This

Re: [PATCH 0/3] nmbug:

On Tue, 10 Oct 2017, "W. Trevor King" wrote: > I expect the best time to make that bump is just before we cut our > next notmuch release. Once we do, we can update the wiki page [1] to > suggest nmbug 0.3+ and remove the checkout step from “Getting > started”. Could we add a

Re: [bug] [emacs] notmuch-show: names not shown on some mailing lists

On Tue, 10 Oct 2017, William Casarin wrote: > Hey there, > > Here's something I've noticed in some mailing list threads in notmuch-show: > > https://jb55.com/s/81d7c740ef60984d.png > > It doesn't look like it is showing the correct name. > Looking at the raw message, the From

Re: [PATCH v2 04/10] index: implement notmuch_indexopts_t with try_decrypt

On Mon, 09 Oct 2017, Daniel Kahn Gillmor wrote: > On Sat 2017-09-23 19:10:18 +0300, Jani Nikula wrote: >>> --- a/lib/indexopts.c >>> +++ b/lib/indexopts.c >>> @@ -21,9 +21,27 @@ >>> #include "notmuch-private.h" >>> >>> notmuch_indexopts_t * >>>

Re: [PATCH v3 10/15] crypto: index encrypted parts when indexopts try_decrypt is set.

Daniel Kahn Gillmor writes: > > "index.auto.decryption" has at least two different meanings at first > blush. For example, it might mean "this message was automatically > decrypted", which isn't necessarily the case. I think in either case you need to document what the