Header protection / memoryhole [was: Re: Header encryption / memoryhole]

2018-04-08 Thread Daniel Kahn Gillmor
On Mon 2018-04-02 18:58:28 +0200, Varac wrote:

> I'd like to know the state of header encryption support for
> notmuch (aka memoryhole) [1].

"memoryhole" refers to "protected headers", not just encrypted headers.
That is, the headers can be protected both by cryptographic signature
*and* by encryption.  This is a subtlety, but probably worth getting
right as we work on documentation and implementations.

This is on my list of things to work on for notmuch, but i'd be happy if
someone else beat me to it.  clearly i've taken too long to get this
done.

fwiw, memory-hole messages do display successfully in all versions of
notmuch i'm aware of, but they do so by rendering the "force-display"
part.  so notmuch currently uses the fallback arrangements as explicitly
intended by the original memoryhole draft.

as i see it, the steps are (in order):

 * handle encrypted subject correctly during message display time if the
   message is being decrypted.
 
 * handle encrypted subject specifically during message decryption at
   indexing time, storing it the correct subject field, instead of
   storing the "outside" subject.

 * suppress display of any "force-display" part during message display
   time.

 * handle any other cryptographically-protected headers during display
   and indexing.

 * generate protected headers when encrypting mail.


i welcome help with any of these steps :)

  --dkg


signature.asc
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch


Re: [PATCH 2/2] test: pytest runner for the test suite

2018-04-08 Thread Floris Bruynooghe
This series looks good to me, would be great to have!  Do you want to
commit them this or should I just incorporate it and submit together
with tests once actual tests exist.  You could always commit with a ``def
test_dummy(): assert True`` or something if you like.

Thanks!
Floris


On Sat 07 Apr 2018 at 18:39 -0300, David Bremner wrote:

> The 'test_subtest_known_broken' should be removed when there are
> actual tests to run.
>
> Based on a function from Tomi [1]
>
> [1]: id:m2r2nq23r9@guru.guru-group.fi
> ---
>  test/T391-pytest.sh | 14 ++
>  1 file changed, 14 insertions(+)
>  create mode 100755 test/T391-pytest.sh
>
> diff --git a/test/T391-pytest.sh b/test/T391-pytest.sh
> new file mode 100755
> index ..9ac7aabe
> --- /dev/null
> +++ b/test/T391-pytest.sh
> @@ -0,0 +1,14 @@
> +#!/usr/bin/env bash
> +test_description="python bindings (pytest)"
> +. $(dirname "$0")/test-lib.sh || exit 1
> +
> +test_require_external_prereq ${NOTMUCH_PYTHON}
> +
> +for bin in ${NOTMUCH_PYTEST_PYTHONS}; do
> +test_begin_subtest "pytest ($bin)"
> +  test_subtest_known_broken
> +   
> PYTHONPATH="$NOTMUCH_SRCDIR/bindings/python${PYTHONPATH:+:$PYTHONPATH}" \
> + test_expect_success "$bin -m pytest 
> $NOTMUCH_SRCDIR/bindings/python"
> +done
> +
> +test_done
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch


[PATCH] test: re-enable disabled test in T700-reindex.sh

2018-04-08 Thread David Bremner
The extra test_done looks like a typo
---
 test/T700-reindex.sh | 1 -
 1 file changed, 1 deletion(-)

diff --git a/test/T700-reindex.sh b/test/T700-reindex.sh
index 2b7bc658..9e795896 100755
--- a/test/T700-reindex.sh
+++ b/test/T700-reindex.sh
@@ -66,7 +66,6 @@ notmuch restore < prop-dump
 notmuch reindex '*'
 notmuch dump | grep '^#=' | sort > OUTPUT
 test_expect_equal_file prop-dump OUTPUT
-test_done
 
 add_email_corpus lkml
 
-- 
2.16.3

___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch