Re: [PATCH 07/20] cli/show: emit new whole-message crypto status output

2018-06-29 Thread David Bremner
Daniel Kahn Gillmor writes: > > So we have bumped from 1 to 2 with just a simple addition in the past. > But maybe that was from before we knew better? > probably. > At any rate, since the only thing that we're doing is emitting > message.crypto, i think we can avoid bumping the version in this

Re: [PATCH 07/20] cli/show: emit new whole-message crypto status output

2018-06-29 Thread Daniel Kahn Gillmor
On Fri 2018-06-15 20:47:59 -0300, David Bremner wrote: > Daniel Kahn Gillmor writes: > >> + >> +const _notmuch_message_crypto_t *msg_crypto = >> mime_node_get_message_crypto_status (node); >> +if (msg_crypto->sig_list || >> +msg_crypto->decryption_status != NOTMUCH_MESSAGE_DECRYPT

Re: [PATCH 17/20] cli/reply: add --protected-subject boolean flag

2018-06-29 Thread David Bremner
Daniel Kahn Gillmor writes: > This flag indicates the intent of the client to protect the subject > line, which allows "notmuch reply" to safely emit the earlier > message's encrypted subject without risking leaking it in the clear in > the reply. > > Obviously, it should only be used by a client

Re: [PATCH 14/20] test: show cryptographic envelope information for signed mails

2018-06-29 Thread David Bremner
Daniel Kahn Gillmor writes: > +test_begin_subtest "show cryptographic envelope on signed mail" > +output=$(notmuch show --verify --format=json > id:simple-signed-m...@crypto.notmuchmail.org) > +test_json_nodes <<<"$output" \ > +'crypto:[0][0][0]["crypto"]={"signed": {"status": >