Re: [PATCH v2 2/3] emacs: Pass the part to text/plain hook functions

2019-03-28 Thread David Bremner
David Edmondson writes: > Some text/plain hook functions may wish to access the details of the > part that is being manipulated. > --- > emacs/notmuch-show.el | 2 +- > emacs/notmuch-wash.el | 10 +- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git

Re: [PATCH v2 1/2] emacs: Optionally check for missing attachments in outgoing messages

2019-03-28 Thread David Bremner
David Edmondson writes: > Query the user if the message text indicates that an attachment is > expected but no MML referencing an attachment is found. > series pushed ___ notmuch mailing list notmuch@notmuchmail.org

Re: [PATCH 1/2] test: add two known broken tests searching for xapian keywords

2019-03-28 Thread David Bremner
David Bremner writes: > Thanks to plujon for pointing out this problem on IRC. The underlying > issue is that the quotes are stripped before the field processors get > the query string, and the heuristic for putting them back is not quite > right. > --- Series pushed. Let me know if it breaks

Re: [PATCH v1 1/1] emacs: Easy access to URLs mentioned in the current message

2019-03-28 Thread David Bremner
David Edmondson writes: > Add a new binding when looking at messages, B, that prompts with a > list of URLs found in the current message, if any. Open the one that > is selected in a browser. pushed, amended as discussed. d ___ notmuch mailing list

Re: [PATCH v1 1/1] emacs: Easy access to URLs mentioned in the current message

2019-03-28 Thread David Bremner
David Edmondson writes: > On Thursday, 2019-03-28 at 08:23:37 -03, David Bremner wrote: > >> David Edmondson writes: >> >> >>> +(defun notmuch-show--browse-urls () >>> + "Offer to browse any URLs in the current message." >>> + (interactive) >>> + (let ((urls (notmuch-show--gather-urls))) >>>

Re: [PATCH] NEWS: deprecate Emacs 24

2019-03-28 Thread David Bremner
David Edmondson writes: >> + >> +Support for GNU Emacs older than 24 is deprecated with this release, >> +and may be removed in a future release. >> + > > “older than 24” implies to me that 24 is supported. > > dme. > -- > I get this feeling I'm in motion, a sudden sense of liberty. Oops. I

Re: [PATCH] NEWS: deprecate Emacs 24

2019-03-28 Thread David Edmondson
On Thursday, 2019-03-28 at 08:31:03 -03, David Bremner wrote: > --- > NEWS | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/NEWS b/NEWS > index 9fcb57ed..5dffd5a2 100644 > --- a/NEWS > +++ b/NEWS > @@ -7,6 +7,12 @@ Command Line Interface > `notmuch show` now supports --body=false

Re: [PATCH v1 1/1] emacs: Easy access to URLs mentioned in the current message

2019-03-28 Thread David Edmondson
On Thursday, 2019-03-28 at 08:23:37 -03, David Bremner wrote: > David Edmondson writes: > > >> +(defun notmuch-show--browse-urls () >> + "Offer to browse any URLs in the current message." >> + (interactive) >> + (let ((urls (notmuch-show--gather-urls))) >> +(if urls >> +(browse-url

Re: [vim] Plugin crashes on certain multi-mime emails

2019-03-28 Thread David Bremner
Nicolas Lesser writes: > For some emails, notmuch-vim crashes. I can't figure out the reason for > this. The stack trace is: > > Error detected while processing function > 13_search_show_thread[10]..13_show: > line 39: > NoMethodError: undefined method `mime_type' for nil:NilClass > eval:22:in

[PATCH] NEWS: deprecate Emacs 24

2019-03-28 Thread David Bremner
--- NEWS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/NEWS b/NEWS index 9fcb57ed..5dffd5a2 100644 --- a/NEWS +++ b/NEWS @@ -7,6 +7,12 @@ Command Line Interface `notmuch show` now supports --body=false and --include-html with --format=text +Emacs +- + +Support for GNU Emacs

Re: inconsistent handling of stderr in notmuch-emacs

2019-03-28 Thread David Bremner
Tomi Ollila writes: > > for Older emacses the following code snippet could be utilized > (originally a13b38824 (Austin Clements 2013-05-31)): > > (proc (apply #'start-process name buffer > "/bin/sh" "-c" > "exec 2>\"$1\"; shift; exec \"$0\" \"$@\"" >

Re: [PATCH v1 1/1] emacs: Easy access to URLs mentioned in the current message

2019-03-28 Thread David Bremner
David Edmondson writes: > +(defun notmuch-show--browse-urls () > + "Offer to browse any URLs in the current message." > + (interactive) > + (let ((urls (notmuch-show--gather-urls))) > +(if urls > + (browse-url (completing-read "Browse URL: " (cdr urls) nil nil (car > urls))) > +

Re: [PATCH v2 1/2] emacs: Optionally check for missing attachments in outgoing messages

2019-03-28 Thread David Bremner
David Bremner writes: > > notmuch-mua-send-hook is not firing for me. I ran the following test > > ./devel/try-emac-mua -q > > (add-hook 'notmuch-mua-send-hook (lambda () (error "boo!"))) C-x C-e > (notmuch-hello) C-x C-e > m > delete Fcc header > C-c C-c > select trasport > > Nothing in