Re: [PATCH] emacs: Add References header to forwarded messages
On Fri 2019-03-29 13:01:09 +0100, Örjan Ekeberg wrote: > Include the message-id of forwarded messages in the new message. > This ensures that the new (forwarding) message is linked to the > same thread as the message being forwarded. This seems reasonable to me. I'd personally like forwarded messages to show up connected to the same thread os the originals, and i don't see a downside to it. --dkg ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
message forwarding features: challenges and open questions
over in the series introduced with id:20190330214821.4150-1-ekeb...@kth.se, Örjan Ekeberg proposed tagging messages when we've forwarded them. These changes got me thinking more generally about what capabilities a good MUA should offer related to message forwarding, and how to get notmuch-emacs closer to that vision. I don't mean these questions to get in the way of any review or merge of Örjan's series -- just thinking out loud here to try to document some things that might be useful in addition to the improvements already proposed. I guess you could think of this as a list of prototyped not-quite-feature-request or not-quite-bug-report items. If you see any of them as explicitly actionable, feel free to reply to it specifically and add more detail! explicit inter-message references - Do we want notmuch to know about the different *specific* messages that a "forwarded" tag implies? * For example, if i know that a message has been forwarded, can notmuch immediately find for me all the messages that included it? * Or, if i see a message is forwarded to me, and the original thread happens to also be in my mailstore, can the MUA get me to the original thread, with full context from just the forwarded message alone? forwarding multiple messages When bringing a new person into a pre-existing thread, it can be useful to give that person the full context. In environments where top-posting is tolerated/encouraged, that's done automatically, because each message contains all previous messages in the thread, to be read in "sewing machine stitch" order. bleah. More sensibly, it'd be nice to be able to forward the full thread in chronological order for the new person to review. * notmuch-emacs in "show" mode by default binds "F" to "notmuch-show-forward-open-messages", which is pretty handy. That said, it's still a bit janky to forward messages from multiple threads in a single message. Are there other ways that notmuch-emacs could make the operation "add a message (or more than one) to an existing unsent compose buffer" easier? * if there is a region marked (as opposed to just point selection) in a notmuch-show buffer, "f" (notmuch-show-forward-message) only generates a new message buffer which includes the given point (it ignores the marked region). Could we make it include the region? forwarding stripping/cleanup sometimes i forward messages because i want help in diagnosing problems with the message delivery -- in that case, i want to forward all headers. Other times, i just want the recipient to have access to the content, and i'd rather that they *don't* get to see all the intermediate "Received:", "Delivered-To:", "X-Original-To:" etc headers that got added to the message as it made its way to my inbox. * The forwarding offered by notmuch-emacs defaults to the "forwarding for debugging with headers" context. If i want to "forward for content", i currently edit the raw message in the compose buffer itself, manually stripping out certain headers. Is there some way to expose that distinction to the user (and help me avoid manual editing errors) without adding additional UI costs? sorry for the list of questions without concrete implementation suggestions! I hope these thoughts are at least more useful visible to the community than stuck inside my own head. all the best, --dkg signature.asc Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH 0/2] Updating tags when replying or forwarding via a buffer-local variable
On Sat 2019-03-30 22:48:19 +0100, Örjan Ekeberg wrote: > These patches implement a message-send-hook which uses a buffer-local variable > to tag replied and forwarded messages. > > The first patch replaces the current heuristic hook for detecting reply > messages with an explicit setting when the reply is composed. > > The second patch adds the corresponding mechanism for forwarded messages. > This patch is on top of a previously submitted patch (for adding a References > header), and will not apply cleanly without that. My elisp skills aren't sufficient for me to offer any substantive review for this series, but i like the proposal, and i think it looks like a useful feature addition to the notmuch-emacs MUA. Thanks for proposing it, Örjan! --dkg ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: notmuch ignoring alot of emails
"Alexei Gilchrist" writes: > That’s interesting. Do you know a link to the file spec for maildir > file content? All I can find is information about the directory > structure and file naming, not the file content. As far as I know, this is specified by RFC 5322. > mbsync which specialises in maildir also had an initial “From “ line > for me, and they are independently configured. I’ll try out a couple > of different mail hosts to see if it’s that. Yes, it could well determined by how the messages are delivered on the server. > I can imagine that mutt just assumes they are maildir files once > configured that way, but mu also assumes the files are maildir and also > uses gmime to parse. However the current version on home-brew (Mac) is > linked to a version of gmime which was fixed to accomodate multiple > “From “ lines I believe, though I haven’t dug through the source > yet. As I mentioned above, it's not really related to the version of GMime, it's about how GMime is called, and whether the client wishes to parse mbox files containing more than one message. Or to ignore the "From " line at the beginning. ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH 1/1] emacs: make editing a message as new include FCC
notmuchmail@leo.gaspard.io writes: > From: Léo Gaspard > pushed, with some of the cover text copied into the commit message. d ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH] Fix notmuch-describe-key
Yang Sheng writes: > Fix notmuch-describe-key crashing for the following two cases > 1. format-kbd-macro cannot deal with keys like [(32 . 126)], switch to > use key-description instead. > 2. if a function in the current keymap is not bounded, it will crash > the whole process. We check if it is bounded and silently skip it to > avoid crashing. pushed, d ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH] performance-test: fix copy-pasta in test description
David Bremner writes: > --- > performance-test/T03-reindex.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Fixed, with a more "serious" commit message. d ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH] doc: document notmuch new --verbose
Michal Sojka writes: > --- > doc/man1/notmuch-new.rst | 4 > 1 file changed, 4 insertions(+) pushed d ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH 3/4] lib: update commentary about path/folder terms
David Bremner writes: > We missed this when we changed to binary fields. pushed these 3 documentation patches. d ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: python bindings: fix return value types with ctypes
VA writes: > There were some typos, where restype was misspelled "resttype" and an > "argtypes" was lost. pushed. d ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: notmuch ignoring alot of emails
Alexei Gilchrist writes: > Every message file begins with “From “. This is true of all messages > downloaded by both offlineimap (with type = Maildir) and mbsync. > neomutt has no issues dealing with these files as maildir and mu has no > issues indexing them either. I’m assuming that stating with “From > “ is part of the maildir spec. FWIW, I use Offlineimap and files retreived with it here does not begin with "From". I see things like "Received: from..." or "Return-Path:..." as the beginning of the first line. > Try it. Send yourself a message with the line “From bad parsing comes > chaos” and see if your notmuch can find it. My version can’t. I tried that and find messages as expected. I mean, the message I sent and this thread. Best regards -- Tomas ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: notmuch ignoring alot of emails
On Sun, Mar 31 2019, Alexei Gilchrist wrote: >>> When I run notmuch I get a bunch (hundreds) of emails that are >>> ignored >>> with: >>> >>> Note: Ignoring non-mail file: ... >>> >>> The files are valid maildir files but have a paragraph somewhere in >>> the >>> body where someone has written "From ". >>> >> >> And do they also have have a line starting with "From " as the first >> line? This makes them mbox files. The second "From " makes them mbox >> files with multiple messages. Notmuch thinks your MDA (the thing that >> made those files) is misconfigured, assuming my guess about the format >> is correct. > > Every message file begins with “From “. This is true of all messages > downloaded by both offlineimap (with type = Maildir) and mbsync. > neomutt has no issues dealing with these files as maildir and mu has no > issues indexing them either. I’m assuming that stating with “From > “ is part of the maildir spec. > > The problem occurs specifically with notmuch. If someone sends a message > with a line that begins with “From “ in the *body* then it confuses > notmuch. > > mu can correctly index these messages but my mu is linked against > libgmime-2.6, my notmuch (0.28.3) is linked against libgmime-3.0. > > >>> Is there a fix to force the recognition of maildir files in this >>> case? I >>> thought this was a solved problem with gmime since 2.6.7. >> >> There is not currently a way to do that. It's not a GMime problem, >> it's >> a design choice of notmuch to avoid parsing multiple message >> mbox's. That was originally added as a safety feature, and I think it >> should probably stay the default. If someone wants work on adding a >> configuration switch I can point them in the right direction. > > This is a poor design decision. It means anyone on the internet can > break your mail setup simply by sending a message with a line starting > with “From “. > (and using usual quoted-printable Content-Transfer-Encoding). There are few things to remember in notmuch development: - notmuch is more of an evolution than intelligent design. it is hard to do any long-planned design when writing email software... - we all do welcome people do SMOP with notmuch and tolerate patches with good commit messages and elegant content. - it may take some time to get changes reviewed... In this particular case it would be nice if someone(tm) investigated how mu and neomutt handles these email -- and how broken (if at all) those go if those are given large mbox file... was it so that both of those can read mbox files... (which notmuch doesn't (but one can always use mboxvievfs! >;)))? > Try it. Send yourself a message with the line “From bad parsing comes > chaos” and see if your notmuch can find it. My version can’t. My MDA (md5mda.sh) does not add 'From ' as beginning of first line in my delivered emails (i.e. works similarly in this respect as David's MDA). Tomi ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: notmuch ignoring alot of emails
When I run notmuch I get a bunch (hundreds) of emails that are ignored with: Note: Ignoring non-mail file: ... The files are valid maildir files but have a paragraph somewhere in the body where someone has written "From ". And do they also have have a line starting with "From " as the first line? This makes them mbox files. The second "From " makes them mbox files with multiple messages. Notmuch thinks your MDA (the thing that made those files) is misconfigured, assuming my guess about the format is correct. Every message file begins with “From “. This is true of all messages downloaded by both offlineimap (with type = Maildir) and mbsync. neomutt has no issues dealing with these files as maildir and mu has no issues indexing them either. I’m assuming that stating with “From “ is part of the maildir spec. The problem occurs specifically with notmuch. If someone sends a message with a line that begins with “From “ in the *body* then it confuses notmuch. mu can correctly index these messages but my mu is linked against libgmime-2.6, my notmuch (0.28.3) is linked against libgmime-3.0. Is there a fix to force the recognition of maildir files in this case? I thought this was a solved problem with gmime since 2.6.7. There is not currently a way to do that. It's not a GMime problem, it's a design choice of notmuch to avoid parsing multiple message mbox's. That was originally added as a safety feature, and I think it should probably stay the default. If someone wants work on adding a configuration switch I can point them in the right direction. This is a poor design decision. It means anyone on the internet can break your mail setup simply by sending a message with a line starting with “From “. (and using usual quoted-printable Content-Transfer-Encoding). Try it. Send yourself a message with the line “From bad parsing comes chaos” and see if your notmuch can find it. My version can’t. ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
