Re: subsequent rebuilds of notmuch always re-build sphinx and ruby

2019-04-22 Thread David Bremner
Daniel Kahn Gillmor writes: > On Sun 2019-04-21 16:29:02 -0300, David Bremner wrote: >> the html rebuild is much faster than the texinfo + info rebuilds. > > agreed, in the runs that i've been doing as well. I was concerned that > the html rebuild itself may have been *triggering* the rebuild

Re: subsequent rebuilds of notmuch always re-build sphinx and ruby

2019-04-22 Thread Daniel Kahn Gillmor
On Sun 2019-04-21 16:29:02 -0300, David Bremner wrote: > the html rebuild is much faster than the texinfo + info rebuilds. agreed, in the runs that i've been doing as well. I was concerned that the html rebuild itself may have been *triggering* the rebuild of the texinfo stuff, though. Sounds

Re: [PATCH] emacs: drop use of message-default-charset

2019-04-22 Thread Tomi Ollila
On Mon, Apr 22 2019, Daniel Kahn Gillmor wrote: > Apparently, message-default-charset is deprecated, which causes the > following warning messages during the build: > > In notmuch-maildir-setup-message-for-saving: > emacs/notmuch-maildir-fcc.el:172:31:Warning: ‘message-default-charset’ is an

[PATCH v2 1/3] emacs: test notmuch-show during message decryption

2019-04-22 Thread Daniel Kahn Gillmor
We did not have a test showing what message decryption looks like within notmuch-emacs. This change gives us a baseline for future work on the notmuch-emacs interface. --- The difference between this and the prior version of the patch is that it updates T357-index-decryption.sh as well, to

[PATCH] emacs: drop use of message-default-charset

2019-04-22 Thread Daniel Kahn Gillmor
Apparently, message-default-charset is deprecated, which causes the following warning messages during the build: In notmuch-maildir-setup-message-for-saving: emacs/notmuch-maildir-fcc.el:172:31:Warning: ‘message-default-charset’ is an obsolete variable (as of 26.1); The default charset

Re: [PATCH] emacs: hint that notmuch-mua-attachment-regexp is a regular expression

2019-04-22 Thread Tomi Ollila
On Sat, Apr 20 2019, Daniel Kahn Gillmor wrote: > Without this change, we see the following warnings during the build: > > ``` > In toplevel form: > emacs/notmuch-mua.el:119:1:Warning: defcustom for > ‘notmuch-mua-attachment-regexp’ fails to specify type > emacs/notmuch-mua.el:119:1:Warning:

Re: [PATCH] cli/show: pass the siglist directly to the sigstatus sprinter

2019-04-22 Thread Tomi Ollila
On Sat, Apr 20 2019, Daniel Kahn Gillmor wrote: > This makes it easier to reuse format_part_sigstatus_sprinter() when we > have other places that we want to display a signature status. Change looks trivial enough (and reduces the "scope" function sees which is always good if it is enough -- I

Re: [PATCH] tests: move FINGERPRINT definition to add_gnupg_home

2019-04-22 Thread Tomi Ollila
On Sat, Apr 20 2019, Daniel Kahn Gillmor wrote: > If a test has added a GnuPG homedir, it may well want to know the > fingerprint. This saves us from having to redefine this magic string > in multiple places when more tests evenutally use the GnuPG homedir. This change looks good

Re: bug#35370: notmuch-emacs: avoiding deprecated message-default-charset

2019-04-22 Thread Eli Zaretskii
> From: Daniel Kahn Gillmor > Cc: npost...@gmail.com, da...@tethera.net, notmuch@notmuchmail.org, > 35...@debbugs.gnu.org > Date: Mon, 22 Apr 2019 10:21:25 -0400 > > > Just remove any uses of it. Why are you using it now? > > in notmuch's emacs/notmuch-maildir-fcc.el, as mentioned at the

Re: [PATCH 3/3] emacs: Drop content-free "Unknown signature status" button

2019-04-22 Thread Daniel Kahn Gillmor
The first two patches in this series should be uncontroversial (they're just establishing a baseline), and i'd appreciate it if they could be considered for merging regardless of whether anyone raises an objection to this last patch of the series. On Mon 2019-04-22 13:18:14 -0400, Daniel Kahn

[PATCH 3/3] emacs: Drop content-free "Unknown signature status" button

2019-04-22 Thread Daniel Kahn Gillmor
When we have not been able to evaluate the signature status of a given MIME part, showing a content-free (and interaction-free) "[ Unknown signature status ]" button doesn't really help the user at all, and takes up valuable screen real-estate. A visual reminder that a given message is *not*

[PATCH 1/3] emacs: test notmuch-show during message decryption

2019-04-22 Thread Daniel Kahn Gillmor
We did not have a test showing what message decryption looks like within notmuch-emacs. This change gives us a baseline for future work on the notmuch-emacs interface. --- test/T450-emacs-show.sh | 15 ++ test/corpora/crypto/basic-encrypted.eml | 28

[PATCH 2/3] test: show what emacs sees of an encrypted message when crypto is disabled

2019-04-22 Thread Daniel Kahn Gillmor
Some users may set notmuch-crypto-process-mime to nil, disabling all crypto use. We should have a baseline for what that looks like. --- test/T450-emacs-show.sh| 6 ++ .../notmuch-show-decrypted-message-no-crypto | 10 ++ 2 files changed, 16

Re: bug#35370: notmuch-emacs: avoiding deprecated message-default-charset

2019-04-22 Thread Daniel Kahn Gillmor
Hi Eli-- Thanks for the prompt followup! On Mon 2019-04-22 09:33:26 +0300, Eli Zaretskii wrote: > [dkg wrote:] >> Do you have any recommendation for how an external emacs module (which >> aims to work with at emacs 25 as well at least) should handle this? > > Just remove any uses of it. Why are

Re: bug#35370: notmuch-emacs: avoiding deprecated message-default-charset

2019-04-22 Thread Eli Zaretskii
> From: Daniel Kahn Gillmor > Date: Sun, 21 Apr 2019 21:55:38 -0400 > Cc: da...@tethera.net, notmuch@notmuchmail.org, 35...@debbugs.gnu.org > > Do you have any recommendation for how an external emacs module (which > aims to work with at emacs 25 as well at least) should handle this? Just

Re: bug#35370: notmuch-emacs: avoiding deprecated message-default-charset

2019-04-22 Thread Noam Postavsky
Daniel Kahn Gillmor writes: >>> In notmuch-maildir-setup-message-for-saving: >>> emacs/notmuch-maildir-fcc.el:172:31:Warning: ‘message-default-charset’ is an >>> obsolete variable (as of 26.1); The default charset comes from the >>> language environment >>> >>> I'm not enough of an emacs

Re: [PATCH] emacs: hint that notmuch-mua-attachment-regexp is a regular expression

2019-04-22 Thread Örjan Ekeberg
This addresses the same issue, and therefore overlaps with the patch I submitted a week ago. (id:20190415133519.4532-1-ekeb...@kth.se) /Örjan Daniel Kahn Gillmor writes: > Without this change, we see the following warnings during the build: > > ``` > In toplevel form: >