Re: [PATCH] travis: use ppa:notmuch/notmuch

2019-05-06 Thread David Bremner
Daniel Kahn Gillmor writes: > On Sun 2019-05-05 19:48:47 -0300, David Bremner wrote: >> Daniel Kahn Gillmor writes: >>> This should allow us to continue to use the Travis continuous >>> integration build on the release branch. >> >> And on master as well, I guess. > > yes, it should work on

Re: [PATCH] travis: use ppa:notmuch/notmuch

2019-05-06 Thread Daniel Kahn Gillmor
On Sun 2019-05-05 19:48:47 -0300, David Bremner wrote: > Daniel Kahn Gillmor writes: >> This should allow us to continue to use the Travis continuous >> integration build on the release branch. > > And on master as well, I guess. yes, it should work on both master and release. Please let me

Re: parallelize test suite

2019-05-06 Thread Daniel Kahn Gillmor
On Sun 2019-05-05 19:44:01 +0300, Tomi Ollila wrote: >> I actually think that CI and autobuilders *should* exercise the parallel >> tests, as annoying as that might be initially, because it seems likely >> to catch any other potential entanglements. > > ... after it has been proven a bit more to

Re: decryption error for signed+encrypted messages

2019-05-06 Thread Daniel Kahn Gillmor
blast from the past (cleaning up the bugtracker a bit). On Thu 2014-01-23 09:37:47 -0400, David Bremner wrote: > This bug seems to be (some time ago) marked fixed upstream > > https://bugzilla.gnome.org/show_bug.cgi?id=677088 This was definitely a bug in gmime, and it was resolved by gmime

Re: [PATCH] test: add configurable port to smtp-dummy

2019-05-06 Thread Daniel Kahn Gillmor
On Mon 2019-05-06 22:39:26 +0300, Tomi Ollila wrote: > we run smtp-dummy as: > >smtp_dummy_pid= >eval `$TEST_DIRECTORY/smtp-dummy --background sent_message` > > if process binds using port `0` system fill find available port for it... > > ... which smtp-dummy could return in a variable to

Re: [PATCH] tests: environment variable to specify that tests should be serialized

2019-05-06 Thread Daniel Kahn Gillmor
On Mon 2019-05-06 22:15:49 +0300, Tomi Ollila wrote: > While I like this parallelization option, and hope a version (could be even > David's smtp_dummy change) of it could be available in notmuch repository > as soon as possible, I would not like it being default -- just like make -J > is not

Re: [PATCH v2] configure: Ensure that GMime can extract session keys

2019-05-06 Thread Daniel Kahn Gillmor
On Mon 2019-05-06 16:16:55 -0400, Daniel Kahn Gillmor wrote: > GMime 3.0 and higher can extract session keys, but it will *not* > extract session keys if it was built with --disable-crypto, or if it > was built against GPGME version < 1.8.0. > > Notmuch currently expects to be able to extract

[PATCH v2] configure: Ensure that GMime can extract session keys

2019-05-06 Thread Daniel Kahn Gillmor
GMime 3.0 and higher can extract session keys, but it will *not* extract session keys if it was built with --disable-crypto, or if it was built against GPGME version < 1.8.0. Notmuch currently expects to be able to extract session keys, and tests will fail if it is not possible, so we ensure that

[PATCH] util/crypto: improve comment

2019-05-06 Thread Daniel Kahn Gillmor
The comment line here lingers from when we were using some fancy version checking about session keys. Correct it to match the current state. Signed-off-by: Daniel Kahn Gillmor --- util/crypto.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/crypto.c b/util/crypto.c

[PATCH] configure: Ensure that GMime can extract session keys

2019-05-06 Thread Daniel Kahn Gillmor
GMime 3.0 and higher can extract session keys, but it will *not* extract session keys if it was built with --disable-crypto, or if it was built against GPGME version < 1.8.0. Notmuch currently expects to be able to extract session keys, and tests will fail if it is not possible, so we ensure that

Re: [PATCH] test: add configurable port to smtp-dummy

2019-05-06 Thread Tomi Ollila
On Mon, May 06 2019, David Bremner wrote: > This is to allow smtp-dummy to potentially be used from multiple T*.sh > without collisions during parallel test running. > --- > test/T310-emacs.sh | 3 +++ > test/smtp-dummy.c | 7 ++- > test/test-lib.sh | 4 +++- > 3 files changed, 12

Re: [PATCH] tests: environment variable to specify that tests should be serialized

2019-05-06 Thread Tomi Ollila
On Mon, May 06 2019, Jameson Rollins wrote: > From: Jameson Graef Rollins > > If NOTMUCH_TEST_SERIALIZE is non-null all tests will be run in series, > rather than in parallel. While I like this parallelization option, and hope a version (could be even David's smtp_dummy change) of it could be

[PATCH v3 1/3] emacs: test notmuch-show during message decryption

2019-05-06 Thread Daniel Kahn Gillmor
We did not have a test showing what message decryption looks like within notmuch-emacs. This change gives us a baseline for future work on the notmuch-emacs interface. This differs from previous revisions of this patch in that it should be insensitive to the order in which the local filesystem

Re: [PATCH v2 1/3] emacs: test notmuch-show during message decryption

2019-05-06 Thread Daniel Kahn Gillmor
On Fri 2019-05-03 17:59:49 +, David Bremner wrote: > Daniel Kahn Gillmor writes: > >> We did not have a test showing what message decryption looks like >> within notmuch-emacs. This change gives us a baseline for future work >> on the notmuch-emacs interface. >> --- >> >> The difference

[PATCH] test: add configurable port to smtp-dummy

2019-05-06 Thread David Bremner
This is to allow smtp-dummy to potentially be used from multiple T*.sh without collisions during parallel test running. --- test/T310-emacs.sh | 3 +++ test/smtp-dummy.c | 7 ++- test/test-lib.sh | 4 +++- 3 files changed, 12 insertions(+), 2 deletions(-) diff --git a/test/T310-emacs.sh