Re: [PATCH 3/3] test/crypto: add_gnupg_home should have ultimate trust on "its own" key

2019-05-07 Thread Daniel Kahn Gillmor
On Tue 2019-05-07 06:50:29 -0300, David Bremner wrote: > Daniel Kahn Gillmor writes: > >> The typical use case for gpg is that if you control a secret key, you >> mark it with "ultimate" ownertrust. >> >> The opaque --import-ownertrust mechanism is GnuPG's standard mechanism >> to set up ultimate

Re: bug#35370: notmuch-emacs: avoiding deprecated message-default-charset

2019-05-07 Thread Eli Zaretskii
> From: Noam Postavsky > Cc: Daniel Kahn Gillmor , da...@tethera.net, > notmuch@notmuchmail.org, 35...@debbugs.gnu.org > Date: Tue, 07 May 2019 08:26:59 -0400 > > > Just remove any uses of it. Why are you using it now? > > Should we remove the remaining uses of it from Emacs too? I think

[PATCH] test: avoid unnecessary extraction of the test fingerprint

2019-05-07 Thread Daniel Kahn Gillmor
FINGERPRINT is already exported by add_gnupg_home, so this is unnecessary. This change also happens to get rid of the superfluous check-trustdb spew from the test suite that looked like this: gpg: checking the trustdb gpg: marginals needed: 3 completes needed: 1 trust model: pgp gpg: depth: 0

Re: [PATCH] test: let the OS choose a port for smtp-dummy

2019-05-07 Thread Daniel Kahn Gillmor
On Tue 2019-05-07 07:20:49 -0300, David Bremner wrote: > This should avoid potential collisions if we start running multiple > smtp-dummy processes in parallel. This is excellent, simple, and clearly the right thing to do. I've reviewed it, and am running it on my own development branch with no

Re: parallelize test suite

2019-05-07 Thread David Bremner
"Rollins, Jameson" writes: > This is a simple patch series that will run the entire test suite in > parallel if either the moreutils or GNU parallel utility is > available. On my 8-core machine the full test suite will now run in > under 20 seconds, which is a pretty huge improvement. I've

[PATCH] test: let the OS choose a port for smtp-dummy

2019-05-07 Thread David Bremner
This should avoid potential collisions if we start running multiple smtp-dummy processes in parallel. --- test/smtp-dummy.c | 15 ++- test/test-lib.sh | 2 +- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/test/smtp-dummy.c b/test/smtp-dummy.c index

Re: [PATCH 3/3] test/crypto: add_gnupg_home should have ultimate trust on "its own" key

2019-05-07 Thread David Bremner
Daniel Kahn Gillmor writes: > The typical use case for gpg is that if you control a secret key, you > mark it with "ultimate" ownertrust. > > The opaque --import-ownertrust mechanism is GnuPG's standard mechanism > to set up ultimate ownertrust (the ":6:" means "ultimate", for > whatever

Re: [PATCH] util/crypto: improve comment

2019-05-07 Thread David Bremner
Daniel Kahn Gillmor writes: > The comment line here lingers from when we were using some fancy > version checking about session keys. Correct it to match the current > state. pushed, d ___ notmuch mailing list notmuch@notmuchmail.org

Re: [PATCH] emacs: drop use of message-default-charset

2019-05-07 Thread David Bremner
Daniel Kahn Gillmor writes: > Apparently, message-default-charset is deprecated, which causes the > following warning messages during the build: > > In notmuch-maildir-setup-message-for-saving: > emacs/notmuch-maildir-fcc.el:172:31:Warning: ‘message-default-charset’ is an > obsolete

Re: [PATCH 1/2] emacs: Move notmuch-search-interactive-region to notmuch-lib as notmuch-interactive-region

2019-05-07 Thread David Bremner
pushed this one patch to master. d ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch