[PATCH] test-lib.sh: colors to test output when parallel(1) is run on tty

2019-05-08 Thread Tomi Ollila
Done via $COLORS_WITHOUT_TTY environment variable as passing options to commands through parallel(1) does not look trivial. Reorganized color checking in test-lib.sh a bit for this (perhaps were not fully necessary but rest still an improvement): - color checking commands in subshell are not

[BUG] emacs: notmuch-mua-attachment-check finds triggering string inside forwarded messages

2019-05-08 Thread Örjan Ekeberg
Hi all, I have found what seems to be a bug, or at least a misbehaviour of the "missing attachment warning" implemented by the otherwise so nice notmuch-mua-attachment-check. It works fine to detect the regexp for attachments in simple messages. The problem is that it also triggers the warning

[WIP PATCH] test: make test-serially to run test serially

2019-05-08 Thread Tomi Ollila
This is easier and less error prone than mistyping NOTMUCH_TEST_SERIALIZE manually from command line (mistype make test-serially and it just doesn't work) --- quick first version. this works, but someone(tm) w/ native english experience could say how the naming sounds like...

Re: [PATCH] test: let the OS choose a port for smtp-dummy

2019-05-08 Thread Tomi Ollila
On Tue, May 07 2019, Daniel Kahn Gillmor wrote: > On Tue 2019-05-07 07:20:49 -0300, David Bremner wrote: >> This should avoid potential collisions if we start running multiple >> smtp-dummy processes in parallel. > > This is excellent, simple, and clearly the right thing to do. I've > reviewed

Re: [PATCH] test: avoid unnecessary extraction of the test fingerprint

2019-05-08 Thread Tomi Ollila
On Tue, May 07 2019, Daniel Kahn Gillmor wrote: > FINGERPRINT is already exported by add_gnupg_home, so this is > unnecessary. This change also happens to get rid of the superfluous > check-trustdb spew from the test suite that looked like this: > > gpg: checking the trustdb > gpg: marginals

notmuch vim failing to show rfc822 attachments

2019-05-08 Thread Kay
Dear notmuchers, I've recently switched to using notmuch for mail management and I like it so far. The only thing stopping me from full joy is that neither alot nor the notmuch vim frontend can display message/rfc822 attachments. When I open the mails containing rfc822 attachments in alot, their

Re: bug#35370: notmuch-emacs: avoiding deprecated message-default-charset

2019-05-08 Thread Noam Postavsky
Eli Zaretskii writes: >> From: Daniel Kahn Gillmor >> Date: Sun, 21 Apr 2019 21:55:38 -0400 >> Cc: da...@tethera.net, notmuch@notmuchmail.org, 35...@debbugs.gnu.org >> >> Do you have any recommendation for how an external emacs module (which >> aims to work with at emacs 25 as well at least)

Re: [PATCH 2/2] emacs: Allow tagging regions in notmuch-tree

2019-05-08 Thread David Bremner
Thanks for contributing to Notmuch. Some generic comments: 1) Please consider a more comprehensive commit message [1]. The "why" here is maybe obvious, but consider pointing out whether this makes it more consistent with other parts of the UI (or not). Also, a (bit more extended) of