Re: bug#35370: notmuch-emacs: avoiding deprecated message-default-charset

2019-05-09 Thread Eli Zaretskii
> From: Lars Ingebrigtsen 
> Cc: Noam Postavsky ,  da...@tethera.net,  
> notmuch@notmuchmail.org,  d...@fifthhorseman.net,  35...@debbugs.gnu.org
> Date: Thu, 09 May 2019 14:33:15 -0400
> 
> Eli Zaretskii  writes:
> 
> > I think so, but I'd be happier if someone from the Gnus folks could
> > eyeball this patch.
> >
> > Lars, any comments/objections?
> 
> I think the patch looks OK -- it'll change the behaviour if you have
> set enable-multibyte-characters to nil, but...  does anybody do that?

If they do, it's their funeral.

Noam, please go ahead, and thanks.
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch


Re: [PATCH] lib/message-file: close stream in destructor

2019-05-09 Thread David Bremner
Will Dietz  writes:

> Great, thank you!
>
> Much appreciated, I actually was running into this yesterday.
>
> ( which for whatever reason led to posting this on the subject:
> https://github.com/afewmail/afew/issues/193#issuecomment-490766850 )
>
> Would the valgrind support in the test suite catch this sort of thing
> (fd leak on relatively common path)?
>

Good question. It didn't in a naive test I tried (just running notmuch
new under valgrind --track-fds). This is probably has to do with glib
cleaning up the relevant objects during shutdown.
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch


Re: [PATCH] lib/message-file: close stream in destructor

2019-05-09 Thread Will Dietz
Great, thank you!

Much appreciated, I actually was running into this yesterday.

( which for whatever reason led to posting this on the subject:
https://github.com/afewmail/afew/issues/193#issuecomment-490766850 )

Would the valgrind support in the test suite catch this sort of thing
(fd leak on relatively common path)?

Regardless, glad to see it fixed!

~Will

On Thu,  9 May 2019 21:23:24 -0300, David Bremner  wrote:
> Without this,
> 
> $ make time-test OPTIONS=--small
> 
> leads to fatal errors from too many open files.
> 
> Thanks to st-gourichon-fid for bringing this problem to my attention in IRC.
> ---
>  lib/message-file.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> The regression test could be improved, but I wanted to get a fix out
> and hopefully into master, as this is a problem that seems
> particularly likely to hit new users during their initial notmuch-new.
> 
> diff --git a/lib/message-file.c b/lib/message-file.c
> index 50855067..24c5fda4 100644
> --- a/lib/message-file.c
> +++ b/lib/message-file.c
> @@ -46,6 +46,9 @@ _notmuch_message_file_destructor (notmuch_message_file_t 
> *message)
>  if (message->message)
>   g_object_unref (message->message);
>  
> +if (message->stream)
> + g_object_unref (message->stream);
> +
>  return 0;
>  }
>  
> -- 
> 2.20.1
> 
> ___
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch


pgpZiLorIprpj.pgp
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch


[PATCH] lib/message-file: close stream in destructor

2019-05-09 Thread David Bremner
Without this,

$ make time-test OPTIONS=--small

leads to fatal errors from too many open files.

Thanks to st-gourichon-fid for bringing this problem to my attention in IRC.
---
 lib/message-file.c | 3 +++
 1 file changed, 3 insertions(+)

The regression test could be improved, but I wanted to get a fix out
and hopefully into master, as this is a problem that seems
particularly likely to hit new users during their initial notmuch-new.

diff --git a/lib/message-file.c b/lib/message-file.c
index 50855067..24c5fda4 100644
--- a/lib/message-file.c
+++ b/lib/message-file.c
@@ -46,6 +46,9 @@ _notmuch_message_file_destructor (notmuch_message_file_t 
*message)
 if (message->message)
g_object_unref (message->message);
 
+if (message->stream)
+   g_object_unref (message->stream);
+
 return 0;
 }
 
-- 
2.20.1

___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch