Re: bug#35370: notmuch-emacs: avoiding deprecated message-default-charset

2019-05-10 Thread Lars Ingebrigtsen
Eli Zaretskii writes: > I think so, but I'd be happier if someone from the Gnus folks could > eyeball this patch. > > Lars, any comments/objections? I think the patch looks OK -- it'll change the behaviour if you have set enable-multibyte-characters to nil, but... does anybody do that? --

Re: [PATCH 2/3] test: show what emacs sees of an encrypted message when crypto is disabled

2019-05-10 Thread David Bremner
Daniel Kahn Gillmor writes: > Some users may set notmuch-crypto-process-mime to nil, disabling all > crypto use. We should have a baseline for what that looks like. > --- pushed to master. ___ notmuch mailing list notmuch@notmuchmail.org

Re: [PATCH] lib/message-file: close stream in destructor

2019-05-10 Thread David Bremner
David Bremner writes: > Without this, > > $ make time-test OPTIONS=--small > > leads to fatal errors from too many open files. > > Thanks to st-gourichon-fid for bringing this problem to my attention in IRC. > --- > lib/message-file.c | 3 +++ > 1 file changed, 3 insertions(+) > > The

Re: bug#35370: notmuch-emacs: avoiding deprecated message-default-charset

2019-05-10 Thread Noam Postavsky
close 35370 quit Eli Zaretskii writes: >> From: Lars Ingebrigtsen >> I think the patch looks OK -- it'll change the behaviour if you have >> set enable-multibyte-characters to nil, but... does anybody do that? > > If they do, it's their funeral. > > Noam, please go ahead, and thanks. Done.

parallel tests broken on Debian stable

2019-05-10 Thread David Bremner
In a debian stretch neither gnu parallel nor moreutils parallel successfully completes the tests. Logs are attached. One thing worth investigating is that gnu parallel inside timeout doesn't really work right, since it says something like parallel: SIGTERM received. No new jobs will be started.

Re: [PATCH v3 1/3] emacs: test notmuch-show during message decryption

2019-05-10 Thread David Bremner
Daniel Kahn Gillmor writes: > We did not have a test showing what message decryption looks like > within notmuch-emacs. This change gives us a baseline for future work > on the notmuch-emacs interface. > > This differs from previous revisions of this patch in that it should > be insensitive to

Re: [PATCH] test: let the OS choose a port for smtp-dummy

2019-05-10 Thread David Bremner
David Bremner writes: > This should avoid potential collisions if we start running multiple > smtp-dummy processes in parallel. merged to master ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] test: avoid unnecessary extraction of the test fingerprint

2019-05-10 Thread David Bremner
Daniel Kahn Gillmor writes: > FINGERPRINT is already exported by add_gnupg_home, so this is > unnecessary. This change also happens to get rid of the superfluous > check-trustdb spew from the test suite that looked like this: > > gpg: checking the trustdb > gpg: marginals needed: 3 completes