Re: bug#35370: notmuch-emacs: avoiding deprecated message-default-charset
Eli Zaretskii writes: > I think so, but I'd be happier if someone from the Gnus folks could > eyeball this patch. > > Lars, any comments/objections? I think the patch looks OK -- it'll change the behaviour if you have set enable-multibyte-characters to nil, but... does anybody do that? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH 2/3] test: show what emacs sees of an encrypted message when crypto is disabled
Daniel Kahn Gillmor writes: > Some users may set notmuch-crypto-process-mime to nil, disabling all > crypto use. We should have a baseline for what that looks like. > --- pushed to master. ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH] lib/message-file: close stream in destructor
David Bremner writes: > Without this, > > $ make time-test OPTIONS=--small > > leads to fatal errors from too many open files. > > Thanks to st-gourichon-fid for bringing this problem to my attention in IRC. > --- > lib/message-file.c | 3 +++ > 1 file changed, 3 insertions(+) > > The regression test could be improved, but I wanted to get a fix out > and hopefully into master, as this is a problem that seems > particularly likely to hit new users during their initial notmuch-new. > > diff --git a/lib/message-file.c b/lib/message-file.c > index 50855067..24c5fda4 100644 > --- a/lib/message-file.c > +++ b/lib/message-file.c > @@ -46,6 +46,9 @@ _notmuch_message_file_destructor (notmuch_message_file_t > *message) > if (message->message) > g_object_unref (message->message); > > +if (message->stream) > + g_object_unref (message->stream); > + > return 0; > } > > -- > 2.20.1 I received several reports that this fixes the problem, so I've pushed it to master. ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: bug#35370: notmuch-emacs: avoiding deprecated message-default-charset
close 35370 quit Eli Zaretskii writes: >> From: Lars Ingebrigtsen >> I think the patch looks OK -- it'll change the behaviour if you have >> set enable-multibyte-characters to nil, but... does anybody do that? > > If they do, it's their funeral. > > Noam, please go ahead, and thanks. Done. 510aa7505f 2019-05-10T06:41:59-04:00 "Stop using message-default-charset (Bug#35370)" https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=510aa7505fc14e0ebc6a0d220160397f068c5c04 ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
parallel tests broken on Debian stable
In a debian stretch neither gnu parallel nor moreutils parallel successfully completes the tests. Logs are attached. One thing worth investigating is that gnu parallel inside timeout doesn't really work right, since it says something like parallel: SIGTERM received. No new jobs will be started. parallel: Waiting for these 8 jobs to finish. Send SIGTERM again to stop now. parallel: /home/bremner/notmuch/test/T357-index-decryption.sh parallel: /home/bremner/notmuch/test/T330-emacs-subject-to-filename.sh parallel: /home/bremner/notmuch/test/T310-emacs.sh parallel: /home/bremner/notmuch/test/T350-crypto.sh parallel: /home/bremner/notmuch/test/T355-smime.sh parallel: /home/bremner/notmuch/test/T160-json.sh parallel: /home/bremner/notmuch/test/T320-emacs-large-search-buffer.sh parallel: /home/bremner/notmuch/test/T170-sexp.sh and then doesn't stop. But the real question is why the jobs don't complete within a 2 minute timeout. The attached logs are from a stretch chroot running under buster. I also saw something similar on a stretch system running on real hardware. Unsurprisingly, the number of tests completed is non-determinstic, and varies from machine to machine and run to run. moreutils.log Description: Binary data gnuparallel.log Description: Binary data ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH v3 1/3] emacs: test notmuch-show during message decryption
Daniel Kahn Gillmor writes: > We did not have a test showing what message decryption looks like > within notmuch-emacs. This change gives us a baseline for future work > on the notmuch-emacs interface. > > This differs from previous revisions of this patch in that it should > be insensitive to the order in which the local filesystem readdir()s > the underlying maildir. pushed to master d ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH] test: let the OS choose a port for smtp-dummy
David Bremner writes: > This should avoid potential collisions if we start running multiple > smtp-dummy processes in parallel. merged to master ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH] test: avoid unnecessary extraction of the test fingerprint
Daniel Kahn Gillmor writes: > FINGERPRINT is already exported by add_gnupg_home, so this is > unnecessary. This change also happens to get rid of the superfluous > check-trustdb spew from the test suite that looked like this: > > gpg: checking the trustdb > gpg: marginals needed: 3 completes needed: 1 trust model: pgp > gpg: depth: 0 valid: 1 signed: 0 trust: 0-, 0q, 0n, 0m, 0f, 1u merged to master. That does indeed quiet down the noise I complained about. d ___ notmuch mailing list notmuch@notmuchmail.org https://notmuchmail.org/mailman/listinfo/notmuch
