[PATCH 1/4] build: require Xapian >= 1.4.0

This is necessary before we can support Xapian 1.5, which drops the old compact API, and replaces ValueRangeProcessor classes with RangeProcessor classes. It also simplifies maintainability as 3 previously optional features are now part of the baseline Xapian version. --- INSTALL | 7 + NEW

[PATCH 4/4] test: drop upgrade tests.

These rely on a pre-generated v1 database which happens to be chert format. This backend is not supported by Xapian 1.5. --- .travis.yml | 1 - configure | 2 +- test/T530-upgrade.sh | 136 --

[PATCH 3/4] lib: migrate from Xapian ValueRangeProcessor to RangeProcessor

This will be mandatory as of Xapian 1.5. The API is also more consistent with the FieldProcessor API, which helps code re-use a bit. Note that this switches to using the built-in Xapian support for prefixes on ranges (i.e. deleted code at beginning of ParseTimeRangeProcessor::operator(), added pr

Drop support for pre-1.4 Xapian, prepare for 1.5.x (v2)

This obsoletes id:20190414124445.3394-1-da...@tethera.net Compared to the previous version it - is rebased against master - has some unfortunate whitespace changes to INSTALL reverted. - now includes a removal of T530-upgrade.sh and supporting machinery. I'm not sure about the last p

[PATCH 2/4] lib: migrate to post Xapian 1.3.4 compact support

The old API was deprecated in Xapian 1.3.4 and (will be) removed in 1.5.0 --- lib/database.cc | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/lib/database.cc b/lib/database.cc index 1753117f..e4f38d6a 100644 --- a/lib/database.cc +++ b/lib/database.cc @@ -1211,11 +1211,7 @

Re: Drop support for pre-1.4 Xapian, prepare for 1.5.x

David Bremner writes: > David Bremner writes: > >> >> I forgot, there's one other failing test with xapian 1.5 >> >> T650-regexp-query: Testing regular expression searches >> FAIL null from: search >> --- T650-regexp-query.7.EXPECTED2019-04-15 11:03:10.128070898 >> + >>

Re: [PATCH 1/2] emacs: Move notmuch-search-interactive-region to notmuch-lib as notmuch-interactive-region

Hello, Sorry for answering late. On Mon, May 20 2019, Tomi Ollila wrote: > It is wiki -- look around the web page to see how to update. Thanks, I didn’t know it was wiki. I’ve pushed the amendment. [...] > s/patch/commit/ -- it is no longer patch when applied! > > it may be possible that db

Re: [PATCH v2 1/4] util/crypto: _notmuch_message_crypto: tracks message-wide crypto state

Daniel Kahn Gillmor writes: > +static int > +_notmuch_message_crypto_cleanup (_notmuch_message_crypto_t *msg_crypto) > +{ > +if (!msg_crypto) > + return 0; > +if (msg_crypto->sig_list) > + g_object_unref (msg_crypto->sig_list); > +return 0; > +} we currently call destructors

Re: [PATCH 2/2] n_m_remove_indexed_terms: reduce number of Xapian API calls.

David Bremner writes: > Previously this functioned scanned every term attached to a given > Xapian document. It turns out we know how to read only the terms we > need to preserve (and we might have already done so). This commit > replaces many calls to Xapian::Document::remove_term with one call

Re: [PATCH] test: allow disabling timeout with NOTMUCH_TEST_TIMEOUT=0

Daniel Kahn Gillmor writes: > Tests appear to be hanging when run under GNU timeout on debian > stretch. To aid in diagnosing this or similar problems, it's handy to > be able to disable timeout from the command line at will. > 1) Do we still need / want this? 2) care to reword the commit mess

Re: [PATCH] test: redirect STDIN from /dev/tty

Tomi Ollila writes: > On Tue, May 21 2019, David Bremner wrote: > >> Tomi Ollila writes: >> >>> Without this stdin may be anything that parent process provided for it. >>> >>> Test processes might have tried to read something from it, which would >>> have caused undeterministic behavior. >>> >>>