Re: [PATCH 3/3] emacs: Drop content-free "Unknown signature status" button

2019-05-23 Thread David Bremner
Daniel Kahn Gillmor  writes:

> diff --git a/emacs/notmuch-crypto.el b/emacs/notmuch-crypto.el
> index 353f721e..68171153 100644
> --- a/emacs/notmuch-crypto.el
> +++ b/emacs/notmuch-crypto.el
> @@ -93,6 +93,7 @@ mode."
>  (defun notmuch-crypto-insert-sigstatus-button (sigstatus from)
>(let* ((status (plist-get sigstatus :status))
>(help-msg nil)
> +  (show-button t)
>(label "Signature not processed")

This should probably be nil, since that particular value is never used,
iiuc. I can amend it if you agree.
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch


Re: getting all attachments, getting images

2019-05-23 Thread Rollins, Jameson
On Thu, May 23 2019, Danh Doan  wrote:
> On Thu, May 23, 2019 at 07:06:39AM -0700, meOme wrote:
>> Hi!
>> How can I get a list of all mails with an attachment in notmuch?
>
> Notmuch has already tagged all mails with attachment with tag:
> attachment, hasn't it?
>
> Does this command work for you?
>
> notmuch search tag:attachment

I think that tag is only applied for part show content-disposition is
"attachment".  Attachments with disposition "inline" I think will not
get the tag, and there's no consistent policy as to how the disposition
should be set.  Images can be inline, for instance.
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch


Re: getting all attachments, getting images

2019-05-23 Thread Danh Doan
On Thu, May 23, 2019 at 07:06:39AM -0700, meOme wrote:
> Hi!
> How can I get a list of all mails with an attachment in notmuch?

Notmuch has already tagged all mails with attachment with tag:
attachment, hasn't it?

Does this command work for you?

notmuch search tag:attachment

-- 
Danh
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch


Re: [PATCH 1/2] emacs: Move notmuch-search-interactive-region to notmuch-lib as notmuch-interactive-region

2019-05-23 Thread Leo Vivier
Hello,

David Bremner  writes:

[...]

> I would mention the actual function name in the subject.

Done.  

> I think 0.28.1 should be 0.29, no?

Changed it to 0.29.  I wasn’t sure whether to use the version number or
the commit ID.

Best,

-- 
Leo Vivier
English Studies & General Linguistics
Master Student, English Department
Université Rennes 2
>From a74a1cf358a768d89b68698fd3eeea198bf92b0d Mon Sep 17 00:00:00 2001
From: Leo Vivier 
Date: Mon, 20 May 2019 14:21:13 +0200
Subject: [PATCH] emacs: make notmuch-search-interactive-region obsolete

`notmuch-search-interactive-region' was moved to notmuch-lib.el in
f3cba19f882471a396a6b6175a709ccd1f6f34a0 and renamed to
`notmuch-interactive-region' without making the old function
obsolete, thereby breaking user-commands which made use of it.

This commit marks the function as obsolete and makes it an alias for
the new function.
---
 emacs/notmuch-lib.el | 5 +
 1 file changed, 5 insertions(+)

diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el
index 7fc342a5..8acad267 100644
--- a/emacs/notmuch-lib.el
+++ b/emacs/notmuch-lib.el
@@ -1017,6 +1017,11 @@ region if the region is active, or both `point' otherwise."
   (list (region-beginning) (region-end))
 (list (point) (point
 
+(define-obsolete-function-alias
+'notmuch-search-interactive-region
+'notmuch-interactive-region
+  "notmuch 0.29")
+
 (provide 'notmuch-lib)
 
 ;; Local Variables:
-- 
2.21.0

___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch


Re: [PATCH 1/2] emacs: Move notmuch-search-interactive-region to notmuch-lib as notmuch-interactive-region

2019-05-23 Thread David Bremner
Leo Vivier  writes:

> Hello,
>
> David Bremner  writes:
>
> [...]
>
>> I would mention the actual function name in the subject.
>
> Done.  
>
>> I think 0.28.1 should be 0.29, no?
>
> Changed it to 0.29.  I wasn’t sure whether to use the version number or
> the commit ID.

Thanks Leo, I've pushed that version to master.

d
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch


Re: getting all attachments, getting images

2019-05-23 Thread meOme
Oh I found the answer for the getting images question:
notmuch search mimetype:image
seems to work. :)
While the "all attachments"-question isn't solved yet...



--
Sent from: http://notmuch.198994.n3.nabble.com/
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch


getting all attachments, getting images

2019-05-23 Thread meOme
Hi!
How can I get a list of all mails with an attachment in notmuch?
I tried:
notmuch search attachment:'*'
but that doesn't seem to work, as the result is lesser than e.g.:
notmuch search attachment:jpg
in my case.
One more question:
How can i find all messages with an image as attachment?
Something like:
notmuch search attachment:image
which should result in jpg+png+... images, so the Content-Type: image/*
Is that possible in notmuch?
Thanks a lot again!



--
Sent from: http://notmuch.198994.n3.nabble.com/
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch


Re: [PATCH] test-lib.sh: "tidied" emacs_deliver_message ()

2019-05-23 Thread David Bremner
Tomi Ollila  writes:

> Added initialization and checking of smtp_dummy_port
> like it was done with smtp_dummy_pid.
>

pushed to master.

d
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch


Re: [PATCH 2/2] n_m_remove_indexed_terms: reduce number of Xapian API calls.

2019-05-23 Thread David Bremner
David Bremner  writes:

> Previously this functioned scanned every term attached to a given
> Xapian document. It turns out we know how to read only the terms we
> need to preserve (and we might have already done so). This commit
> replaces many calls to Xapian::Document::remove_term with one call to
> ::clear_terms, and a (typically much smaller) number of calls to
> ::add_term. Roughly speaking this is based on the assumption that most
> messages have more text than they have tags.

pushed to master.

d
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch


Re: [PATCH] test-lib.sh: colors to test output when parallel(1) is run on tty

2019-05-23 Thread David Bremner
Tomi Ollila  writes:

> Done via $COLORS_WITHOUT_TTY environment variable as passing options
> to commands through parallel(1) does not look trivial.

pushed to master

d
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch


Release 0.29.

2019-05-23 Thread David Bremner

I know there are several things "in progress", but we've also
accumulated a fair amount of change since 0.28. I am planning a feature
freeze for 0.29 on May 31 and (hopefully) a release on June 7.

d


signature.asc
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch


Re: [PATCH 1/2] emacs: Move notmuch-search-interactive-region to notmuch-lib as notmuch-interactive-region

2019-05-23 Thread David Bremner
Leo Vivier  writes:

> From f7b0390ee411dbeb8c2c6691f717675ab3a723c2 Mon Sep 17 00:00:00 2001
> From: Leo Vivier 
> Date: Mon, 20 May 2019 14:21:13 +0200
> Subject: [PATCH] emacs: make old function obsolete

I would mention the actual function name in the subject.

>  
> +(define-obsolete-function-alias
> +'notmuch-search-interactive-region
> +'notmuch-interactive-region
> +  "notmuch 0.28.1")
> +

I think 0.28.1 should be 0.29, no?

d
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch


Re: [PATCH v2 4/4] cli/show: emit new whole-message crypto status output

2019-05-23 Thread David Bremner
Daniel Kahn Gillmor  writes:

>  headers:headers,
> +crypto?:crypto,   # omitted if crypto disabled, or if no part 
> was signed or encrypted.
>  body?:  [part]# omitted if --body=false
>  }

I'm wondering about the "upward compatible" aspect of this. If the
crypto key is ommitted, a client doesn't know whether to interpret that
as no part was signed or encrypted, or just an older version of notmuch.

d

___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch