Re: Emacs: UI problems with messages excluded by several tags

2019-07-27 Thread David Bremner
Teemu Likonen writes: > > Let's test: > > $ notmuch config set search.exclude_tags exclude-1 exclude-2 > > Now add "exclude-1" tag for some message and it will show in "All tags" > section with count 1. > > All tags: [hide] > >1 exclude-1 > > Now add also "exclude-2" tag

Re: [PATCH] notmuch-dump.c: Fix output file being closed twice

2019-07-27 Thread David Bremner
Ralph Seichter writes: > Fixed: If the output file for a dump was non-writeable, gzclose_w() > was called twice on the output file handle, resulting in SIGABRT. LGTM, although I did have to revert one unrelated whitespace change. I'll push that later if no-one objects. d

Re: Bug: SIGABRT if "notmuch dump" output file is not writeable

2019-07-27 Thread David Bremner
Ralph Seichter writes: > gzclose_w(output) has already been called in line 332, before Notmuch > attempts to rename the temp file to the output file. At that point, > 'output' should be set to null as it is being checked later, but that > erroneously only happens in case the close operation

Re: [PATCH] notmuch-dump.c: Fix output file being closed twice

2019-07-27 Thread David Bremner
David Bremner writes: > Ralph Seichter writes: > >> Fixed: If the output file for a dump was non-writeable, gzclose_w() >> was called twice on the output file handle, resulting in SIGABRT. > > LGTM, although I did have to revert one unrelated whitespace change. > > I'll push that later if