Re: [PATCH 1/2] Show which notmuch command and version is being used

2019-11-18 Thread Floris Bruynooghe
On Mon 18 Nov 2019 at 07:43 -0400, David Bremner wrote:

> Floris Bruynooghe  writes:
>
>> This add the notmuch version and absolute path of the binary used
>> in the pytest header.  This is nice when running the tests
>> interactively as you get confirmation you're testing the version you
>> thought you were testing.
>> ---
>>  bindings/python-cffi/tests/conftest.py | 7 +++
>>  1 file changed, 7 insertions(+)
>>
>> diff --git a/bindings/python-cffi/tests/conftest.py 
>> b/bindings/python-cffi/tests/conftest.py
>> index aa940947..674c7218 100644
>> --- a/bindings/python-cffi/tests/conftest.py
>> +++ b/bindings/python-cffi/tests/conftest.py
>> @@ -10,6 +10,13 @@ import os
>>  import pytest
>>  
>>  
>> +def pytest_report_header():
>> +vers = subprocess.run(['notmuch', '--version'], stdout=subprocess.PIPE)
>> +which = subprocess.run(['which', 'notmuch'], stdout=subprocess.PIPE)
>
> I think it would be better to use "shutil.which()" here, to avoid
> variations in shell builtin vs executable which. If you agree I can make
> the change.

Oh nice, I always forget about shutil.  Please do make the change.

Thanks,
Floris
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch


Re: [PATCH 5/7] emacs/tree: add notmuch-tree-archive-message-than-next-or-exit

2019-11-18 Thread William Casarin
David Edmondson  writes:

> On Sunday, 2019-11-17 at 15:17:58 -08, William Casarin wrote:
>
>> I'll push out a v2 later if this gets enough Concept ACKs.
>
> The changes make sense to me in principle, but I don't use
> notmuch-tree. It would be good if someone who does could try them and
> comment.

I didn't either but I realized it's quite nice for viewing long threaded
discussions. The main  reason I never used it before  was because of the
different keybinds and missing functionality. My goal is to try to bring
as many  things over  as possible  so that  notmuch-show users  can feel
comfortable in notmuch-tree.

x/X was the  big one for me. The  only else perhaps is a  button to quit
both windows at the same time. I  added this functionality in one of the
patches (prefix argument to notmuch-tree-quit) so we just need a keybind
for it now.

If anyone  is interested in  trying this  out I've pushed  these patches
plus the M-RET binding to my github:

git fetch https://github.com/jb55/notmuch tree-improvements

Cheers,
Will

-- 
https://jb55.com
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch


Re: [PATCH 5/7] emacs/tree: add notmuch-tree-archive-message-than-next-or-exit

2019-11-18 Thread David Edmondson
On Sunday, 2019-11-17 at 15:17:58 -08, William Casarin wrote:

> I'll push out a v2 later if this gets enough Concept ACKs.

The changes make sense to me in principle, but I don't use
notmuch-tree. It would be good if someone who does could try them and
comment.

dme.
-- 
I do believe it's Madame Joy.
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch


Re: [PATCH 1/2] Show which notmuch command and version is being used

2019-11-18 Thread David Bremner
Floris Bruynooghe  writes:

> This add the notmuch version and absolute path of the binary used
> in the pytest header.  This is nice when running the tests
> interactively as you get confirmation you're testing the version you
> thought you were testing.
> ---
>  bindings/python-cffi/tests/conftest.py | 7 +++
>  1 file changed, 7 insertions(+)
>
> diff --git a/bindings/python-cffi/tests/conftest.py 
> b/bindings/python-cffi/tests/conftest.py
> index aa940947..674c7218 100644
> --- a/bindings/python-cffi/tests/conftest.py
> +++ b/bindings/python-cffi/tests/conftest.py
> @@ -10,6 +10,13 @@ import os
>  import pytest
>  
>  
> +def pytest_report_header():
> +vers = subprocess.run(['notmuch', '--version'], stdout=subprocess.PIPE)
> +which = subprocess.run(['which', 'notmuch'], stdout=subprocess.PIPE)

I think it would be better to use "shutil.which()" here, to avoid
variations in shell builtin vs executable which. If you agree I can make
the change.
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch