Re: [PATCH] notmuch(1): clarify documentation about --option/value separators

2020-05-07 Thread Carl Worth
On Thu, May 07 2020, Daniel Kahn Gillmor wrote: > +separator. Except for boolean options (wihch would be ambiguous), a Misspelling of "which". And while I'm here, strictly speaking Boolean is generally capitalized in English, (being one of those adjectives that is derived from a proper noun).

Re: [PATCH 2/2] smime: tests of X.509 certificate validity are known-broken on GMime < 3.2.7

2020-05-07 Thread Tomi Ollila
On Wed, May 06 2020, Daniel Kahn Gillmor wrote: > When checking cryptographic signatures, Notmuch relies on GMime to > tell it whether the certificate that signs a message has a valid User > ID or not. > > If the User ID is not valid, then notmuch does not report the signer's > User ID to the

[PATCH] notmuch(1): clarify documentation about --option/value separators

2020-05-07 Thread Daniel Kahn Gillmor
id:CA+Tk8fzRiqxWpd=r8=DRvEewNZXUZgD7MKyRLB1A=r-lxxg...@mail.gmail.com started a thread of discussion that showed that the cli's current idiosyncrasies around dealing with boolean options were not understandable. This attempts to improve the documentation at least (actual changes to the API might

status of the new python bindings

2020-05-07 Thread Anton Khirnov
Hi, I've started tinkering with the "new" Python bindings (python-cffi / python-notmuch2) and have a couple questions/comments about them: 1) What is the logic behind choosing whether something is exported as a property or as a method? E.g. Database.needs_upgrade is a property, while

Re: [PATCH 1/2] test-lib: mark function variables as local

2020-05-07 Thread Tomi Ollila
On Wed, May 06 2020, Daniel Kahn Gillmor wrote: > Several functions in test/test-lib.sh used variable names that are > also used outside of those functions (e.g. $output and $expected are > used in many of the test scripts), but they are not expected to > communicate via those variables. > > We