Re: [PATCH] emacs: split-window-sensibly in tree mode with open message

2020-05-09 Thread Radu Butoi
Hi David, David Bremner writes: > We seem to have got into the habit of updating the NEWS file right > before release. This seems to work OK, and avoids some conflicts between > patch series. Makes sense, probably something like: When opening message pane in tree-mode, split window

Re: [PATCH 1/2 v2] test-lib: mark function variables as local

2020-05-09 Thread David Bremner
Daniel Kahn Gillmor writes: > Several functions in test/test-lib.sh used variable names that are > also used outside of those functions (e.g. $output and $expected are > used in many of the test scripts), but they are not expected to > communicate via those variables. > > We mark those variables

Re: [PATCH 1/2 v2] test-lib: mark function variables as local

2020-05-09 Thread Tomi Ollila
On Fri, May 08 2020, Daniel Kahn Gillmor wrote: > Several functions in test/test-lib.sh used variable names that are > also used outside of those functions (e.g. $output and $expected are > used in many of the test scripts), but they are not expected to > communicate via those variables. > > We