Re: [PATCH] emacs: split-window-sensibly in tree mode with open message

2020-05-23 Thread Daniel Kahn Gillmor
On Fri 2020-05-22 19:58:19 +0100, Mark Walters wrote:
> As far as I can see the split-window-sensibly version splits the
> window into two equal parts, whereas the split-window-vertically
> version (deliberately) makes the message pane bigger than the thread
> pane.

I find this argument compelling.  When i've used split-pane MUAs, i
pretty much always want the tree view smaller than the message pane.


Description: PGP signature
notmuch mailing list

Re: python-cffi and ruby test suites fail in out-of-tree builds

2020-05-23 Thread Floris Bruynooghe

On Thu 21 May 2020 at 21:29 -0400, Daniel Kahn Gillmor wrote:

> Hey folks--
> I just did a bit of testing and cleanup for out-of-tree builds (see the
> minor patches that should have landed on the list in the last hour or
> two).

It probably is indeed the unfortunate case that copying the python
source is currently the easiest.  I had a quick look and it seemed like
one'd have to dig into the cffi setuptools support to make this work and
I'm not sure how successful that would be, but I admit I didn't feel
like trying.

> For me, "make check" in an out-of-tree build works fine now, with the
> exception of and

I checked out the python one, and maybe that's not too hard.  The
following patch made this work for both in tree and out of tree (on top
of your other patch):

modified   test/
@@ -8,7 +8,7 @@ fi
 test_begin_subtest "python cffi tests"
 printf "[pytest]\nminversion = 3.0\naddopts = -ra\n" > $pytest_dir/pytest.ini
 test_expect_success "(cd $pytest_dir && ${NOTMUCH_PYTHON} -m pytest 

Hope that's helpful.

notmuch mailing list

Re: [PATCH] configure: report GMime minimum version in ./configure output

2020-05-23 Thread David Bremner
Daniel Kahn Gillmor  writes:

> We already report the minimum version for Glib, zlib, and Xapian
> development libraries.  For consistency, report it for GMime as well.


notmuch mailing list

Re: [PATCH 2/2 v3] smime: tests of X.509 certificate validity are known-broken on GMime < 3.2.7

2020-05-23 Thread David Bremner
Daniel Kahn Gillmor  writes:

> We adapt to this by marking tests of reported User IDs for
> S/MIME-signed messages as known-broken if GMime is older than 3.2.7
> and has not been patched.


notmuch mailing list

Re: [PATCH v2 1/9] lib: index PKCS7 SignedData parts

2020-05-23 Thread David Bremner
Daniel Kahn Gillmor  writes:

> When we are indexing, we should treat SignedData parts the same way
> that we treat a multipart object, indexing the wrapped part as a
> distinct MIME object.

series pushed

notmuch mailing list