Re: Python 3.x bindings support which versions, exactly?

2020-05-24 Thread Ralph Seichter
* David Bremner: > That's another reason for me to get a release out the door soon. Given how long ago the old Python bindings were written, I can wait a bit longer for the improved version. ;-) Still, I am looking forward to the next Notmuch release. -Ralph

Feature freeze for notmuch 0.30: June 1

2020-05-24 Thread David Bremner
I plan to tag the first release candidate for notmuch 0.30 on June 1. It's long past time we had a release, and the new python bindings in particular need a wider audience. Per usual, I'll accept (some) bug fixes and NEWS updates after that date. d signature.asc Description: PGP signature

Re: [PATCH v3 2/3] emacs: Add simple make target to compile emacs lisp tests

2020-05-24 Thread David Bremner
Jonas Bernoulli writes: > > +compile-elisp-tests: > + $(EMACS) --batch -L emacs -L test -l notmuch.el -l test-lib.el -f \ > + batch-byte-compile test/*.el > + Can you explain a bit (perhaps in an updated commit message) why we need this target? thanks! David

Re: Python 3.x bindings support which versions, exactly?

2020-05-24 Thread David Bremner
Ralph Seichter writes: > * David Bremner: > >> The new bindings (modulename= notmuch2) should work with any python >> recent 3.x. They still have a few rough edges afaiu, but definitely >> new projects should target the new bindings. > > Alas, there are no release archives available yet which

Re: Python 3.x bindings support which versions, exactly?

2020-05-24 Thread Ralph Seichter
* David Bremner: > The new bindings (modulename= notmuch2) should work with any python > recent 3.x. They still have a few rough edges afaiu, but definitely > new projects should target the new bindings. Alas, there are no release archives available yet which contain the new bindings. I was

Re: Python 3.x bindings support which versions, exactly?

2020-05-24 Thread David Bremner
Ralph Seichter writes: > Hello, > > having examined the source code, I assume that Notmuch's Python bindings > should support Python 3.x for any given 'x'. However, reading the Travis > logs at https://travis-ci.org/notmuch/notmuch and .travis.yml, the CI > tests apparently run on Ubuntu 18.04

Re: [PATCH v3 3/3] emacs: Use `dolist' instead of `mapcar' for side-effects

2020-05-24 Thread Tomi Ollila
On Sat, Apr 25 2020, Jonas Bernoulli wrote: > As recommended by the byte-compiler. I don't know about v3 2/3, but this, v3 3/3 looks good to me. Tomi > --- > test/emacs-attachment-warnings.el | 23 +++ > 1 file changed, 11 insertions(+), 12 deletions(-) > > diff --git

[PATCH] emacs docstrings: consistent indentation, newlines, periods

2020-05-24 Thread Tomi Ollila
Fixed emacs docstrings to be consistent. No functional change. - removed some (accidental) indentation - removed some trailing newlines - added trailing periods where missing (some exclusions) --- V2 of id:"20200503212136.11070-1-tomi.oll...@iki.fi" changes to v1: - trailing periods removed

Python 3.x bindings support which versions, exactly?

2020-05-24 Thread Ralph Seichter
Hello, having examined the source code, I assume that Notmuch's Python bindings should support Python 3.x for any given 'x'. However, reading the Travis logs at https://travis-ci.org/notmuch/notmuch and .travis.yml, the CI tests apparently run on Ubuntu 18.04 and use only Python 3.6. While I

Re: [PATCH] tests: fix test_json_nodes() in out-of-tree builds

2020-05-24 Thread Tomi Ollila
On Thu, May 21 2020, Daniel Kahn Gillmor wrote: > In out-of-tree builds, $TEST_DIRECTORY doesn't contain > json_check_nodes.py. This caused 27 tests to fail in such an > environment. are you shure the run_emacs.sh change in id:"20200423212643.864-1-tomi.oll...@iki.fi" is not needed ? =D