Re: Python 3.x bindings support which versions, exactly?

2020-05-24 Thread Ralph Seichter
* David Bremner:

> That's another reason for me to get a release out the door soon.

Given how long ago the old Python bindings were written, I can wait a
bit longer for the improved version. ;-) Still, I am looking forward to
the next Notmuch release.

-Ralph
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch


Feature freeze for notmuch 0.30: June 1

2020-05-24 Thread David Bremner

I plan to tag the first release candidate for notmuch 0.30 on June
1. It's long past time we had a release, and the new python bindings in
particular need a wider audience.  Per usual, I'll accept (some) bug
fixes and NEWS updates after that date.

d


signature.asc
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch


Re: [PATCH v3 2/3] emacs: Add simple make target to compile emacs lisp tests

2020-05-24 Thread David Bremner
Jonas Bernoulli  writes:

>  
> +compile-elisp-tests:
> + $(EMACS) --batch -L emacs -L test -l notmuch.el -l test-lib.el -f \
> + batch-byte-compile test/*.el
> +

Can you explain a bit (perhaps in an updated commit message) why we need
this target?

thanks!

David
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch


Re: Python 3.x bindings support which versions, exactly?

2020-05-24 Thread David Bremner
Ralph Seichter  writes:

> * David Bremner:
>
>> The new bindings (modulename= notmuch2) should work with any python
>> recent 3.x. They still have a few rough edges afaiu, but definitely
>> new projects should target the new bindings.
>
> Alas, there are no release archives available yet which contain the new
> bindings. I was hoping to add Python 3.8 support for the Gentoo Linux
> package I maintain, but our ebuilds rely on tagged releases of the
> packaged software.

Sorry about that. That's another reason for me to get a release out the
door soon.

d
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch


Re: Python 3.x bindings support which versions, exactly?

2020-05-24 Thread Ralph Seichter
* David Bremner:

> The new bindings (modulename= notmuch2) should work with any python
> recent 3.x. They still have a few rough edges afaiu, but definitely
> new projects should target the new bindings.

Alas, there are no release archives available yet which contain the new
bindings. I was hoping to add Python 3.8 support for the Gentoo Linux
package I maintain, but our ebuilds rely on tagged releases of the
packaged software.

-Ralph
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch


Re: Python 3.x bindings support which versions, exactly?

2020-05-24 Thread David Bremner
Ralph Seichter  writes:

> Hello,
>
> having examined the source code, I assume that Notmuch's Python bindings
> should support Python 3.x for any given 'x'. However, reading the Travis
> logs at https://travis-ci.org/notmuch/notmuch and .travis.yml, the CI
> tests apparently run on Ubuntu 18.04 and use only Python 3.6.
>
> While I hope there won't be any problems with Python 3.7, 3.8 and 3.9,
> I wanted to ask here first if anybody has tested this yet?

the old (modulename = notmuch) bindings actually do have memory
management issues with python > 3.6 (maybe also with 3.6). The new
bindings (modulename= notmuch2) should work with any python recent
3.x. They still have a few rough edges afaiu, but definitely new
projects should target the new bindings.

d
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch


Re: [PATCH v3 3/3] emacs: Use `dolist' instead of `mapcar' for side-effects

2020-05-24 Thread Tomi Ollila
On Sat, Apr 25 2020, Jonas Bernoulli wrote:

> As recommended by the byte-compiler.

I don't know about v3 2/3, but this, v3 3/3 looks good to me.

Tomi

> ---
>  test/emacs-attachment-warnings.el | 23 +++
>  1 file changed, 11 insertions(+), 12 deletions(-)
>
> diff --git a/test/emacs-attachment-warnings.el 
> b/test/emacs-attachment-warnings.el
> index a23692d7..8f4918ef 100644
> --- a/test/emacs-attachment-warnings.el
> +++ b/test/emacs-attachment-warnings.el
> @@ -67,16 +67,15 @@ (defvar attachment-check-tests
>  
>  (defun notmuch-test-attachment-warning-1 ()
>(let (output expected)
> -(mapcar (lambda (test)
> -   (let* ((expect (car test))
> -  (body (cdr test))
> -  (result (attachment-check-test body)))
> - (push expect expected)
> - (push (if (eq result expect)
> -   result
> - ;; In the case of a failure, include the test
> - ;; details to make it simpler to debug.
> - (format "%S <-- %S" result body))
> -   output)))
> - attachment-check-tests)
> +(dolist (test attachment-check-tests)
> +  (let* ((expect (car test))
> +  (body (cdr test))
> +  (result (attachment-check-test body)))
> + (push expect expected)
> + (push (if (eq result expect)
> +   result
> + ;; In the case of a failure, include the test
> + ;; details to make it simpler to debug.
> + (format "%S <-- %S" result body))
> +   output)))
>  (notmuch-test-expect-equal output expected)))
> -- 
> 2.26.0
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch


[PATCH] emacs docstrings: consistent indentation, newlines, periods

2020-05-24 Thread Tomi Ollila
Fixed emacs docstrings to be consistent. No functional change.

- removed some (accidental) indentation
- removed some trailing newlines
- added trailing periods where missing (some exclusions)
---

V2 of id:"20200503212136.11070-1-tomi.oll...@iki.fi"

changes to v1:
- trailing periods removed when example code in comments
- re-indented (setq's after For example: ..
- all 'tree view' consistently uncapitalized now 

 emacs/notmuch-address.el | 21 -
 emacs/notmuch-draft.el   |  6 +--
 emacs/notmuch-hello.el   | 11 ++---
 emacs/notmuch-jump.el|  3 +-
 emacs/notmuch-lib.el |  8 ++--
 emacs/notmuch-maildir-fcc.el |  4 +-
 emacs/notmuch-mua.el |  2 +-
 emacs/notmuch-query.el   | 13 +++---
 emacs/notmuch-show.el| 22 -
 emacs/notmuch-tag.el |  8 ++--
 emacs/notmuch-tree.el| 90 ++--
 emacs/notmuch-wash.el|  2 +-
 emacs/notmuch.el | 34 +++---
 13 files changed, 110 insertions(+), 114 deletions(-)

diff --git a/emacs/notmuch-address.el b/emacs/notmuch-address.el
index 64887a43..0d56fba7 100644
--- a/emacs/notmuch-address.el
+++ b/emacs/notmuch-address.el
@@ -29,11 +29,11 @@
 (declare-function company-manual-begin "company")
 
 (defvar notmuch-address-last-harvest 0
-  "Time of last address harvest")
+  "Time of last address harvest.")
 
 (defvar notmuch-address-completions (make-hash-table :test 'equal)
   "Hash of email addresses for completion during email composition.
-  This variable is set by calling `notmuch-address-harvest'.")
+This variable is set by calling `notmuch-address-harvest'.")
 
 (defvar notmuch-address-full-harvest-finished nil
   "t indicates that full completion address harvesting has been
@@ -73,11 +73,11 @@ (defcustom notmuch-address-internal-completion '(sent nil)
   "Determines how internal address completion generates candidates.
 
 This should be a list of the form '(DIRECTION FILTER), where
- DIRECTION is either sent or received and specifies whether the
- candidates are searched in messages sent by the user or received
- by the user (note received by is much faster), and FILTER is
- either nil or a filter-string, such as \"date:1y..\" to append
- to the query."
+DIRECTION is either sent or received and specifies whether the
+candidates are searched in messages sent by the user or received
+by the user (note received by is much faster), and FILTER is
+either nil or a filter-string, such as \"date:1y..\" to append
+to the query."
   :type '(list :tag "Use internal address completion"
   (radio
:tag "Base completion on messages you have"
@@ -126,8 +126,7 @@ (defcustom notmuch-address-post-completion-functions nil
 
 The completed address is passed as an argument to each function.
 Note that this hook will be invoked for completion in headers
-matching `notmuch-address-completion-headers-regexp'.
-"
+matching `notmuch-address-completion-headers-regexp'."
   :type 'hook
   :group 'notmuch-address
   :group 'notmuch-hooks)
@@ -147,7 +146,7 @@ (defun notmuch-address-message-insinuate ()
   (message "calling notmuch-address-message-insinuate is no longer needed"))
 
 (defcustom notmuch-address-use-company t
-  "If available, use company mode for address completion"
+  "If available, use company mode for address completion."
   :type 'boolean
   :group 'notmuch-send
   :group 'notmuch-address)
@@ -285,7 +284,7 @@ (defun notmuch-address-harvest-filter (proc string)
 (defvar notmuch-address-harvest-procs '(nil . nil)
   "The currently running harvests.
 
-The car is a partial harvest, and the cdr is a full harvest")
+The car is a partial harvest, and the cdr is a full harvest.")
 
 (defun notmuch-address-harvest ( addr-prefix synchronous callback)
   "Collect addresses completion candidates.
diff --git a/emacs/notmuch-draft.el b/emacs/notmuch-draft.el
index 504b33be..27abc7d9 100644
--- a/emacs/notmuch-draft.el
+++ b/emacs/notmuch-draft.el
@@ -76,7 +76,7 @@ (defcustom notmuch-draft-quoted-tags '()
 
 (defcustom notmuch-draft-save-plaintext 'ask
   "Should notmuch save/postpone in plaintext messages that seem
-  like they are intended to be sent encrypted
+like they are intended to be sent encrypted
 (i.e with an mml encryption tag in it)."
   :type '(radio
  (const :tag "Never" nil)
@@ -87,10 +87,10 @@ (defcustom notmuch-draft-save-plaintext 'ask
 
 (defvar notmuch-draft-encryption-tag-regex
   "<#\\(part encrypt\\|secure.*mode=.*encrypt>\\)"
-  "Regular expression matching mml tags indicating encryption of part or 
message")
+  "Regular expression matching mml tags indicating encryption of part or 
message.")
 
 (defvar notmuch-draft-id nil
-  "Message-id of the most recent saved draft of this message")
+  "Message-id of the most recent saved draft of this message.")
 (make-variable-buffer-local 'notmuch-draft-id)
 
 (defun notmuch-draft--mark-deleted ()
diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
index 

Python 3.x bindings support which versions, exactly?

2020-05-24 Thread Ralph Seichter
Hello,

having examined the source code, I assume that Notmuch's Python bindings
should support Python 3.x for any given 'x'. However, reading the Travis
logs at https://travis-ci.org/notmuch/notmuch and .travis.yml, the CI
tests apparently run on Ubuntu 18.04 and use only Python 3.6.

While I hope there won't be any problems with Python 3.7, 3.8 and 3.9,
I wanted to ask here first if anybody has tested this yet?

-Ralph
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch


Re: [PATCH] tests: fix test_json_nodes() in out-of-tree builds

2020-05-24 Thread Tomi Ollila
On Thu, May 21 2020, Daniel Kahn Gillmor wrote:

> In out-of-tree builds, $TEST_DIRECTORY doesn't contain
> json_check_nodes.py.  This caused 27 tests to fail in such an
> environment.

are you shure the run_emacs.sh change in 

id:"20200423212643.864-1-tomi.oll...@iki.fi"

is not needed ? =D

Tomi

>
> Signed-off-by: Daniel Kahn Gillmor 
> ---
>  test/test-lib.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/test/test-lib.sh b/test/test-lib.sh
> index 58972339..792b1cb9 100644
> --- a/test/test-lib.sh
> +++ b/test/test-lib.sh
> @@ -556,7 +556,7 @@ test_json_nodes () {
>  
>   if ! test_skip "$test_subtest_name"
>   then
> - output=$(PYTHONIOENCODING=utf-8 $NOTMUCH_PYTHON 
> "$TEST_DIRECTORY"/json_check_nodes.py "$@")
> + output=$(PYTHONIOENCODING=utf-8 $NOTMUCH_PYTHON 
> "$NOTMUCH_SRCDIR"/test/json_check_nodes.py "$@")
>   if [ "$?" = 0 ]
>   then
>   test_ok_
> -- 
> 2.26.2
>
> ___
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch