Re: [PATCH 1/2] python/notmuch2: do not destroy messages owned by a query

2020-06-10 Thread Tomi Ollila
Hi Anton,

On Thu, May 21 2020, Anton Khirnov wrote:

> ping

Great (an important) stuff in this series !

...just that...

Floris did good review on your changes the next day.

What I remember was there (looked 30 mins ago)

- style: somewhat important (I press more there). Easy to get better,
 good and consistent style makes it better

- docs in code: like Floris mentioned, the docs in commit messages are
are not seen by user. The relevant documentation is 
to be with the code. commit message tells what was done
and why

- tests: since pytest is used to test the current notmuch2 cffi python
 tests, all new code that can be tested pytest code to do so
 is to be added

And these have to be done now -- postponing such a things into future
will just mean that it never happens, and the messines and entropy of
the notmuch code gets even greater in such a case...

> -- 
> Anton Khirnov

notmuch mailing list

Re: [PATCH v2] configure: use cffi.FFI().verify() to test buildability of CFFI bindings

2020-06-10 Thread David Bremner
Tomi Ollila  writes:

> Checking existence of pyconfig.h to determine whether CFFI-based
> notmuch bindings are buildable is not enough; for example Fedora 32
> ships pyconfig.h in python3-libs package, but python3-devel is required
> to be installed for the bindings to build.
> Executing cffi.FFI().verify() is pretty close to what is done in
> bindings/python-cffi/notmuch2/ to get the c code part of the
> bindings built.

v2 pushed to master and release


notmuch mailing list